Re: [PATCH v2 037/110] minix: use PRIino format for i_ino

2026-03-03 Thread Jan Kara
On Mon 02-03-26 15:24:21, Jeff Layton wrote:
> Convert minix i_ino format strings to use the PRIino format
> macro in preparation for the widening of i_ino via kino_t.
> 
> Signed-off-by: Jeff Layton 

Looks good. Feel free to add:

Reviewed-by: Jan Kara 

Honza

> ---
>  fs/minix/inode.c | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/minix/inode.c b/fs/minix/inode.c
> index 
> 99541c6a5bbf13f3be27474a316b31d8db9fbce0..d92059227d273564c86f100dea3366be4509090b
>  100644
> --- a/fs/minix/inode.c
> +++ b/fs/minix/inode.c
> @@ -36,7 +36,7 @@ void __minix_error_inode(struct inode *inode, const char 
> *function,
>   vaf.fmt = fmt;
>   vaf.va = &args;
>   printk(KERN_CRIT "minix-fs error (device %s): %s:%d: "
> -"inode #%lu: comm %s: %pV\n",
> +"inode #%" PRIino "u: comm %s: %pV\n",
>  inode->i_sb->s_id, function, line, inode->i_ino,
>  current->comm, &vaf);
>   va_end(args);
> @@ -520,7 +520,7 @@ void minix_set_inode(struct inode *inode, dev_t rdev)
>  S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
>   init_special_inode(inode, inode->i_mode, rdev);
>   } else {
> - printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode 
> %lu.\n",
> + printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode 
> %" PRIino "u.\n",
>  inode->i_mode, inode->i_ino);
>   make_bad_inode(inode);
>   }
> @@ -542,7 +542,7 @@ static struct inode *V1_minix_iget(struct inode *inode)
>   return ERR_PTR(-EIO);
>   }
>   if (raw_inode->i_nlinks == 0) {
> - printk("MINIX-fs: deleted inode referenced: %lu\n",
> + printk("MINIX-fs: deleted inode referenced: %" PRIino "u\n",
>  inode->i_ino);
>   brelse(bh);
>   iget_failed(inode);
> @@ -580,7 +580,7 @@ static struct inode *V2_minix_iget(struct inode *inode)
>   return ERR_PTR(-EIO);
>   }
>   if (raw_inode->i_nlinks == 0) {
> - printk("MINIX-fs: deleted inode referenced: %lu\n",
> + printk("MINIX-fs: deleted inode referenced: %" PRIino "u\n",
>  inode->i_ino);
>   brelse(bh);
>   iget_failed(inode);
> @@ -692,7 +692,7 @@ static int minix_write_inode(struct inode *inode, struct 
> writeback_control *wbc)
>   if (wbc->sync_mode == WB_SYNC_ALL && buffer_dirty(bh)) {
>   sync_dirty_buffer(bh);
>   if (buffer_req(bh) && !buffer_uptodate(bh)) {
> - printk("IO error syncing minix inode [%s:%08lx]\n",
> + printk("IO error syncing minix inode [%s:%08" PRIino 
> "x]\n",
>   inode->i_sb->s_id, inode->i_ino);
>   err = -EIO;
>   }
> 
> -- 
> 2.53.0
> 
-- 
Jan Kara 
SUSE Labs, CR


[PATCH v2 037/110] minix: use PRIino format for i_ino

2026-03-03 Thread Jeff Layton
Convert minix i_ino format strings to use the PRIino format
macro in preparation for the widening of i_ino via kino_t.

Signed-off-by: Jeff Layton 
---
 fs/minix/inode.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/minix/inode.c b/fs/minix/inode.c
index 
99541c6a5bbf13f3be27474a316b31d8db9fbce0..d92059227d273564c86f100dea3366be4509090b
 100644
--- a/fs/minix/inode.c
+++ b/fs/minix/inode.c
@@ -36,7 +36,7 @@ void __minix_error_inode(struct inode *inode, const char 
*function,
vaf.fmt = fmt;
vaf.va = &args;
printk(KERN_CRIT "minix-fs error (device %s): %s:%d: "
-  "inode #%lu: comm %s: %pV\n",
+  "inode #%" PRIino "u: comm %s: %pV\n",
   inode->i_sb->s_id, function, line, inode->i_ino,
   current->comm, &vaf);
va_end(args);
@@ -520,7 +520,7 @@ void minix_set_inode(struct inode *inode, dev_t rdev)
   S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
init_special_inode(inode, inode->i_mode, rdev);
} else {
-   printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode 
%lu.\n",
+   printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode 
%" PRIino "u.\n",
   inode->i_mode, inode->i_ino);
make_bad_inode(inode);
}
@@ -542,7 +542,7 @@ static struct inode *V1_minix_iget(struct inode *inode)
return ERR_PTR(-EIO);
}
if (raw_inode->i_nlinks == 0) {
-   printk("MINIX-fs: deleted inode referenced: %lu\n",
+   printk("MINIX-fs: deleted inode referenced: %" PRIino "u\n",
   inode->i_ino);
brelse(bh);
iget_failed(inode);
@@ -580,7 +580,7 @@ static struct inode *V2_minix_iget(struct inode *inode)
return ERR_PTR(-EIO);
}
if (raw_inode->i_nlinks == 0) {
-   printk("MINIX-fs: deleted inode referenced: %lu\n",
+   printk("MINIX-fs: deleted inode referenced: %" PRIino "u\n",
   inode->i_ino);
brelse(bh);
iget_failed(inode);
@@ -692,7 +692,7 @@ static int minix_write_inode(struct inode *inode, struct 
writeback_control *wbc)
if (wbc->sync_mode == WB_SYNC_ALL && buffer_dirty(bh)) {
sync_dirty_buffer(bh);
if (buffer_req(bh) && !buffer_uptodate(bh)) {
-   printk("IO error syncing minix inode [%s:%08lx]\n",
+   printk("IO error syncing minix inode [%s:%08" PRIino 
"x]\n",
inode->i_sb->s_id, inode->i_ino);
err = -EIO;
}

-- 
2.53.0