Re: [amd-staging-drm-next] - commit 'Set disp clk in a safe way to avoid over high dpp clk.' makes 'CONFIG_DRM_AMD_DC_DCN1_0=y' mandatory, again

2018-03-13 Thread Alex Deucher
On Wed, Mar 14, 2018 at 2:15 AM, Dieter Nützel  wrote:
> Hello,
>
> commit # 680acc64120cd7fe4fb21d816a0fc0854018fe59
> drm/amd/display: Set disp clk in a safe way to avoid over high dpp clk.
>
> makes CONFIG_DRM_AMD_DC_DCN1_0=y mandatory, again.
> I think it was not intentional?

Fixed in:
https://patchwork.freedesktop.org/patch/210347/

Alex

>
> Without it I get:
>
> Kernel: arch/x86/boot/bzImage is ready  (#1)
> ERROR: "dcn_find_dcfclk_suits_all" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko]
> undefined!
> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Fehler 1
> make: *** [Makefile:1257: modules] Fehler 2
>
> drm/amd> grep -r dcn_find_dcfclk_suits_all *
> Übereinstimmungen in Binärdatei amdgpu/amdgpu.o
> display/dc/calcs/dcn_calcs.c:unsigned int dcn_find_dcfclk_suits_all(
> display/dc/inc/dcn_calcs.h:unsigned int dcn_find_dcfclk_suits_all(
> display/dc/dce/dce_clocks.c:
> dcn_find_dcfclk_suits_all(core_dc, &clk->cur_clocks_value);
> Übereinstimmungen in Binärdatei display/dc/dce/dce_clocks.o
> drm/amd> l display/dc/calcs/dcn_calcs.c display/dc/inc/dcn_calcs.h
> display/dc/dce/dce_clocks.c
> -rw-r--r-- 1 dieter users 66423 13. Mär 23:08 display/dc/calcs/dcn_calcs.c
> -rw-r--r-- 1 dieter users 25680 13. Mär 23:08 display/dc/dce/dce_clocks.c
> -rw-r--r-- 1 dieter users 26059 20. Dez 22:07 display/dc/inc/dcn_calcs.h
>
> Thanks,
> Dieter
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[amd-staging-drm-next] - commit 'Set disp clk in a safe way to avoid over high dpp clk.' makes 'CONFIG_DRM_AMD_DC_DCN1_0=y' mandatory, again

2018-03-13 Thread Dieter Nützel

Hello,

commit # 680acc64120cd7fe4fb21d816a0fc0854018fe59
drm/amd/display: Set disp clk in a safe way to avoid over high dpp clk.

makes CONFIG_DRM_AMD_DC_DCN1_0=y mandatory, again.
I think it was not intentional?

Without it I get:

Kernel: arch/x86/boot/bzImage is ready  (#1)
ERROR: "dcn_find_dcfclk_suits_all" 
[drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

make[1]: *** [scripts/Makefile.modpost:92: __modpost] Fehler 1
make: *** [Makefile:1257: modules] Fehler 2

drm/amd> grep -r dcn_find_dcfclk_suits_all *
Übereinstimmungen in Binärdatei amdgpu/amdgpu.o
display/dc/calcs/dcn_calcs.c:unsigned int dcn_find_dcfclk_suits_all(
display/dc/inc/dcn_calcs.h:unsigned int dcn_find_dcfclk_suits_all(
display/dc/dce/dce_clocks.c:
dcn_find_dcfclk_suits_all(core_dc, &clk->cur_clocks_value);

Übereinstimmungen in Binärdatei display/dc/dce/dce_clocks.o
drm/amd> l display/dc/calcs/dcn_calcs.c display/dc/inc/dcn_calcs.h 
display/dc/dce/dce_clocks.c
-rw-r--r-- 1 dieter users 66423 13. Mär 23:08 
display/dc/calcs/dcn_calcs.c
-rw-r--r-- 1 dieter users 25680 13. Mär 23:08 
display/dc/dce/dce_clocks.c

-rw-r--r-- 1 dieter users 26059 20. Dez 22:07 display/dc/inc/dcn_calcs.h

Thanks,
Dieter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx