RE: [PATCH 01/11] drm/amdgpu:use MACRO like other places

2017-02-08 Thread Deucher, Alexander 
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Wednesday, February 08, 2017 4:27 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 01/11] drm/amdgpu:use MACRO like other places
> 
> Change-Id: Ica8f86577a50d817119de4b4fb95068dc72652a9
> Signed-off-by: Monk Liu 

With Michel's comments addressed, the patch is:
Reviewed-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 6734e55..8f545992 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -4068,10 +4068,10 @@ static int gfx_v8_0_init_save_restore_list(struct
> amdgpu_device *adev)
>   data = mmRLC_SRM_INDEX_CNTL_DATA_0;
>   for (i = 0; i < sizeof(unique_indices) / sizeof(int); i++) {
>   if (unique_indices[i] != 0) {
> - amdgpu_mm_wreg(adev, temp + i,
> - unique_indices[i] & 0x3, false);
> - amdgpu_mm_wreg(adev, data + i,
> - unique_indices[i] >> 20, false);
> + WREG32(temp + i,
> + unique_indices[i] & 0x3);
> + WREG32(data + i,
> + unique_indices[i] >> 20);
>   }
>   }
>   kfree(register_list_format);
> --
> 2.7.4
> 
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 01/11] drm/amdgpu:use MACRO like other places

2017-02-08 Thread Michel Dänzer 
On 08/02/17 06:26 PM, Monk Liu wrote:
> 
> + WREG32(temp + i,
> + unique_indices[i] & 0x3);
> + WREG32(data + i,
> + unique_indices[i] >> 20);

Use a single line in both cases (or fix the indentation of the second
lines to align with the opening parens).


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx