Re: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

2016-10-12 Thread Alex Deucher
On Wed, Oct 12, 2016 at 5:56 AM, Christian König wrote: > Hi Rex, > > So amd_vce_state is our hardware representation and > drm_amdgpu_info_vce_clock_table is the IOCTL interface structure? Is there a > reason for not using drm_amdgpu_info_vce_clock_table directly in the hw > manager, except that

Re: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

2016-10-12 Thread Christian König
r; Zhang, Boyuan *Cc:* Deucher, Alexander *Subject:* Re: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table Hi Rex, the problem with this approach is that you need to copy the entries from one structure to another, like we have below: > + vce_

RE: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

2016-10-12 Thread Zhu, Rex
ober 12, 2016 4:53 PM To: Zhu, Rex; Alex Deucher; amd-gfx list; Fang, Peter; Zhang, Boyuan Cc: Deucher, Alexander Subject: Re: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table Hi Rex, the problem with this approach is that you need to copy the entries from one

Re: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

2016-10-12 Thread Christian König
er. We can notify UMD by add a member in struct drm_amdgpu_info_vce_clock_table. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, October 12, 2016 4:07 AM To: amd-gfx list; Fang, Peter; Zhang, Boyuan; Zhu, Rex Cc: Deucher, Alexande

RE: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

2016-10-12 Thread Zhu, Rex
fy UMD by add a member in struct drm_amdgpu_info_vce_clock_table. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, October 12, 2016 4:07 AM To: amd-gfx list; Fang, Peter; Zhang, Boyuan; Zhu, Rex Cc: Deucher, Alexander Subject: Re: [PATCH 5

Re: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

2016-10-11 Thread Alex Deucher
Rex what is your opinion on exposing the amdgpu drm structure through to powerplay? We could do an intermediate interface, but that just seems like extra hoops to jump through for pretty questionable gain. Alex On Fri, Oct 7, 2016 at 2:28 PM, Alex Deucher wrote: > Used by the powerplay dpm code