Re: [PATCH libdrm] amdgpu: add a faster BO list API

FYI, I've pushed the patch because it helps simplify our the amdgpu winsys code and I already have code that depends on it that I don't wanna rewrite. Marek On Wed, Jan 16, 2019 at 12:39 PM Marek Olšák wrote: > On Wed, Jan 16, 2019 at 9:43 AM Christian König < >

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019 at 9:43 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 16.01.19 um 15:39 schrieb Marek Olšák: > > > > On Wed, Jan 16, 2019, 9:34 AM Koenig, Christian wrote: > >> Am 16.01.19 um 15:31 schrieb Marek Olšák: >> >> >> >> On Wed, Jan 16, 2019, 7:55 AM Christian

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019 at 10:15 AM Bas Nieuwenhuizen wrote: > On Wed, Jan 16, 2019 at 3:38 PM Marek Olšák wrote: > > > > > > > > On Wed, Jan 16, 2019, 7:46 AM Bas Nieuwenhuizen wrote: > >> > >> So random questions: > >> > >> 1) In this discussion it was mentioned that some Vulkan drivers still >

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019 at 3:38 PM Marek Olšák wrote: > > > > On Wed, Jan 16, 2019, 7:46 AM Bas Nieuwenhuizen wrote: >> >> So random questions: >> >> 1) In this discussion it was mentioned that some Vulkan drivers still >> use the bo_list interface. I think that implies radv as I think we're >>

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Am 16.01.19 um 15:39 schrieb Marek Olšák: On Wed, Jan 16, 2019, 9:34 AM Koenig, Christian mailto:christian.koe...@amd.com> wrote: Am 16.01.19 um 15:31 schrieb Marek Olšák: On Wed, Jan 16, 2019, 7:55 AM Christian König mailto:ckoenig.leichtzumer...@gmail.com> wrote:

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019, 9:34 AM Koenig, Christian Am 16.01.19 um 15:31 schrieb Marek Olšák: > > > > On Wed, Jan 16, 2019, 7:55 AM Christian König < > ckoenig.leichtzumer...@gmail.com wrote: > >> Well if you ask me we should have the following interface for >> negotiating memory management with the

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019, 7:46 AM Bas Nieuwenhuizen So random questions: > > 1) In this discussion it was mentioned that some Vulkan drivers still > use the bo_list interface. I think that implies radv as I think we're > still using bo_list. Is there any other API we should be using? (Also, > with

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Am 16.01.19 um 15:31 schrieb Marek Olšák: On Wed, Jan 16, 2019, 7:55 AM Christian König mailto:ckoenig.leichtzumer...@gmail.com> wrote: Well if you ask me we should have the following interface for negotiating memory management with the kernel: 1. We have per process BOs which can't be shared

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 16, 2019, 7:55 AM Christian König < ckoenig.leichtzumer...@gmail.com wrote: > Well if you ask me we should have the following interface for > negotiating memory management with the kernel: > > 1. We have per process BOs which can't be shared between processes. > > Those are always

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Well if you ask me we should have the following interface for negotiating memory management with the kernel: 1. We have per process BOs which can't be shared between processes. Those are always valid and don't need to be mentioned in any BO list whatsoever. If we knew that a per process BO

Re: [PATCH libdrm] amdgpu: add a faster BO list API

So random questions: 1) In this discussion it was mentioned that some Vulkan drivers still use the bo_list interface. I think that implies radv as I think we're still using bo_list. Is there any other API we should be using? (Also, with VK_EXT_descriptor_indexing I suspect we'll be moving more

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Thu, Jan 10, 2019, 6:51 AM Christian König < ckoenig.leichtzumer...@gmail.com wrote: > Am 10.01.19 um 12:41 schrieb Marek Olšák: > > > > On Thu, Jan 10, 2019, 4:15 AM Koenig, Christian wrote: > >> Am 10.01.19 um 00:39 schrieb Marek Olšák: >> >> On Wed, Jan 9, 2019 at 1:41 PM Christian König <

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Am 10.01.19 um 12:41 schrieb Marek Olšák: On Thu, Jan 10, 2019, 4:15 AM Koenig, Christian mailto:christian.koe...@amd.com> wrote: Am 10.01.19 um 00:39 schrieb Marek Olšák: On Wed, Jan 9, 2019 at 1:41 PM Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote:

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Thu, Jan 10, 2019, 4:15 AM Koenig, Christian Am 10.01.19 um 00:39 schrieb Marek Olšák: > > On Wed, Jan 9, 2019 at 1:41 PM Christian König < > ckoenig.leichtzumer...@gmail.com> wrote: > >> Am 09.01.19 um 17:14 schrieb Marek Olšák: >> >> On Wed, Jan 9, 2019 at 8:09 AM Christian König < >>

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Am 10.01.19 um 00:39 schrieb Marek Olšák: On Wed, Jan 9, 2019 at 1:41 PM Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote: Am 09.01.19 um 17:14 schrieb Marek Olšák: On Wed, Jan 9, 2019 at 8:09 AM Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote: Am 09.01.19 um

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 9, 2019 at 1:41 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 09.01.19 um 17:14 schrieb Marek Olšák: > > On Wed, Jan 9, 2019 at 8:09 AM Christian König < > ckoenig.leichtzumer...@gmail.com> wrote: > >> Am 09.01.19 um 13:36 schrieb Marek Olšák: >> >> >> >> On Wed,

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Am 09.01.19 um 17:14 schrieb Marek Olšák: On Wed, Jan 9, 2019 at 8:09 AM Christian König > wrote: Am 09.01.19 um 13:36 schrieb Marek Olšák: On Wed, Jan 9, 2019, 5:28 AM Christian König mailto:ckoenig.leichtzumer...@gmail.com> wrote:

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Am 09.01.19 um 13:36 schrieb Marek Olšák: On Wed, Jan 9, 2019, 5:28 AM Christian König wrote: Looks good, but I'm wondering what's the actual improvement? No malloc calls and 1 less for loop copying the bo list. Yeah, but didn't we want to

Re: [PATCH libdrm] amdgpu: add a faster BO list API

On Wed, Jan 9, 2019, 5:28 AM Christian König < ckoenig.leichtzumer...@gmail.com wrote: > Looks good, but I'm wondering what's the actual improvement? > No malloc calls and 1 less for loop copying the bo list. Marek > Christian. > > Am 07.01.19 um 20:31 schrieb Marek Olšák: > > From: Marek

Re: [PATCH libdrm] amdgpu: add a faster BO list API

Looks good, but I'm wondering what's the actual improvement? Christian. Am 07.01.19 um 20:31 schrieb Marek Olšák: From: Marek Olšák --- amdgpu/amdgpu-symbol-check | 3 ++ amdgpu/amdgpu.h| 56 +- amdgpu/amdgpu_bo.c | 36

RE: [PATCH libdrm] amdgpu: add a faster BO list API

Looks good to me, Reviewed-by: Chunming Zhou > -Original Message- > From: amd-gfx On Behalf Of > Marek Ol?ák > Sent: Tuesday, January 08, 2019 3:31 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH libdrm] amdgpu: add a faster BO list API > > From: Marek Olšák > > --- >