Re: [PATCH] drm/amdgpu: Use READ_ONCE() when reading the values in 'sdma_v4_4_2_ring_get_rptr'

2023-08-22 Thread Christian König
Yes, that's a very good idea as well. Going to keep that link around if anybody asks why we do this. Christian. Am 21.08.23 um 22:49 schrieb Felix Kuehling: Would it make sense to include a link to a better explanation of the underlying issue? E.g. https://lwn.net/Articles/624126/? Regards,

Re: [PATCH] drm/amdgpu: Use READ_ONCE() when reading the values in 'sdma_v4_4_2_ring_get_rptr'

2023-08-21 Thread Felix Kuehling
Would it make sense to include a link to a better explanation of the underlying issue? E.g. https://lwn.net/Articles/624126/? Regards,   Felix On 2023-08-21 07:23, Christian König wrote: Am 04.08.23 um 07:46 schrieb Srinivasan Shanmugam: Instead of declaring pointers use READ_ONCE(), when

Re: [PATCH] drm/amdgpu: Use READ_ONCE() when reading the values in 'sdma_v4_4_2_ring_get_rptr'

2023-08-21 Thread Christian König
Am 04.08.23 um 07:46 schrieb Srinivasan Shanmugam: Instead of declaring pointers use READ_ONCE(), when accessing those values to make sure that the compiler doesn't voilate any cache coherences That commit message is a bit confusing and not 100% technically correct. The compiler is not

RE: [PATCH] drm/amdgpu: Use READ_ONCE() when reading the values in 'sdma_v4_4_2_ring_get_rptr'

2023-08-18 Thread Ma, Le
[AMD Official Use Only - General] Reviewed-by: Le Ma > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Friday, August 4, 2023 1:47 PM > To: Koenig, Christian ; Deucher, Alexander > ; Chen, Guchun ; > Pan, Xinhui > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > ;