Re: [PATCH] drm/amdkfd: fix interrupt spin lock

2018-11-05 Thread Kuehling, Felix
On 2018-11-04 2:20 p.m., Christian König wrote: > Am 02.11.18 um 19:59 schrieb Kuehling, Felix: >> On 2018-11-02 9:48 a.m., Christian König wrote: >>> Vega10 has multiple interrupt rings, >> I don't think I've seen your code that implements multiple interrupt >> rings. So it's a bit hard to

Re: [PATCH] drm/amdkfd: fix interrupt spin lock

2018-11-04 Thread Christian König
Am 02.11.18 um 19:59 schrieb Kuehling, Felix: On 2018-11-02 9:48 a.m., Christian König wrote: Vega10 has multiple interrupt rings, I don't think I've seen your code that implements multiple interrupt rings. So it's a bit hard to comment. It's already a while ago, but you actually reviewed it

Re: [PATCH] drm/amdkfd: fix interrupt spin lock

2018-11-02 Thread Kuehling, Felix
On 2018-11-02 9:48 a.m., Christian König wrote: > Vega10 has multiple interrupt rings, I don't think I've seen your code that implements multiple interrupt rings. So it's a bit hard to comment. As I understand it, the only way this could happen is, if the two interrupt rings are handled by

Re: [PATCH] drm/amdkfd: fix interrupt spin lock

2018-11-02 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Friday, November 2, 2018 9:48:07 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdkfd: fix interrupt spin lock Vega10 has multiple interrupt rings, so this can be called from