Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-15 Thread Nirmoy
I think I know why it happens. At init all entity's rq gets assigned to sched_list[0]. I put some prints to check what we compare in drm_sched_entity_get_free_sched. It turns out most of the time it compares zero values(num_jobs(0) < min_jobs(0)) so most of the time 1st rq(sdma0, comp_1.0.0

Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-15 Thread Christian König
Hi Nirmoy, Am 15.01.20 um 12:04 schrieb Nirmoy: Hi Christian, On 1/14/20 5:01 PM, Christian König wrote: Before this patch: sched_name num of many times it got scheduled =  == sdma0  314 sdma1  32 comp_1.0.0 56 comp_1.1.0  

Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-15 Thread Nirmoy
Hi Christian, On 1/14/20 5:01 PM, Christian König wrote: Before this patch: sched_name num of many times it got scheduled =  == sdma0  314 sdma1  32 comp_1.0.0 56 comp_1.1.0 0 comp_1.1.1 0 comp_1.2.0 0 comp_1.2.1 

Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-14 Thread Christian König
Am 14.01.20 um 17:13 schrieb Nirmoy: On 1/14/20 5:01 PM, Christian König wrote: Am 14.01.20 um 16:43 schrieb Nirmoy Das: Jobs submitted in an entity should execute in the order those jobs are submitted. We make sure that by checking entity->job_queue in drm_sched_entity_select_rq() so that we

Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-14 Thread Nirmoy
On 1/14/20 5:23 PM, Christian König wrote: Am 14.01.20 um 17:20 schrieb Nirmoy: On 1/14/20 5:01 PM, Christian König wrote: Am 14.01.20 um 16:43 schrieb Nirmoy Das: Jobs submitted in an entity should execute in the order those jobs are submitted. We make sure that by checking entity->job_queu

Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-14 Thread Christian König
Am 14.01.20 um 17:20 schrieb Nirmoy: On 1/14/20 5:01 PM, Christian König wrote: Am 14.01.20 um 16:43 schrieb Nirmoy Das: Jobs submitted in an entity should execute in the order those jobs are submitted. We make sure that by checking entity->job_queue in drm_sched_entity_select_rq() so that we

Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-14 Thread Nirmoy
On 1/14/20 5:01 PM, Christian König wrote: Am 14.01.20 um 16:43 schrieb Nirmoy Das: Jobs submitted in an entity should execute in the order those jobs are submitted. We make sure that by checking entity->job_queue in drm_sched_entity_select_rq() so that we don't loadbalance jobs within an entit

Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-14 Thread Nirmoy
On 1/14/20 5:01 PM, Christian König wrote: Am 14.01.20 um 16:43 schrieb Nirmoy Das: Jobs submitted in an entity should execute in the order those jobs are submitted. We make sure that by checking entity->job_queue in drm_sched_entity_select_rq() so that we don't loadbalance jobs within an entit

Re: [PATCH] drm/scheduler: fix race condition in load balancer

2020-01-14 Thread Christian König
Am 14.01.20 um 16:43 schrieb Nirmoy Das: Jobs submitted in an entity should execute in the order those jobs are submitted. We make sure that by checking entity->job_queue in drm_sched_entity_select_rq() so that we don't loadbalance jobs within an entity. But because we update entity->job_queue l