Re: [PATCH 03/19] drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t)

2017-08-12 Thread Oded Gabbay
gt; > From: Oded Gabbay > Sent: Saturday, August 12, 2017 8:37 AM > To: Kuehling, Felix > Cc: amd-gfx list > Subject: Re: [PATCH 03/19] drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t) > > On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling > wrote: >> kfd2kgd-&

Re: [PATCH 03/19] drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t)

2017-08-12 Thread Kuehling, Felix
12, 2017 8:37 AM To: Kuehling, Felix Cc: amd-gfx list Subject: Re: [PATCH 03/19] drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t)   On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > kfd2kgd->address_watch_get_offset returns dword register offsets. > The divide-by-sizeof(uin

Re: [PATCH 03/19] drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t)

2017-08-12 Thread Oded Gabbay
On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > kfd2kgd->address_watch_get_offset returns dword register offsets. > The divide-by-sizeof(uint32_t) is incorrect. In amdgpu that's true, but in radeon that's incorrect. If you look at cik_reg.h in radeon driver, you will see the address of