Re: [PATCH 04/11] drm/amdgpu: fix and cleanup gmc_v7_0_flush_gpu_tlb_pasid

2023-09-08 Thread Felix Kuehling
I think you mean "VMIDs to invalidate", not "VMIDs to reset". With that fixed, the patch is Acked-by: Felix Kuehling On 2023-09-05 02:04, Christian König wrote: Testing for reset is pointless since the reset can start right after the test. Grab the reset semaphore instead. The same PASID

Re: [PATCH 04/11] drm/amdgpu: fix and cleanup gmc_v7_0_flush_gpu_tlb_pasid

2023-09-07 Thread Shashank Sharma
On 07/09/2023 08:57, Christian König wrote: Am 06.09.23 um 16:35 schrieb Shashank Sharma: On 06/09/2023 16:25, Shashank Sharma wrote: On 05/09/2023 08:04, Christian König wrote: Testing for reset is pointless since the reset can start right after the test. Grab the reset semaphore

Re: [PATCH 04/11] drm/amdgpu: fix and cleanup gmc_v7_0_flush_gpu_tlb_pasid

2023-09-07 Thread Christian König
Am 06.09.23 um 16:35 schrieb Shashank Sharma: On 06/09/2023 16:25, Shashank Sharma wrote: On 05/09/2023 08:04, Christian König wrote: Testing for reset is pointless since the reset can start right after the test. Grab the reset semaphore instead. The same PASID can be used by more than

Re: [PATCH 04/11] drm/amdgpu: fix and cleanup gmc_v7_0_flush_gpu_tlb_pasid

2023-09-06 Thread Shashank Sharma
On 06/09/2023 16:25, Shashank Sharma wrote: On 05/09/2023 08:04, Christian König wrote: Testing for reset is pointless since the reset can start right after the test. Grab the reset semaphore instead. The same PASID can be used by more than once VMID, build a mask of VMIDs to reset instead

Re: [PATCH 04/11] drm/amdgpu: fix and cleanup gmc_v7_0_flush_gpu_tlb_pasid

2023-09-06 Thread Shashank Sharma
On 05/09/2023 08:04, Christian König wrote: Testing for reset is pointless since the reset can start right after the test. Grab the reset semaphore instead. The same PASID can be used by more than once VMID, build a mask of VMIDs to reset instead of just restting the first one.

Re: [PATCH 04/11] drm/amdgpu: fix and cleanup gmc_v7_0_flush_gpu_tlb_pasid

2023-09-05 Thread Alex Deucher
On Tue, Sep 5, 2023 at 7:30 AM Christian König wrote: > > Testing for reset is pointless since the reset can start right after the > test. Grab the reset semaphore instead. > > The same PASID can be used by more than once VMID, build a mask of VMIDs > to reset instead of just restting the first