Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-02-12 Thread Felix Kuehling
On 2018-02-11 07:42 AM, Oded Gabbay wrote: > Hi Felix, > Do you object to me changing amd_kfd_ to amdkfd_ in the various > structures and functions ? > So far, we don't have anything with prefix of amd_kfd_ so I would like > to keep on consistency. We use the prefix amdgpu_amdkfd_ throughout the K

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-02-11 Thread Oded Gabbay
On Wed, Feb 7, 2018 at 3:32 AM, Felix Kuehling wrote: > This fence is used by KFD to keep memory resident while user mode > queues are enabled. Trying to evict memory will trigger the > enable_signaling callback, which starts a KFD eviction, which > involves preempting user mode queues before sign

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-31 Thread Christian König
Am 31.01.2018 um 00:21 schrieb Felix Kuehling: On 2018-01-30 10:35 AM, Christian König wrote: Am 30.01.2018 um 16:28 schrieb Kasiviswanathan, Harish: [+Harish, forgot to acknowledge him in the commit description, will fix that in v2] Harish, please see Christian's question below in amd_kfd_fen

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-30 Thread Felix Kuehling
On 2018-01-30 10:35 AM, Christian König wrote: > Am 30.01.2018 um 16:28 schrieb Kasiviswanathan, Harish: [+Harish, forgot to acknowledge him in the commit description, will fix that in v2] Harish, please see Christian's question below in amd_kfd_fence_signal. Did I und

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-30 Thread Christian König
Am 30.01.2018 um 16:28 schrieb Kasiviswanathan, Harish: [+Harish, forgot to acknowledge him in the commit description, will fix that in v2] Harish, please see Christian's question below in amd_kfd_fence_signal. Did I understand this correctly? [HK]: Yes the lifetime of eviction fences is tied t

RE: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-30 Thread Kasiviswanathan, Harish
>> [+Harish, forgot to acknowledge him in the commit description, will fix >> that in v2] >> >> Harish, please see Christian's question below in amd_kfd_fence_signal. >> Did I understand this correctly? [HK]: Yes the lifetime of eviction fences is tied to the lifetime of the process associated wi

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-29 Thread Felix Kuehling
On 2018-01-29 08:43 AM, Christian König wrote: > Hi Felix & Harish, > > maybe explain why I found that odd: dma_fence_add_callback() sets the > DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT flag before adding the callback. > > So the flag should always be set when there are callbacks. > Did I miss anything? I

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-29 Thread Christian König
Hi Felix & Harish, maybe explain why I found that odd: dma_fence_add_callback() sets the DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT flag before adding the callback. So the flag should always be set when there are callbacks. Did I miss anything? Regards, Christian. Am 29.01.2018 um 00:55 schrieb Felix

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-28 Thread Felix Kuehling
[+Harish, forgot to acknowledge him in the commit description, will fix that in v2] Harish, please see Christian's question below in amd_kfd_fence_signal. Did I understand this correctly? Regards,   Felix On 2018-01-28 06:42 PM, Felix Kuehling wrote: > On 2018-01-27 04:16 AM, Christian König wro

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-28 Thread Felix Kuehling
On 2018-01-27 04:16 AM, Christian König wrote: > Am 27.01.2018 um 02:09 schrieb Felix Kuehling: [snip] >> +struct amdgpu_amdkfd_fence *amdgpu_amdkfd_fence_create(u64 context, >> +   void *mm) >> +{ >> +    struct amdgpu_amdkfd_fence *fence = NULL; >> + >> +    fence = k

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-27 Thread Christian König
Am 27.01.2018 um 02:09 schrieb Felix Kuehling: This fence is used by KFD to keep memory resident while user mode queues are enabled. Trying to evict memory will trigger the enable_signaling callback, which starts a KFD eviction, which involves preempting user mode queues before signaling the fenc