RE: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid

2020-01-13 Thread Sierra Guiza, Alejandro (Alex)
, Alejandro (Alex) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid I noticed that the invalidate_tlbs_size in patch 3 was also wrong. That should only be 2 dwords, not 12. The code here should do     amdgpu_ring_alloc(ring, kiq->

Re: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid

2020-01-13 Thread Felix Kuehling
d size? Currently is 12, should I need to drop it to 8 then? -Original Message- From: Kuehling, Felix Sent: Monday, January 13, 2020 6:34 PM To: Sierra Guiza, Alejandro (Alex) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid So

RE: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid

2020-01-13 Thread Sierra Guiza, Alejandro (Alex)
: Monday, January 13, 2020 6:34 PM To: Sierra Guiza, Alejandro (Alex) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid Sorry, I already said, Reviewed-by, but realized there was one more problem. If you haven't submitted yet, please fix

Re: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid

2020-01-13 Thread Felix Kuehling
Sorry, I already said, Reviewed-by, but realized there was one more problem. If you haven't submitted yet, please fix that first. Otherwise, please make it a follow-up patch. See inline ... On 2020-01-13 3:26 p.m., Alex Sierra wrote: This can be used directly from amdgpu and amdkfd to

Re: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid

2020-01-13 Thread Felix Kuehling
On 2020-01-11 1:39 p.m., Alex Sierra wrote: This can be used directly from amdgpu and amdkfd to invalidate TLB through pasid. It supports gmc v7, v8, v9 and v10. Change-Id: I6563a8eba2e42d1a67fa2547156c20da41d1e490 Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 6

Re: [PATCH 5/7] drm/amdgpu: export function to flush TLB via pasid

2020-01-13 Thread Christian König
Am 11.01.20 um 19:39 schrieb Alex Sierra: This can be used directly from amdgpu and amdkfd to invalidate TLB through pasid. It supports gmc v7, v8, v9 and v10. Change-Id: I6563a8eba2e42d1a67fa2547156c20da41d1e490 Signed-off-by: Alex Sierra Flushing by pasid is in principle racy, but I don't