Re: [PATCH 6/6] drm/amdkfd: Fix sdma queue allocate race condition

2019-06-06 Thread Kuehling, Felix
Patches 5 and 6 are Reviewed-by: Felix Kuehling On 2019-06-06 2:25 p.m., Zeng, Oak wrote: > SDMA queue allocation requires the dqm lock at it modify > the global dqm members. Move up the dqm_lock so sdma > queue allocation is enclosed in the critical section. Move > mqd allocation out of

Re: [PATCH 6/6] drm/amdkfd: Fix sdma queue allocate race condition

2019-06-05 Thread Kuehling, Felix
I think the simpler way to fix this, is to restructure create_queue_cpsch similar to the nocpsch version where we allocate the MQD early and take the DQM lock right after that. That way you don't need locked and unlocked variants of allocate_sdma_queue and deallocate_sdma_queue. Regards,