Re: [PATCH libdrm] amdgpu: add the function to get the marketing name (v3)

2016-11-08 Thread Michel Dänzer
On 08/11/16 01:02 AM, Emil Velikov wrote: > On 7 November 2016 at 11:43, Emil Velikov wrote: >> On 7 November 2016 at 09:09, Michel Dänzer wrote: >> >>> +static struct amdgpu_asic_id_table_t { >>> + uint32_t did; >>> + uint32_t rid; >>> +

RE: [PATCH libdrm] amdgpu: add the function to get the marketing name (v3)

2016-11-07 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Monday, November 07, 2016 4:09 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Jerry > Subject: [PATCH libdrm] amdgpu: add the function to get the marketing > name

Re: [PATCH libdrm] amdgpu: add the function to get the marketing name (v3)

2016-11-07 Thread Emil Velikov
On 7 November 2016 at 11:43, Emil Velikov wrote: > On 7 November 2016 at 09:09, Michel Dänzer wrote: > >> +static struct amdgpu_asic_id_table_t { >> + uint32_t did; >> + uint32_t rid; >> + char marketing_name[64]; > Using a char *

Re: [PATCH libdrm] amdgpu: add the function to get the marketing name (v3)

2016-11-07 Thread Emil Velikov
On 7 November 2016 at 09:09, Michel Dänzer wrote: > +static struct amdgpu_asic_id_table_t { > + uint32_t did; > + uint32_t rid; > + char marketing_name[64]; Using a char * here might be a better. From a quick look [64] is quite wasteful. -Emil

Re: [PATCH libdrm] amdgpu: add the function to get the marketing name (v3)

2016-11-07 Thread Christian König
Am 07.11.2016 um 10:09 schrieb Michel Dänzer: From: Junwei Zhang This function is used to look up the marking name for a specific board. v2: agd: Squash in subsequent updates to the table. v3: [Michel Dänzer] * Make amdgpu_asic_id_table static, so it's not exported from