Re: [PATCH v2 2/4] drm/amdkfd: Use cursor start instead of ttm resource start

[Christian König]

Am 25.01.23 um 11:48 schrieb Somalapuram Amaranath:
cleanup PAGE_SHIFT operation and replacing
ttm_resource resource->start with cursor start
using amdgpu_res_first API
v1 -> v2: reorder patch sequence

Signed-off-by: Somalapuram Amaranath <amaranath.somalapu...@amd.com>
---
  drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index c06ada0844ba..f87ce4f1cb93 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -200,8 +200,11 @@ static int add_queue_mes(struct device_queue_manager *dqm, 
struct queue *q,
        queue_input.wptr_addr = (uint64_t)q->properties.write_ptr;
  
  	if (q->wptr_bo) {
+               struct amdgpu_res_cursor cursor;
                wptr_addr_off = (uint64_t)q->properties.write_ptr & (PAGE_SIZE 
- 1);

Add an empty line between declaration and code or otherwise the 
automated checkers will complain.

Apart from this nit pick the patch is Reviewed-by: Christian König 
<christian.koe...@amd.com>

Regards,
Christian.

-               queue_input.wptr_mc_addr = ((uint64_t)q->wptr_bo->tbo.resource->start 
<< PAGE_SHIFT) + wptr_addr_off;
+               amdgpu_res_first(q->wptr_bo->tbo.resource, 0,
+                                q->wptr_bo->tbo.resource->size, &cursor);
+               queue_input.wptr_mc_addr = cursor.start + wptr_addr_off;
        }
  
  	queue_input.is_kfd_process = 1;