Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-10-02 Thread Ilpo Järvinen
On Tue, 22 Sep 2026, Armin Wolf wrote:

> Am 18.09.26 um 15:03 schrieb Alex Deucher:
> 
> > On Fri, Sep 18, 2026 at 7:01 AM Jani Nikula 
> > wrote:
> > > On Fri, 18 Sep 2026, Hans de Goede  wrote:
> > > > Hi,
> > > > 
> > > > On 16-Sep-26 09:16, Jani Nikula wrote:
> > > > > On Wed, 16 Sep 2026, Armin Wolf  wrote:
> > > > > > Am 15.09.26 um 14:31 schrieb Jani Nikula:
> > > > > > 
> > > > > > > On Tue, 15 Sep 2026, Ilpo Järvinen 
> > > > > > > wrote:
> > > > > > > > GPU people heads up!!
> > > > > > > > 
> > > > > > > > On Wed, 2 Sep 2026, Armin Wolf wrote:
> > > > > > > > 
> > > > > > > > > Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
> > > > > > > > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > > > > > > > > > b/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > > > > > > > > > index 12e4a41bf1f0..50305630f533 100644
> > > > > > > > > > > --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > > > > > > > > > +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > > > > > > > > > @@ -30,9 +30,7 @@ config DRM_AMDGPU
> > > > > > > > > > >  # ACPI_VIDEO's dependencies must also be
> > > > > > > > > > > selected.
> > > > > > > > > > >  select INPUT if ACPI
> > > > > > > > > > >  select ACPI_VIDEO if ACPI
> > > > > > > > > > > - # On x86 ACPI_VIDEO also needs ACPI_WMI
> > > > > > > > > > > - select X86_PLATFORM_DEVICES if ACPI && X86
> > > > > > > > > > The change below makes sense, but this one looks like it
> > > > > > > > > > should remain
> > > > > > > > > > unless X86_PLATFORM_DEVICES is handled some other way?
> > > > > > > > > > 
> > > > > > > > > > Alex
> > > > > > > > > AFAIK the dependency on X86_PLATFORM_DEVICES was only
> > > > > > > > > necessary because
> > > > > > > > > ACPI-WMI depended on it in the past.
> > > > > > > > > By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86
> > > > > > > > > anymore.
> > > > > > > > Hi all,
> > > > > > > > 
> > > > > > > > Could more GPU people besides Alex take a look on this. I'd want
> > > > > > > > to make
> > > > > > > > progress with this series within this cycle but would prefer to
> > > > > > > > have Acks
> > > > > > > > from GPU side.
> > > > > > > I share the same concern with Alex. It seems to me we could now
> > > > > > > end up
> > > > > > > with x86 configurations without X86_PLATFORM_DEVICES, which handle
> > > > > > > e.g. backlight on a lot of platforms.
> > > > > > > 
> > > > > > > I think the safer option might be to go for:
> > > > > > > 
> > > > > > > depends on X86_PLATFORM_DEVICES || !X86
> > > > > > > 
> > > > > > > in all of the cases that select/depend on X86_PLATFORM_DEVICES in
> > > > > > > drm.
> > > > > > > 
> > > > > > > The alternative is to find out, and handle the fallout, if any.
> > > > > > > 
> > > > > > > 
> > > > > > > BR,
> > > > > > > Jani.
> > > > > > Alright, should i leave the original "select X86_PLATFORM_DEVICES if
> > > > > > ..." statements
> > > > > > as-is or should is change them to "depends on X86_PLATFORM_DEVICES
> > > > > > || !X86" everywhere?
> > > > > There are some places that depends on X86_PLATFORM_DEVICES. I think
> > > > > it's
> > > > > almost always a mistake to have some places select and some places
> > > > > depends on, and select should anyway be used with care. I'd go for
> > > > > depends on.
> > > > I'm a bit late to the party here, sorry.
> > > > 
> > > > Note that X86_PLATFORM_DEVICES is an option which enables / disables
> > > > a menu and does nothing more.
> > > > 
> > > > Enabling it or depending on it by itself does nothing.
> > > > 
> > > > The select used to be there since it must be selected to be able
> > > > to select ACPI_WMI (which is no longer the case after this series).
> > > > 
> > > > To depends on in XE was probably copy pasted from the existing
> > > > select-s and then changed to a depends and already was a completely
> > > > no-op since depending on ACPI_WMI was enough as that itself
> > > > dependend on ACPI_WMI.
> > > > 
> > > > As for X86_PLATFORM_DEVICES being needed for some backlight
> > > > interfaces, depending on it by itself does not result in those
> > > > interfaces being there. That requires enabling the actual drivers
> > > > providing those interfaces.
> > > > 
> > > > And I don't think that the GPU drivers should start depending
> > > > on those since that will become very unyielding.
> > > > 
> > > > TL;DR: I believe Armin's original patch is fine and this is
> > > > a welcome cleanup / simplification of the DRM drivers Kconfig
> > > > bits.
> > > Your explanation makes sense, thanks.
> > Yeah, sounds good.  Thanks!
> > 
> > Alex
> 
> Nice, i suppose we can apply this series as-is then?

Hi all,

I don't see anyone opposing this anymore and the discussion has died down 
so I took this into the review-ilpo-next branch.

If somebody still feels there's something wrong with this, please let me 
know soonish.

-- 
 i.

Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-23 Thread Armin Wolf

Am 18.09.26 um 15:03 schrieb Alex Deucher:


On Fri, Sep 18, 2026 at 7:01 AM Jani Nikula  wrote:

On Fri, 18 Sep 2026, Hans de Goede  wrote:

Hi,

On 16-Sep-26 09:16, Jani Nikula wrote:

On Wed, 16 Sep 2026, Armin Wolf  wrote:

Am 15.09.26 um 14:31 schrieb Jani Nikula:


On Tue, 15 Sep 2026, Ilpo Järvinen  wrote:

GPU people heads up!!

On Wed, 2 Sep 2026, Armin Wolf wrote:


Am 01.09.26 um 23:30 schrieb Deucher, Alexander:

diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
b/drivers/gpu/drm/amd/amdgpu/Kconfig
index 12e4a41bf1f0..50305630f533 100644
--- a/drivers/gpu/drm/amd/amdgpu/Kconfig
+++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
@@ -30,9 +30,7 @@ config DRM_AMDGPU
 # ACPI_VIDEO's dependencies must also be selected.
 select INPUT if ACPI
 select ACPI_VIDEO if ACPI
- # On x86 ACPI_VIDEO also needs ACPI_WMI
- select X86_PLATFORM_DEVICES if ACPI && X86

The change below makes sense, but this one looks like it should remain
unless X86_PLATFORM_DEVICES is handled some other way?

Alex

AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
ACPI-WMI depended on it in the past.
By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.

Hi all,

Could more GPU people besides Alex take a look on this. I'd want to make
progress with this series within this cycle but would prefer to have Acks
from GPU side.

I share the same concern with Alex. It seems to me we could now end up
with x86 configurations without X86_PLATFORM_DEVICES, which handle
e.g. backlight on a lot of platforms.

I think the safer option might be to go for:

depends on X86_PLATFORM_DEVICES || !X86

in all of the cases that select/depend on X86_PLATFORM_DEVICES in drm.

The alternative is to find out, and handle the fallout, if any.


BR,
Jani.

Alright, should i leave the original "select X86_PLATFORM_DEVICES if ..." 
statements
as-is or should is change them to "depends on X86_PLATFORM_DEVICES || !X86" 
everywhere?

There are some places that depends on X86_PLATFORM_DEVICES. I think it's
almost always a mistake to have some places select and some places
depends on, and select should anyway be used with care. I'd go for
depends on.

I'm a bit late to the party here, sorry.

Note that X86_PLATFORM_DEVICES is an option which enables / disables
a menu and does nothing more.

Enabling it or depending on it by itself does nothing.

The select used to be there since it must be selected to be able
to select ACPI_WMI (which is no longer the case after this series).

To depends on in XE was probably copy pasted from the existing
select-s and then changed to a depends and already was a completely
no-op since depending on ACPI_WMI was enough as that itself
dependend on ACPI_WMI.

As for X86_PLATFORM_DEVICES being needed for some backlight
interfaces, depending on it by itself does not result in those
interfaces being there. That requires enabling the actual drivers
providing those interfaces.

And I don't think that the GPU drivers should start depending
on those since that will become very unyielding.

TL;DR: I believe Armin's original patch is fine and this is
a welcome cleanup / simplification of the DRM drivers Kconfig
bits.

Your explanation makes sense, thanks.

Yeah, sounds good.  Thanks!

Alex


Nice, i suppose we can apply this series as-is then?

Thanks,
Armin Wolf


BR,
Jani.


--
Jani Nikula, Intel


Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-22 Thread Patrik Jakobsson
On Tue, Sep 22, 2026 at 9:57 PM Armin Wolf  wrote:
>
> Am 18.09.26 um 15:03 schrieb Alex Deucher:
>
> > On Fri, Sep 18, 2026 at 7:01 AM Jani Nikula  
> > wrote:
> >> On Fri, 18 Sep 2026, Hans de Goede  wrote:
> >>> Hi,
> >>>
> >>> On 16-Sep-26 09:16, Jani Nikula wrote:
>  On Wed, 16 Sep 2026, Armin Wolf  wrote:
> > Am 15.09.26 um 14:31 schrieb Jani Nikula:
> >
> >> On Tue, 15 Sep 2026, Ilpo Järvinen  
> >> wrote:
> >>> GPU people heads up!!
> >>>
> >>> On Wed, 2 Sep 2026, Armin Wolf wrote:
> >>>
>  Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
> >> b/drivers/gpu/drm/amd/amdgpu/Kconfig
> >> index 12e4a41bf1f0..50305630f533 100644
> >> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> >> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> >> @@ -30,9 +30,7 @@ config DRM_AMDGPU
> >>  # ACPI_VIDEO's dependencies must also be selected.
> >>  select INPUT if ACPI
> >>  select ACPI_VIDEO if ACPI
> >> - # On x86 ACPI_VIDEO also needs ACPI_WMI
> >> - select X86_PLATFORM_DEVICES if ACPI && X86
> > The change below makes sense, but this one looks like it should 
> > remain
> > unless X86_PLATFORM_DEVICES is handled some other way?
> >
> > Alex
>  AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary 
>  because
>  ACPI-WMI depended on it in the past.
>  By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 
>  anymore.
> >>> Hi all,
> >>>
> >>> Could more GPU people besides Alex take a look on this. I'd want to 
> >>> make
> >>> progress with this series within this cycle but would prefer to have 
> >>> Acks
> >>> from GPU side.
> >> I share the same concern with Alex. It seems to me we could now end up
> >> with x86 configurations without X86_PLATFORM_DEVICES, which handle
> >> e.g. backlight on a lot of platforms.
> >>
> >> I think the safer option might be to go for:
> >>
> >> depends on X86_PLATFORM_DEVICES || !X86
> >>
> >> in all of the cases that select/depend on X86_PLATFORM_DEVICES in drm.
> >>
> >> The alternative is to find out, and handle the fallout, if any.
> >>
> >>
> >> BR,
> >> Jani.
> > Alright, should i leave the original "select X86_PLATFORM_DEVICES if 
> > ..." statements
> > as-is or should is change them to "depends on X86_PLATFORM_DEVICES || 
> > !X86" everywhere?
>  There are some places that depends on X86_PLATFORM_DEVICES. I think it's
>  almost always a mistake to have some places select and some places
>  depends on, and select should anyway be used with care. I'd go for
>  depends on.
> >>> I'm a bit late to the party here, sorry.
> >>>
> >>> Note that X86_PLATFORM_DEVICES is an option which enables / disables
> >>> a menu and does nothing more.
> >>>
> >>> Enabling it or depending on it by itself does nothing.
> >>>
> >>> The select used to be there since it must be selected to be able
> >>> to select ACPI_WMI (which is no longer the case after this series).
> >>>
> >>> To depends on in XE was probably copy pasted from the existing
> >>> select-s and then changed to a depends and already was a completely
> >>> no-op since depending on ACPI_WMI was enough as that itself
> >>> dependend on ACPI_WMI.
> >>>
> >>> As for X86_PLATFORM_DEVICES being needed for some backlight
> >>> interfaces, depending on it by itself does not result in those
> >>> interfaces being there. That requires enabling the actual drivers
> >>> providing those interfaces.
> >>>
> >>> And I don't think that the GPU drivers should start depending
> >>> on those since that will become very unyielding.
> >>>
> >>> TL;DR: I believe Armin's original patch is fine and this is
> >>> a welcome cleanup / simplification of the DRM drivers Kconfig
> >>> bits.
> >> Your explanation makes sense, thanks.
> > Yeah, sounds good.  Thanks!
> >
> > Alex
>
> Nice, i suppose we can apply this series as-is then?

Sorry I'm a bit late here, but for the gma500 part:
Acked-by: Patrik Jakobsson 

>
> Thanks,
> Armin Wolf
>
> >> BR,
> >> Jani.
> >>
> >>
> >> --
> >> Jani Nikula, Intel


Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-18 Thread Alex Deucher
On Fri, Sep 18, 2026 at 7:01 AM Jani Nikula  wrote:
>
> On Fri, 18 Sep 2026, Hans de Goede  wrote:
> > Hi,
> >
> > On 16-Sep-26 09:16, Jani Nikula wrote:
> >> On Wed, 16 Sep 2026, Armin Wolf  wrote:
> >>> Am 15.09.26 um 14:31 schrieb Jani Nikula:
> >>>
>  On Tue, 15 Sep 2026, Ilpo Järvinen  wrote:
> > GPU people heads up!!
> >
> > On Wed, 2 Sep 2026, Armin Wolf wrote:
> >
> >> Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
>  diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
>  b/drivers/gpu/drm/amd/amdgpu/Kconfig
>  index 12e4a41bf1f0..50305630f533 100644
>  --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
>  +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
>  @@ -30,9 +30,7 @@ config DRM_AMDGPU
>  # ACPI_VIDEO's dependencies must also be selected.
>  select INPUT if ACPI
>  select ACPI_VIDEO if ACPI
>  - # On x86 ACPI_VIDEO also needs ACPI_WMI
>  - select X86_PLATFORM_DEVICES if ACPI && X86
> >>> The change below makes sense, but this one looks like it should remain
> >>> unless X86_PLATFORM_DEVICES is handled some other way?
> >>>
> >>> Alex
> >> AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
> >> ACPI-WMI depended on it in the past.
> >> By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.
> > Hi all,
> >
> > Could more GPU people besides Alex take a look on this. I'd want to make
> > progress with this series within this cycle but would prefer to have 
> > Acks
> > from GPU side.
>  I share the same concern with Alex. It seems to me we could now end up
>  with x86 configurations without X86_PLATFORM_DEVICES, which handle
>  e.g. backlight on a lot of platforms.
> 
>  I think the safer option might be to go for:
> 
> depends on X86_PLATFORM_DEVICES || !X86
> 
>  in all of the cases that select/depend on X86_PLATFORM_DEVICES in drm.
> 
>  The alternative is to find out, and handle the fallout, if any.
> 
> 
>  BR,
>  Jani.
> >>>
> >>> Alright, should i leave the original "select X86_PLATFORM_DEVICES if ..." 
> >>> statements
> >>> as-is or should is change them to "depends on X86_PLATFORM_DEVICES || 
> >>> !X86" everywhere?
> >>
> >> There are some places that depends on X86_PLATFORM_DEVICES. I think it's
> >> almost always a mistake to have some places select and some places
> >> depends on, and select should anyway be used with care. I'd go for
> >> depends on.
> >
> > I'm a bit late to the party here, sorry.
> >
> > Note that X86_PLATFORM_DEVICES is an option which enables / disables
> > a menu and does nothing more.
> >
> > Enabling it or depending on it by itself does nothing.
> >
> > The select used to be there since it must be selected to be able
> > to select ACPI_WMI (which is no longer the case after this series).
> >
> > To depends on in XE was probably copy pasted from the existing
> > select-s and then changed to a depends and already was a completely
> > no-op since depending on ACPI_WMI was enough as that itself
> > dependend on ACPI_WMI.
> >
> > As for X86_PLATFORM_DEVICES being needed for some backlight
> > interfaces, depending on it by itself does not result in those
> > interfaces being there. That requires enabling the actual drivers
> > providing those interfaces.
> >
> > And I don't think that the GPU drivers should start depending
> > on those since that will become very unyielding.
> >
> > TL;DR: I believe Armin's original patch is fine and this is
> > a welcome cleanup / simplification of the DRM drivers Kconfig
> > bits.
>
> Your explanation makes sense, thanks.

Yeah, sounds good.  Thanks!

Alex

>
> BR,
> Jani.
>
>
> --
> Jani Nikula, Intel


Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-18 Thread Jani Nikula
On Fri, 18 Sep 2026, Hans de Goede  wrote:
> Hi,
>
> On 16-Sep-26 09:16, Jani Nikula wrote:
>> On Wed, 16 Sep 2026, Armin Wolf  wrote:
>>> Am 15.09.26 um 14:31 schrieb Jani Nikula:
>>>
 On Tue, 15 Sep 2026, Ilpo Järvinen  wrote:
> GPU people heads up!!
>
> On Wed, 2 Sep 2026, Armin Wolf wrote:
>
>> Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
 diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
 b/drivers/gpu/drm/amd/amdgpu/Kconfig
 index 12e4a41bf1f0..50305630f533 100644
 --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
 +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
 @@ -30,9 +30,7 @@ config DRM_AMDGPU
 # ACPI_VIDEO's dependencies must also be selected.
 select INPUT if ACPI
 select ACPI_VIDEO if ACPI
 - # On x86 ACPI_VIDEO also needs ACPI_WMI
 - select X86_PLATFORM_DEVICES if ACPI && X86
>>> The change below makes sense, but this one looks like it should remain
>>> unless X86_PLATFORM_DEVICES is handled some other way?
>>>
>>> Alex
>> AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
>> ACPI-WMI depended on it in the past.
>> By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.
> Hi all,
>
> Could more GPU people besides Alex take a look on this. I'd want to make
> progress with this series within this cycle but would prefer to have Acks
> from GPU side.
 I share the same concern with Alex. It seems to me we could now end up
 with x86 configurations without X86_PLATFORM_DEVICES, which handle
 e.g. backlight on a lot of platforms.

 I think the safer option might be to go for:

depends on X86_PLATFORM_DEVICES || !X86

 in all of the cases that select/depend on X86_PLATFORM_DEVICES in drm.

 The alternative is to find out, and handle the fallout, if any.


 BR,
 Jani.
>>>
>>> Alright, should i leave the original "select X86_PLATFORM_DEVICES if ..." 
>>> statements
>>> as-is or should is change them to "depends on X86_PLATFORM_DEVICES || !X86" 
>>> everywhere?
>> 
>> There are some places that depends on X86_PLATFORM_DEVICES. I think it's
>> almost always a mistake to have some places select and some places
>> depends on, and select should anyway be used with care. I'd go for
>> depends on.
>
> I'm a bit late to the party here, sorry.
>
> Note that X86_PLATFORM_DEVICES is an option which enables / disables
> a menu and does nothing more.
>
> Enabling it or depending on it by itself does nothing.
>
> The select used to be there since it must be selected to be able
> to select ACPI_WMI (which is no longer the case after this series).
>
> To depends on in XE was probably copy pasted from the existing
> select-s and then changed to a depends and already was a completely
> no-op since depending on ACPI_WMI was enough as that itself
> dependend on ACPI_WMI.
>
> As for X86_PLATFORM_DEVICES being needed for some backlight
> interfaces, depending on it by itself does not result in those
> interfaces being there. That requires enabling the actual drivers
> providing those interfaces.
>
> And I don't think that the GPU drivers should start depending
> on those since that will become very unyielding.
>
> TL;DR: I believe Armin's original patch is fine and this is
> a welcome cleanup / simplification of the DRM drivers Kconfig
> bits.

Your explanation makes sense, thanks.

BR,
Jani.


-- 
Jani Nikula, Intel


Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-18 Thread Hans de Goede
Hi,

On 16-Sep-26 09:16, Jani Nikula wrote:
> On Wed, 16 Sep 2026, Armin Wolf  wrote:
>> Am 15.09.26 um 14:31 schrieb Jani Nikula:
>>
>>> On Tue, 15 Sep 2026, Ilpo Järvinen  wrote:
 GPU people heads up!!

 On Wed, 2 Sep 2026, Armin Wolf wrote:

> Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
>>> b/drivers/gpu/drm/amd/amdgpu/Kconfig
>>> index 12e4a41bf1f0..50305630f533 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
>>> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
>>> @@ -30,9 +30,7 @@ config DRM_AMDGPU
>>> # ACPI_VIDEO's dependencies must also be selected.
>>> select INPUT if ACPI
>>> select ACPI_VIDEO if ACPI
>>> - # On x86 ACPI_VIDEO also needs ACPI_WMI
>>> - select X86_PLATFORM_DEVICES if ACPI && X86
>> The change below makes sense, but this one looks like it should remain
>> unless X86_PLATFORM_DEVICES is handled some other way?
>>
>> Alex
> AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
> ACPI-WMI depended on it in the past.
> By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.
 Hi all,

 Could more GPU people besides Alex take a look on this. I'd want to make
 progress with this series within this cycle but would prefer to have Acks
 from GPU side.
>>> I share the same concern with Alex. It seems to me we could now end up
>>> with x86 configurations without X86_PLATFORM_DEVICES, which handle
>>> e.g. backlight on a lot of platforms.
>>>
>>> I think the safer option might be to go for:
>>>
>>> depends on X86_PLATFORM_DEVICES || !X86
>>>
>>> in all of the cases that select/depend on X86_PLATFORM_DEVICES in drm.
>>>
>>> The alternative is to find out, and handle the fallout, if any.
>>>
>>>
>>> BR,
>>> Jani.
>>
>> Alright, should i leave the original "select X86_PLATFORM_DEVICES if ..." 
>> statements
>> as-is or should is change them to "depends on X86_PLATFORM_DEVICES || !X86" 
>> everywhere?
> 
> There are some places that depends on X86_PLATFORM_DEVICES. I think it's
> almost always a mistake to have some places select and some places
> depends on, and select should anyway be used with care. I'd go for
> depends on.

I'm a bit late to the party here, sorry.

Note that X86_PLATFORM_DEVICES is an option which enables / disables
a menu and does nothing more.

Enabling it or depending on it by itself does nothing.

The select used to be there since it must be selected to be able
to select ACPI_WMI (which is no longer the case after this series).

To depends on in XE was probably copy pasted from the existing
select-s and then changed to a depends and already was a completely
no-op since depending on ACPI_WMI was enough as that itself
dependend on ACPI_WMI.

As for X86_PLATFORM_DEVICES being needed for some backlight
interfaces, depending on it by itself does not result in those
interfaces being there. That requires enabling the actual drivers
providing those interfaces.

And I don't think that the GPU drivers should start depending
on those since that will become very unyielding.

TL;DR: I believe Armin's original patch is fine and this is
a welcome cleanup / simplification of the DRM drivers Kconfig
bits.

Regards,

Hans




Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-16 Thread Jani Nikula
On Wed, 16 Sep 2026, Armin Wolf  wrote:
> Am 15.09.26 um 14:31 schrieb Jani Nikula:
>
>> On Tue, 15 Sep 2026, Ilpo Järvinen  wrote:
>>> GPU people heads up!!
>>>
>>> On Wed, 2 Sep 2026, Armin Wolf wrote:
>>>
 Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
>> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
>> b/drivers/gpu/drm/amd/amdgpu/Kconfig
>> index 12e4a41bf1f0..50305630f533 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
>> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
>> @@ -30,9 +30,7 @@ config DRM_AMDGPU
>> # ACPI_VIDEO's dependencies must also be selected.
>> select INPUT if ACPI
>> select ACPI_VIDEO if ACPI
>> - # On x86 ACPI_VIDEO also needs ACPI_WMI
>> - select X86_PLATFORM_DEVICES if ACPI && X86
> The change below makes sense, but this one looks like it should remain
> unless X86_PLATFORM_DEVICES is handled some other way?
>
> Alex
 AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
 ACPI-WMI depended on it in the past.
 By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.
>>> Hi all,
>>>
>>> Could more GPU people besides Alex take a look on this. I'd want to make
>>> progress with this series within this cycle but would prefer to have Acks
>>> from GPU side.
>> I share the same concern with Alex. It seems to me we could now end up
>> with x86 configurations without X86_PLATFORM_DEVICES, which handle
>> e.g. backlight on a lot of platforms.
>>
>> I think the safer option might be to go for:
>>
>>  depends on X86_PLATFORM_DEVICES || !X86
>>
>> in all of the cases that select/depend on X86_PLATFORM_DEVICES in drm.
>>
>> The alternative is to find out, and handle the fallout, if any.
>>
>>
>> BR,
>> Jani.
>
> Alright, should i leave the original "select X86_PLATFORM_DEVICES if ..." 
> statements
> as-is or should is change them to "depends on X86_PLATFORM_DEVICES || !X86" 
> everywhere?

There are some places that depends on X86_PLATFORM_DEVICES. I think it's
almost always a mistake to have some places select and some places
depends on, and select should anyway be used with care. I'd go for
depends on.

BR,
Jani.


-- 
Jani Nikula, Intel


Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-16 Thread Armin Wolf

Am 15.09.26 um 14:31 schrieb Jani Nikula:


On Tue, 15 Sep 2026, Ilpo Järvinen  wrote:

GPU people heads up!!

On Wed, 2 Sep 2026, Armin Wolf wrote:


Am 01.09.26 um 23:30 schrieb Deucher, Alexander:


Public


-Original Message-
From: Armin Wolf 
Sent: Thursday, July 23, 2026 11:00 PM
To: [email protected]; [email protected]
Cc: [email protected]; [email protected];
[email protected]; [email protected]; [email protected]; linux-
[email protected]; Deucher, Alexander ;
Koenig, Christian ; [email protected];
[email protected]; [email protected]; dri-
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; intel-
[email protected]
Subject: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from
nvidia_wmi_ec_supported()

The WMI-ACPI driver now supports architectures other than x86.
Remove the CONFIG_X86 handling from video-detect and the associated
drivers to simplify the resulting code.

Acked-by: Rafael J. Wysocki (Intel) 
Signed-off-by: Armin Wolf 
---
   drivers/acpi/Kconfig   | 2 +-
   drivers/acpi/video_detect.c| 8 
   drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +---
   drivers/gpu/drm/gma500/Kconfig | 1 -
   drivers/gpu/drm/i915/Kconfig   | 1 -
   drivers/gpu/drm/radeon/Kconfig | 4 +---
   drivers/gpu/drm/xe/Kconfig | 5 ++---
   drivers/platform/loongarch/Kconfig | 1 +
   8 files changed, 6 insertions(+), 20 deletions(-)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index
f165d14cf61a..cc1e58fa664b 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -224,7 +224,7 @@ config ACPI_VIDEO
tristate "Video"
depends on BACKLIGHT_CLASS_DEVICE
depends on INPUT
- depends on ACPI_WMI || !X86
+ depends on ACPI_WMI
select THERMAL
help
  This driver implements the ACPI Extensions For Display Adapters
diff
--git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index
458efa4fe9d4..af9280b244f1 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -82,8 +82,6 @@ find_video(acpi_handle handle, u32 lvl, void *context,
void **rv)
return AE_OK;
   }

-/* This depends on ACPI_WMI which is X86 only */ -#ifdef CONFIG_X86
static bool nvidia_wmi_ec_supported(void)  {
struct wmi_brightness_args args = {
@@ -105,12 +103,6 @@ static bool nvidia_wmi_ec_supported(void)
 */
return args.ret == WMI_BRIGHTNESS_SOURCE_EC;  } -#else -static bool
nvidia_wmi_ec_supported(void) -{
- return false;
-}
-#endif

   /* Force to use vendor driver when the ACPI device is known to be
* buggy */
diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
b/drivers/gpu/drm/amd/amdgpu/Kconfig
index 12e4a41bf1f0..50305630f533 100644
--- a/drivers/gpu/drm/amd/amdgpu/Kconfig
+++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
@@ -30,9 +30,7 @@ config DRM_AMDGPU
# ACPI_VIDEO's dependencies must also be selected.
select INPUT if ACPI
select ACPI_VIDEO if ACPI
- # On x86 ACPI_VIDEO also needs ACPI_WMI
- select X86_PLATFORM_DEVICES if ACPI && X86

The change below makes sense, but this one looks like it should remain
unless X86_PLATFORM_DEVICES is handled some other way?

Alex

AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
ACPI-WMI depended on it in the past.
By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.

Hi all,

Could more GPU people besides Alex take a look on this. I'd want to make
progress with this series within this cycle but would prefer to have Acks
from GPU side.

I share the same concern with Alex. It seems to me we could now end up
with x86 configurations without X86_PLATFORM_DEVICES, which handle
e.g. backlight on a lot of platforms.

I think the safer option might be to go for:

depends on X86_PLATFORM_DEVICES || !X86

in all of the cases that select/depend on X86_PLATFORM_DEVICES in drm.

The alternative is to find out, and handle the fallout, if any.


BR,
Jani.


Alright, should i leave the original "select X86_PLATFORM_DEVICES if ..." 
statements
as-is or should is change them to "depends on X86_PLATFORM_DEVICES || !X86" 
everywhere?

Thanks,
Armin Wolf


- select ACPI_WMI if ACPI && X86
+ select ACPI_WMI if ACPI
help
  Choose this option if you have a recent AMD Radeon graphics card.

diff --git a/drivers/gpu/drm/gma500/Kconfig
b/drivers/gpu/drm/gma500/Kconfig index a2acaa699dd5..dc4c56638819
100644
--- a/drivers/gpu/drm/gma500/Kconfig
+++ b/drivers/gpu/drm/gma500/Kconfig
@@ -11,7 +11,6 @@ config DRM_GMA500
select ACPI_VIDEO if ACPI
select BACKLIGHT_CLASS_DEVICE if ACPI
select 

Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-15 Thread Rodrigo Vivi
On Tue, Sep 15, 2026 at 03:31:29PM +0300, Jani Nikula wrote:
> On Tue, 15 Sep 2026, Ilpo Järvinen  wrote:
> > GPU people heads up!!
> >
> > On Wed, 2 Sep 2026, Armin Wolf wrote:
> >
> >> Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
> >> 
> >> > Public
> >> > 
> >> > > -Original Message-
> >> > > From: Armin Wolf 
> >> > > Sent: Thursday, July 23, 2026 11:00 PM
> >> > > To: [email protected]; [email protected]
> >> > > Cc: [email protected]; [email protected];
> >> > > [email protected]; [email protected]; [email protected]; linux-
> >> > > [email protected]; Deucher, Alexander ;
> >> > > Koenig, Christian ; [email protected];
> >> > > [email protected]; [email protected]; dri-
> >> > > [email protected]; [email protected];
> >> > > [email protected]; [email protected];
> >> > > [email protected]; [email protected];
> >> > > [email protected]; [email protected];
> >> > > [email protected]; [email protected];
> >> > > [email protected]; [email protected]; intel-
> >> > > [email protected]
> >> > > Subject: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from
> >> > > nvidia_wmi_ec_supported()
> >> > > 
> >> > > The WMI-ACPI driver now supports architectures other than x86.
> >> > > Remove the CONFIG_X86 handling from video-detect and the associated
> >> > > drivers to simplify the resulting code.
> >> > > 
> >> > > Acked-by: Rafael J. Wysocki (Intel) 
> >> > > Signed-off-by: Armin Wolf 
> >> > > ---
> >> > >   drivers/acpi/Kconfig   | 2 +-
> >> > >   drivers/acpi/video_detect.c| 8 
> >> > >   drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +---
> >> > >   drivers/gpu/drm/gma500/Kconfig | 1 -
> >> > >   drivers/gpu/drm/i915/Kconfig   | 1 -
> >> > >   drivers/gpu/drm/radeon/Kconfig | 4 +---
> >> > >   drivers/gpu/drm/xe/Kconfig | 5 ++---
> >> > >   drivers/platform/loongarch/Kconfig | 1 +
> >> > >   8 files changed, 6 insertions(+), 20 deletions(-)
> >> > > 
> >> > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index
> >> > > f165d14cf61a..cc1e58fa664b 100644
> >> > > --- a/drivers/acpi/Kconfig
> >> > > +++ b/drivers/acpi/Kconfig
> >> > > @@ -224,7 +224,7 @@ config ACPI_VIDEO
> >> > >tristate "Video"
> >> > >depends on BACKLIGHT_CLASS_DEVICE
> >> > >depends on INPUT
> >> > > - depends on ACPI_WMI || !X86
> >> > > + depends on ACPI_WMI
> >> > >select THERMAL
> >> > >help
> >> > >  This driver implements the ACPI Extensions For Display 
> >> > > Adapters
> >> > > diff
> >> > > --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index
> >> > > 458efa4fe9d4..af9280b244f1 100644
> >> > > --- a/drivers/acpi/video_detect.c
> >> > > +++ b/drivers/acpi/video_detect.c
> >> > > @@ -82,8 +82,6 @@ find_video(acpi_handle handle, u32 lvl, void 
> >> > > *context,
> >> > > void **rv)
> >> > >return AE_OK;
> >> > >   }
> >> > > 
> >> > > -/* This depends on ACPI_WMI which is X86 only */ -#ifdef CONFIG_X86
> >> > > static bool nvidia_wmi_ec_supported(void)  {
> >> > >struct wmi_brightness_args args = {
> >> > > @@ -105,12 +103,6 @@ static bool nvidia_wmi_ec_supported(void)
> >> > > */
> >> > >return args.ret == WMI_BRIGHTNESS_SOURCE_EC;  } -#else -static 
> >> > > bool
> >> > > nvidia_wmi_ec_supported(void) -{
> >> > > - return false;
> >> > > -}
> >> > > -#endif
> >> > > 
> >> > >   /* Force to use vendor driver when the ACPI device is known to be
> >> > >* buggy */
> >> > > diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
> >> > > b/drivers/gpu/drm/amd/amdgpu/Kconfig
> >> > > index 12e4a41bf1f0..50305630f533 100644
> >> > > --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> >> > > +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> >> > > @@ -30,9 +30,7 @@ config DRM_AMDGPU
> >> > ># ACPI_VIDEO's dependencies must also be selected.
> >> > >select INPUT if ACPI
> >> > >select ACPI_VIDEO if ACPI
> >> > > - # On x86 ACPI_VIDEO also needs ACPI_WMI
> >> > > - select X86_PLATFORM_DEVICES if ACPI && X86
> >> > The change below makes sense, but this one looks like it should remain
> >> > unless X86_PLATFORM_DEVICES is handled some other way?
> >> > 
> >> > Alex
> >> 
> >> AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
> >> ACPI-WMI depended on it in the past.
> >> By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.
> >
> > Hi all,
> >
> > Could more GPU people besides Alex take a look on this. I'd want to make 
> > progress with this series within this cycle but would prefer to have Acks 
> > from GPU side.
> 
> I share the same concern with Alex. It seems to me we could now end up
> with x86 configurations without X86_PLATFORM_DEVICES, which handle
> e.g. backlight on a lot of platforms.
> 
> I think the safer option might be to 

Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-15 Thread Ilpo Järvinen
GPU people heads up!!

On Wed, 2 Sep 2026, Armin Wolf wrote:

> Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
> 
> > Public
> > 
> > > -Original Message-
> > > From: Armin Wolf 
> > > Sent: Thursday, July 23, 2026 11:00 PM
> > > To: [email protected]; [email protected]
> > > Cc: [email protected]; [email protected];
> > > [email protected]; [email protected]; [email protected]; linux-
> > > [email protected]; Deucher, Alexander ;
> > > Koenig, Christian ; [email protected];
> > > [email protected]; [email protected]; dri-
> > > [email protected]; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; [email protected]; intel-
> > > [email protected]
> > > Subject: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from
> > > nvidia_wmi_ec_supported()
> > > 
> > > The WMI-ACPI driver now supports architectures other than x86.
> > > Remove the CONFIG_X86 handling from video-detect and the associated
> > > drivers to simplify the resulting code.
> > > 
> > > Acked-by: Rafael J. Wysocki (Intel) 
> > > Signed-off-by: Armin Wolf 
> > > ---
> > >   drivers/acpi/Kconfig   | 2 +-
> > >   drivers/acpi/video_detect.c| 8 
> > >   drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +---
> > >   drivers/gpu/drm/gma500/Kconfig | 1 -
> > >   drivers/gpu/drm/i915/Kconfig   | 1 -
> > >   drivers/gpu/drm/radeon/Kconfig | 4 +---
> > >   drivers/gpu/drm/xe/Kconfig | 5 ++---
> > >   drivers/platform/loongarch/Kconfig | 1 +
> > >   8 files changed, 6 insertions(+), 20 deletions(-)
> > > 
> > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index
> > > f165d14cf61a..cc1e58fa664b 100644
> > > --- a/drivers/acpi/Kconfig
> > > +++ b/drivers/acpi/Kconfig
> > > @@ -224,7 +224,7 @@ config ACPI_VIDEO
> > >tristate "Video"
> > >depends on BACKLIGHT_CLASS_DEVICE
> > >depends on INPUT
> > > - depends on ACPI_WMI || !X86
> > > + depends on ACPI_WMI
> > >select THERMAL
> > >help
> > >  This driver implements the ACPI Extensions For Display Adapters
> > > diff
> > > --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index
> > > 458efa4fe9d4..af9280b244f1 100644
> > > --- a/drivers/acpi/video_detect.c
> > > +++ b/drivers/acpi/video_detect.c
> > > @@ -82,8 +82,6 @@ find_video(acpi_handle handle, u32 lvl, void *context,
> > > void **rv)
> > >return AE_OK;
> > >   }
> > > 
> > > -/* This depends on ACPI_WMI which is X86 only */ -#ifdef CONFIG_X86
> > > static bool nvidia_wmi_ec_supported(void)  {
> > >struct wmi_brightness_args args = {
> > > @@ -105,12 +103,6 @@ static bool nvidia_wmi_ec_supported(void)
> > > */
> > >return args.ret == WMI_BRIGHTNESS_SOURCE_EC;  } -#else -static bool
> > > nvidia_wmi_ec_supported(void) -{
> > > - return false;
> > > -}
> > > -#endif
> > > 
> > >   /* Force to use vendor driver when the ACPI device is known to be
> > >* buggy */
> > > diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > b/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > index 12e4a41bf1f0..50305630f533 100644
> > > --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > @@ -30,9 +30,7 @@ config DRM_AMDGPU
> > ># ACPI_VIDEO's dependencies must also be selected.
> > >select INPUT if ACPI
> > >select ACPI_VIDEO if ACPI
> > > - # On x86 ACPI_VIDEO also needs ACPI_WMI
> > > - select X86_PLATFORM_DEVICES if ACPI && X86
> > The change below makes sense, but this one looks like it should remain
> > unless X86_PLATFORM_DEVICES is handled some other way?
> > 
> > Alex
> 
> AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
> ACPI-WMI depended on it in the past.
> By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.

Hi all,

Could more GPU people besides Alex take a look on this. I'd want to make 
progress with this series within this cycle but would prefer to have Acks 
from GPU side.

> > > - select ACPI_WMI if ACPI && X86
> > > + select ACPI_WMI if ACPI
> > >help
> > >  Choose this option if you have a recent AMD Radeon graphics card.
> > > 
> > > diff --git a/drivers/gpu/drm/gma500/Kconfig
> > > b/drivers/gpu/drm/gma500/Kconfig index a2acaa699dd5..dc4c56638819
> > > 100644
> > > --- a/drivers/gpu/drm/gma500/Kconfig
> > > +++ b/drivers/gpu/drm/gma500/Kconfig
> > > @@ -11,7 +11,6 @@ config DRM_GMA500
> > >select ACPI_VIDEO if ACPI
> > >select BACKLIGHT_CLASS_DEVICE if ACPI
> > >select INPUT if ACPI
> > > - select X86_PLATFORM_DEVICES if ACPI
> > >select ACPI_WMI if ACPI
> > >help
> > > 

Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-15 Thread Jani Nikula
On Tue, 15 Sep 2026, Ilpo Järvinen  wrote:
> GPU people heads up!!
>
> On Wed, 2 Sep 2026, Armin Wolf wrote:
>
>> Am 01.09.26 um 23:30 schrieb Deucher, Alexander:
>> 
>> > Public
>> > 
>> > > -Original Message-
>> > > From: Armin Wolf 
>> > > Sent: Thursday, July 23, 2026 11:00 PM
>> > > To: [email protected]; [email protected]
>> > > Cc: [email protected]; [email protected];
>> > > [email protected]; [email protected]; [email protected]; linux-
>> > > [email protected]; Deucher, Alexander ;
>> > > Koenig, Christian ; [email protected];
>> > > [email protected]; [email protected]; dri-
>> > > [email protected]; [email protected];
>> > > [email protected]; [email protected];
>> > > [email protected]; [email protected];
>> > > [email protected]; [email protected];
>> > > [email protected]; [email protected];
>> > > [email protected]; [email protected]; intel-
>> > > [email protected]
>> > > Subject: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from
>> > > nvidia_wmi_ec_supported()
>> > > 
>> > > The WMI-ACPI driver now supports architectures other than x86.
>> > > Remove the CONFIG_X86 handling from video-detect and the associated
>> > > drivers to simplify the resulting code.
>> > > 
>> > > Acked-by: Rafael J. Wysocki (Intel) 
>> > > Signed-off-by: Armin Wolf 
>> > > ---
>> > >   drivers/acpi/Kconfig   | 2 +-
>> > >   drivers/acpi/video_detect.c| 8 
>> > >   drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +---
>> > >   drivers/gpu/drm/gma500/Kconfig | 1 -
>> > >   drivers/gpu/drm/i915/Kconfig   | 1 -
>> > >   drivers/gpu/drm/radeon/Kconfig | 4 +---
>> > >   drivers/gpu/drm/xe/Kconfig | 5 ++---
>> > >   drivers/platform/loongarch/Kconfig | 1 +
>> > >   8 files changed, 6 insertions(+), 20 deletions(-)
>> > > 
>> > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index
>> > > f165d14cf61a..cc1e58fa664b 100644
>> > > --- a/drivers/acpi/Kconfig
>> > > +++ b/drivers/acpi/Kconfig
>> > > @@ -224,7 +224,7 @@ config ACPI_VIDEO
>> > >tristate "Video"
>> > >depends on BACKLIGHT_CLASS_DEVICE
>> > >depends on INPUT
>> > > - depends on ACPI_WMI || !X86
>> > > + depends on ACPI_WMI
>> > >select THERMAL
>> > >help
>> > >  This driver implements the ACPI Extensions For Display Adapters
>> > > diff
>> > > --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index
>> > > 458efa4fe9d4..af9280b244f1 100644
>> > > --- a/drivers/acpi/video_detect.c
>> > > +++ b/drivers/acpi/video_detect.c
>> > > @@ -82,8 +82,6 @@ find_video(acpi_handle handle, u32 lvl, void *context,
>> > > void **rv)
>> > >return AE_OK;
>> > >   }
>> > > 
>> > > -/* This depends on ACPI_WMI which is X86 only */ -#ifdef CONFIG_X86
>> > > static bool nvidia_wmi_ec_supported(void)  {
>> > >struct wmi_brightness_args args = {
>> > > @@ -105,12 +103,6 @@ static bool nvidia_wmi_ec_supported(void)
>> > > */
>> > >return args.ret == WMI_BRIGHTNESS_SOURCE_EC;  } -#else -static 
>> > > bool
>> > > nvidia_wmi_ec_supported(void) -{
>> > > - return false;
>> > > -}
>> > > -#endif
>> > > 
>> > >   /* Force to use vendor driver when the ACPI device is known to be
>> > >* buggy */
>> > > diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
>> > > b/drivers/gpu/drm/amd/amdgpu/Kconfig
>> > > index 12e4a41bf1f0..50305630f533 100644
>> > > --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
>> > > +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
>> > > @@ -30,9 +30,7 @@ config DRM_AMDGPU
>> > ># ACPI_VIDEO's dependencies must also be selected.
>> > >select INPUT if ACPI
>> > >select ACPI_VIDEO if ACPI
>> > > - # On x86 ACPI_VIDEO also needs ACPI_WMI
>> > > - select X86_PLATFORM_DEVICES if ACPI && X86
>> > The change below makes sense, but this one looks like it should remain
>> > unless X86_PLATFORM_DEVICES is handled some other way?
>> > 
>> > Alex
>> 
>> AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because
>> ACPI-WMI depended on it in the past.
>> By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.
>
> Hi all,
>
> Could more GPU people besides Alex take a look on this. I'd want to make 
> progress with this series within this cycle but would prefer to have Acks 
> from GPU side.

I share the same concern with Alex. It seems to me we could now end up
with x86 configurations without X86_PLATFORM_DEVICES, which handle
e.g. backlight on a lot of platforms.

I think the safer option might be to go for:

depends on X86_PLATFORM_DEVICES || !X86

in all of the cases that select/depend on X86_PLATFORM_DEVICES in drm.

The alternative is to find out, and handle the fallout, if any.


BR,
Jani.


>
>> > > - select ACPI_WMI if ACPI && X86
>> > > + select ACPI_WMI if ACPI
>> > >

Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-03 Thread Armin Wolf

Am 01.09.26 um 23:30 schrieb Deucher, Alexander:


Public


-Original Message-
From: Armin Wolf 
Sent: Thursday, July 23, 2026 11:00 PM
To: [email protected]; [email protected]
Cc: [email protected]; [email protected];
[email protected]; [email protected]; [email protected]; linux-
[email protected]; Deucher, Alexander ;
Koenig, Christian ; [email protected];
[email protected]; [email protected]; dri-
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; intel-
[email protected]
Subject: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from
nvidia_wmi_ec_supported()

The WMI-ACPI driver now supports architectures other than x86.
Remove the CONFIG_X86 handling from video-detect and the associated
drivers to simplify the resulting code.

Acked-by: Rafael J. Wysocki (Intel) 
Signed-off-by: Armin Wolf 
---
  drivers/acpi/Kconfig   | 2 +-
  drivers/acpi/video_detect.c| 8 
  drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +---
  drivers/gpu/drm/gma500/Kconfig | 1 -
  drivers/gpu/drm/i915/Kconfig   | 1 -
  drivers/gpu/drm/radeon/Kconfig | 4 +---
  drivers/gpu/drm/xe/Kconfig | 5 ++---
  drivers/platform/loongarch/Kconfig | 1 +
  8 files changed, 6 insertions(+), 20 deletions(-)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index
f165d14cf61a..cc1e58fa664b 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -224,7 +224,7 @@ config ACPI_VIDEO
   tristate "Video"
   depends on BACKLIGHT_CLASS_DEVICE
   depends on INPUT
- depends on ACPI_WMI || !X86
+ depends on ACPI_WMI
   select THERMAL
   help
 This driver implements the ACPI Extensions For Display Adapters diff
--git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index
458efa4fe9d4..af9280b244f1 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -82,8 +82,6 @@ find_video(acpi_handle handle, u32 lvl, void *context,
void **rv)
   return AE_OK;
  }

-/* This depends on ACPI_WMI which is X86 only */ -#ifdef CONFIG_X86
static bool nvidia_wmi_ec_supported(void)  {
   struct wmi_brightness_args args = {
@@ -105,12 +103,6 @@ static bool nvidia_wmi_ec_supported(void)
*/
   return args.ret == WMI_BRIGHTNESS_SOURCE_EC;  } -#else -static bool
nvidia_wmi_ec_supported(void) -{
- return false;
-}
-#endif

  /* Force to use vendor driver when the ACPI device is known to be
   * buggy */
diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
b/drivers/gpu/drm/amd/amdgpu/Kconfig
index 12e4a41bf1f0..50305630f533 100644
--- a/drivers/gpu/drm/amd/amdgpu/Kconfig
+++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
@@ -30,9 +30,7 @@ config DRM_AMDGPU
   # ACPI_VIDEO's dependencies must also be selected.
   select INPUT if ACPI
   select ACPI_VIDEO if ACPI
- # On x86 ACPI_VIDEO also needs ACPI_WMI
- select X86_PLATFORM_DEVICES if ACPI && X86

The change below makes sense, but this one looks like it should remain unless 
X86_PLATFORM_DEVICES is handled some other way?

Alex


AFAIK the dependency on X86_PLATFORM_DEVICES was only necessary because 
ACPI-WMI depended on it in the past.
By now ACPI-WMI neither depends on X86_PLATFORM_DEVICES or X86 anymore.

Thanks,
Armin Wolf


- select ACPI_WMI if ACPI && X86
+ select ACPI_WMI if ACPI
   help
 Choose this option if you have a recent AMD Radeon graphics card.

diff --git a/drivers/gpu/drm/gma500/Kconfig
b/drivers/gpu/drm/gma500/Kconfig index a2acaa699dd5..dc4c56638819
100644
--- a/drivers/gpu/drm/gma500/Kconfig
+++ b/drivers/gpu/drm/gma500/Kconfig
@@ -11,7 +11,6 @@ config DRM_GMA500
   select ACPI_VIDEO if ACPI
   select BACKLIGHT_CLASS_DEVICE if ACPI
   select INPUT if ACPI
- select X86_PLATFORM_DEVICES if ACPI
   select ACPI_WMI if ACPI
   help
 Say yes for an experimental 2D KMS framebuffer driver for the diff --
git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index
5e939004b646..71426b9c91f0 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -28,7 +28,6 @@ config DRM_I915
   # but for select to work, need to select ACPI_VIDEO's dependencies,
ick
   select BACKLIGHT_CLASS_DEVICE if ACPI
   select INPUT if ACPI
- select X86_PLATFORM_DEVICES if ACPI
   select ACPI_WMI if ACPI
   select ACPI_VIDEO if ACPI
   select SYNC_FILE
diff --git a/drivers/gpu/drm/radeon/Kconfig
b/drivers/gpu/drm/radeon/Kconfig index c479f0c0dd5c..3cd70aef770e
100644
--- a/drivers/gpu/drm/radeon/Kconfig
+++ b/drivers/gpu/drm/radeon/Kconfig
@@ -25,9 +25,7 @@ config DRM_RADEON
   # ACPI_VIDEO's dependencies must also be 

RE: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

2026-09-01 Thread Deucher, Alexander
Public

> -Original Message-
> From: Armin Wolf 
> Sent: Thursday, July 23, 2026 11:00 PM
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; linux-
> [email protected]; Deucher, Alexander ;
> Koenig, Christian ; [email protected];
> [email protected]; [email protected]; dri-
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; intel-
> [email protected]
> Subject: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from
> nvidia_wmi_ec_supported()
>
> The WMI-ACPI driver now supports architectures other than x86.
> Remove the CONFIG_X86 handling from video-detect and the associated
> drivers to simplify the resulting code.
>
> Acked-by: Rafael J. Wysocki (Intel) 
> Signed-off-by: Armin Wolf 
> ---
>  drivers/acpi/Kconfig   | 2 +-
>  drivers/acpi/video_detect.c| 8 
>  drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +---
>  drivers/gpu/drm/gma500/Kconfig | 1 -
>  drivers/gpu/drm/i915/Kconfig   | 1 -
>  drivers/gpu/drm/radeon/Kconfig | 4 +---
>  drivers/gpu/drm/xe/Kconfig | 5 ++---
>  drivers/platform/loongarch/Kconfig | 1 +
>  8 files changed, 6 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index
> f165d14cf61a..cc1e58fa664b 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -224,7 +224,7 @@ config ACPI_VIDEO
>   tristate "Video"
>   depends on BACKLIGHT_CLASS_DEVICE
>   depends on INPUT
> - depends on ACPI_WMI || !X86
> + depends on ACPI_WMI
>   select THERMAL
>   help
> This driver implements the ACPI Extensions For Display Adapters diff
> --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index
> 458efa4fe9d4..af9280b244f1 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -82,8 +82,6 @@ find_video(acpi_handle handle, u32 lvl, void *context,
> void **rv)
>   return AE_OK;
>  }
>
> -/* This depends on ACPI_WMI which is X86 only */ -#ifdef CONFIG_X86
> static bool nvidia_wmi_ec_supported(void)  {
>   struct wmi_brightness_args args = {
> @@ -105,12 +103,6 @@ static bool nvidia_wmi_ec_supported(void)
>*/
>   return args.ret == WMI_BRIGHTNESS_SOURCE_EC;  } -#else -static bool
> nvidia_wmi_ec_supported(void) -{
> - return false;
> -}
> -#endif
>
>  /* Force to use vendor driver when the ACPI device is known to be
>   * buggy */
> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
> b/drivers/gpu/drm/amd/amdgpu/Kconfig
> index 12e4a41bf1f0..50305630f533 100644
> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> @@ -30,9 +30,7 @@ config DRM_AMDGPU
>   # ACPI_VIDEO's dependencies must also be selected.
>   select INPUT if ACPI
>   select ACPI_VIDEO if ACPI
> - # On x86 ACPI_VIDEO also needs ACPI_WMI
> - select X86_PLATFORM_DEVICES if ACPI && X86

The change below makes sense, but this one looks like it should remain unless 
X86_PLATFORM_DEVICES is handled some other way?

Alex

> - select ACPI_WMI if ACPI && X86
> + select ACPI_WMI if ACPI
>   help
> Choose this option if you have a recent AMD Radeon graphics card.
>
> diff --git a/drivers/gpu/drm/gma500/Kconfig
> b/drivers/gpu/drm/gma500/Kconfig index a2acaa699dd5..dc4c56638819
> 100644
> --- a/drivers/gpu/drm/gma500/Kconfig
> +++ b/drivers/gpu/drm/gma500/Kconfig
> @@ -11,7 +11,6 @@ config DRM_GMA500
>   select ACPI_VIDEO if ACPI
>   select BACKLIGHT_CLASS_DEVICE if ACPI
>   select INPUT if ACPI
> - select X86_PLATFORM_DEVICES if ACPI
>   select ACPI_WMI if ACPI
>   help
> Say yes for an experimental 2D KMS framebuffer driver for the diff --
> git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index
> 5e939004b646..71426b9c91f0 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -28,7 +28,6 @@ config DRM_I915
>   # but for select to work, need to select ACPI_VIDEO's dependencies,
> ick
>   select BACKLIGHT_CLASS_DEVICE if ACPI
>   select INPUT if ACPI
> - select X86_PLATFORM_DEVICES if ACPI
>   select ACPI_WMI if ACPI
>   select ACPI_VIDEO if ACPI
>   select SYNC_FILE
> diff --git a/drivers/gpu/drm/radeon/Kconfig
> b/drivers/gpu/drm/radeon/Kconfig index c479f0c0dd5c..3cd70aef770e
> 100644
> --- a/drivers/gpu/drm/radeon/Kconfig
> +++ b/drivers/gpu/drm/radeon/Kconfig
> @@ -25,9 +25,7 @@ config DRM_RADEON
>   # ACPI_VIDEO's dependencies must also be selected.
>   select INPUT if ACPI
>   select ACPI_VIDEO if