Re: [RFC PATCH] drm/amdgpu: move ttm bo->offset to amdgpu_bo

2020-02-11 Thread Nirmoy
On 2/11/20 1:17 PM, Christian König wrote: Am 11.02.20 um 13:06 schrieb Nirmoy: Hi Christian On 2/11/20 12:50 PM, Christian König wrote: Am 11.02.20 um 12:17 schrieb Nirmoy Das: GPU address should belong to driver not in memory management. This patch moves ttm bo.offset and gpu_offset

Re: [RFC PATCH] drm/amdgpu: move ttm bo->offset to amdgpu_bo

2020-02-11 Thread Christian König
Am 11.02.20 um 13:11 schrieb Nirmoy: On 2/11/20 12:57 PM, Huang Rui wrote: On Tue, Feb 11, 2020 at 12:17:22PM +0100, Nirmoy Das wrote: GPU address should belong to driver not in memory management. This patch moves ttm bo.offset and gpu_offset calculation to amdgpu driver. Looks good for

Re: [RFC PATCH] drm/amdgpu: move ttm bo->offset to amdgpu_bo

2020-02-11 Thread Christian König
Am 11.02.20 um 13:06 schrieb Nirmoy: Hi Christian On 2/11/20 12:50 PM, Christian König wrote: Am 11.02.20 um 12:17 schrieb Nirmoy Das: GPU address should belong to driver not in memory management. This patch moves ttm bo.offset and gpu_offset calculation to amdgpu driver. Actually for

Re: [RFC PATCH] drm/amdgpu: move ttm bo->offset to amdgpu_bo

2020-02-11 Thread Nirmoy
On 2/11/20 12:57 PM, Huang Rui wrote: On Tue, Feb 11, 2020 at 12:17:22PM +0100, Nirmoy Das wrote: GPU address should belong to driver not in memory management. This patch moves ttm bo.offset and gpu_offset calculation to amdgpu driver. Looks good for me. Yes, agree, the mc address should be

Re: [RFC PATCH] drm/amdgpu: move ttm bo->offset to amdgpu_bo

2020-02-11 Thread Nirmoy
Hi Christian On 2/11/20 12:50 PM, Christian König wrote: Am 11.02.20 um 12:17 schrieb Nirmoy Das: GPU address should belong to driver not in memory management. This patch moves ttm bo.offset and gpu_offset calculation to amdgpu driver. Actually for amdgpu we should be able to get completely

Re: [RFC PATCH] drm/amdgpu: move ttm bo->offset to amdgpu_bo

2020-02-11 Thread Huang Rui
On Tue, Feb 11, 2020 at 12:17:22PM +0100, Nirmoy Das wrote: > GPU address should belong to driver not in memory management. > This patch moves ttm bo.offset and gpu_offset calculation to amdgpu driver. > Looks good for me. Yes, agree, the mc address should be got from amdgpu_bo. Acked-by: Huang

Re: [RFC PATCH] drm/amdgpu: move ttm bo->offset to amdgpu_bo

2020-02-11 Thread Christian König
Am 11.02.20 um 12:17 schrieb Nirmoy Das: GPU address should belong to driver not in memory management. This patch moves ttm bo.offset and gpu_offset calculation to amdgpu driver. Actually for amdgpu we should be able to get completely rid of bo->offset. All we need to do is to change