Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-15 Thread Youness Alaoui
humm.. you said "it works properly" which means ? I thought it meant "it means properly for %W emoticons", but then the rest of the mail suggests that it doesn't.. so I'm a little lost.. I might try this later if I get the time and see what you really meant. good point about the editCustomEmoti

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-15 Thread Youness Alaoui
On Fri, Dec 15, 2006 at 11:27:03AM +0100, Cristofaro Del Prete wrote: > Youness Alaoui ha scritto: > > I'm just wondering about something... Do you know (or did you understand, > > or does anybody else knows) why the > > bind on does the bind on the and why the bind on the > > itself does a b

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-15 Thread Cristofaro Del Prete
Oops, I forgot one thing: Youness Alaoui ha scritto: > While looking at this small portion of code in the diff, I also noticed > something else... we do a check for > whether the smiley is equal to %, in which case we insert %% (because the > 'bind' replaced %x with variable > values), but did

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-15 Thread Cristofaro Del Prete
reggaemanu ha scritto: > Could you give me more detail of what you noticed/tested/guessed while > testing? Well, I incidentally pressed the mouse button on a smiley, without releasing it, and noticed that the menu instantly disappeared. Then I looked the code, and I saw the bindings; so I figured

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-15 Thread Cristofaro Del Prete
Youness Alaoui ha scritto: > I'm just wondering about something... Do you know (or did you understand, or > does anybody else knows) why the > bind on does the bind on the and why the bind on the > itself does a bind on the .. > couldn't it be directly a bind "handleLeave" ? I haven't inves

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread reggaemanu
Looking at beryl events code i don't see what could be wrong and cause a leave event with buttonPress, the problem doesn't seem to be there. Could you give me more detail of what you noticed/tested/guessed while testing? Anyway, I'll point others beryl devs to this thread and I don't think this pa

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread Youness Alaoui
Hi Cristofaro, Thanks for the patch, I'm impressed with you finding the reason of this bug, it does look a little hacky/weird problem, and it's nice that you fixed it. As reggaeman said, it's a WM issue which should be fixed by Beryl, but a workaround in amsn is a good thing for now. I just wan

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread Cristofaro Del Prete
I've finally found the problem. Seems that, under Beryl, a ButtonPress event triggers for some reason a Leave event, and then the menu is withdrawn before it can catch the ButtonRelease event. This final patch implements a handleLeaveEvent procedure that checks if the mouse pointer is outside the

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread Cristofaro Del Prete
Right; in fact it's a very strange problem, as the behavior is almost completely random (speed-clicking didn't always work, for me). I will still continue my research for a full workaround (this one makes impossible to close the smilies menu without choosing one), as new evidence emerged: when com

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread reggaemanu
Just commenting the following line works fine yeah: bind $w "bind $w \"bind $w \\\"wm state $w withdrawn\\\"\"" ...but in fact, that has to be fixed in compiz/beryl, not in amsn, since others wm handle this window like it should be. Anyway, if you find a workaround on amsn side before some

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread Cristofaro Del Prete
Looks like this time I've (hopefully) got it... Seems that the "close the menu upon mouse exit" was the problem, so I commented it; try the new patch and if it's working for you too, I'll try re-implementing the incriminated feature. Steve H ha scritto: > If you click *really* fast then the click

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread Steve H
If you click *really* fast then the click will be registered properly under beryl (with or without this patch) On 12/14/06, Cristofaro Del Prete <[EMAIL PROTECTED]> wrote: I just tried again, and it's not working anymore neither here... or better said, now it works only rarely (1 out of 20 trie

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread Cristofaro Del Prete
I just tried again, and it's not working anymore neither here... or better said, now it works only rarely (1 out of 20 tries) :( I'm already working on it; new patch ASAP, sorry... Philippe Valembois - Phil ha scritto: > Hi, > doesn't work here with Beryl SVN from beginning of week... > Phil > >

Re: [Amsn-devel] [PATCH] Smileys menu not working under Compiz/Beryl WM

2006-12-14 Thread Philippe Valembois - Phil
Hi, doesn't work here with Beryl SVN from beginning of week... Phil Le Thursday 14 December 2006 20:10, Cristofaro Del Prete a écrit : > Hi guys, > surely you have heard of the annoyance regarding the smileys menu under > Compiz/Beryl; if this is not the case, you should know that the menu > does