Re: [Amsn-devel] bugfix for custom smileys

2007-05-22 Thread Youness Alaoui
what about elided text ? elided is when text is 'hidden', smileys are not deleted and replaced by an image, they're hidden (elided) so if you don't check and make sure no elided text is being read, then it will go into infinite loop.. which tcl/tk versions did you test this on ? try it on

Re: [Amsn-devel] bugfix for custom smileys

2007-05-22 Thread Mirko Hansen
ah, thanks for the explanation of the elided thing. i'm slightly new to tcl/tk and wondered what this exactly means. so i greped the source for elide and it seems that there should be no elided text at all. tell me if i'm wrong, but the only two things being elided are the smileys and the

Re: [Amsn-devel] bugfix for custom smileys

2007-05-22 Thread Youness Alaoui
you can find all the info you ever need in the tcl/tk man pages. For example : http://www.tcl.tk/man/tcl8.4/TkCmd/text.htm#M39 Yes, there is 'no' text that is elided apart from the one we specifically set to elided (the smileys). The reason for it is that, if you ever noticed, when you

Re: [Amsn-devel] bugfix for custom smileys

2007-05-22 Thread Mirko Hansen
thanks a lot for your detailed explanation, it helped me really understanding the problem. the commit log only said it was a workaround for a bug in tk 8.4, so i concluded from the removal of the same piece of code (for the outgoing part) that it isn't needed anymore. but ok, so i canceled my

Re: [Amsn-devel] bugfix for custom smileys

2007-05-21 Thread Mirko Hansen
Another fix from me concerning smileys: Sometimes incoming emoticons, not separated by a space, in special constellations, aren't replaced by the image. This fix works fine for me, but I'm not sure whether this piece of code is still needed. The comment on revision 6270 says it's a workaround for

[Amsn-devel] bugfix for custom smileys

2007-05-20 Thread Mirko Hansen
Hi, this patch fixes the problem that prevents showing the own emoticons in the chat window, if you use uppercase letters in your profile name. Greetings, Mirko smiley-patch.diff Description: Binary data - This SF.net

Re: [Amsn-devel] bugfix for custom smileys

2007-05-20 Thread Vivia Nikolaidou
Thanx! Committing :) On 5/20/07, Mirko Hansen [EMAIL PROTECTED] wrote: Hi, this patch fixes the problem that prevents showing the own emoticons in the chat window, if you use uppercase letters in your profile name. Greetings, Mirko