Re: [Amsn-devel] Merging P2P branch
Merged!! Thanks Alex! VGJ! You had forgotten one small modification on gui.tcl so sending/receiving files didn't work - I fixed that. I also examined the current diff between the trunk and the branch, with all brainpower I had left, didn't look like it had anything wrong. However, everyone please keep in mind that we might have problems in the near future :) I also didn't extensively examine msncam.tcl since it worked, it had many modifications where I removed legacy objoptions and replaced them with 'good' snit. Vivia On Mon, Feb 14, 2011 at 00:36, Vivia Nikolaidou vi...@ee.auth.gr wrote: On Sun, Feb 13, 2011 at 04:13, Alexander Nestorov alexander...@gmail.com wrote: Ok, done merging again :) This time the patch is ~75kb, I'm sure that everything went fine, but again, some testing is needed. Thanks!!! GJ! ☺ On Mon, Feb 14, 2011 at 00:25, Boris 'billiob' Faure bill...@gmail.com wrote: @vivia: what about those #@@ comments? Notes to self. Most of them are places to be modified for p2pv2. They're easy to see and easy to grep, so that's why I use them ☺ It's running fine for me ftm. Thanks for testing! I'll still have to review it myself though, found no time for it today. Vivia -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
Re: [Amsn-devel] Merging P2P branch
On Sun, Feb 13, 2011 at 04:13, Alexander Nestorov alexander...@gmail.com wrote: Ok, done merging again :) This time the patch is ~75kb, I'm sure that everything went fine, but again, some testing is needed. Indentation is broken, but i don't think it's that important. On the same level, there are some trailing whitespaces. @vivia: what about those #@@ comments? It's running fine for me ftm. Greetings -- Boris 'billiob' Faure -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
Re: [Amsn-devel] Merging P2P branch
On Sun, Feb 13, 2011 at 04:13, Alexander Nestorov alexander...@gmail.com wrote: Ok, done merging again :) This time the patch is ~75kb, I'm sure that everything went fine, but again, some testing is needed. Thanks!!! GJ! ☺ On Mon, Feb 14, 2011 at 00:25, Boris 'billiob' Faure bill...@gmail.com wrote: @vivia: what about those #@@ comments? Notes to self. Most of them are places to be modified for p2pv2. They're easy to see and easy to grep, so that's why I use them ☺ It's running fine for me ftm. Thanks for testing! I'll still have to review it myself though, found no time for it today. Vivia -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
Re: [Amsn-devel] Merging P2P branch
On Fri, Feb 11, 2011 at 01:50, Vivia Nikolaidou vi...@ee.auth.gr wrote: PS: I think I overused something in this mail (... parentheses!) Are you developing in lisp? Or maybe you read latest xkcd: http://xkcd.com/859/ -- Boris 'billiob' Faure -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
Re: [Amsn-devel] Merging P2P branch
Hi Alex! Thanks for making the diff, and VGJ!! However, I'm _really_ *extremely* busy with other stuff at the lab these days (it's annoying when several top-priority urgent things pop up at the same time ☹) so... I am sorry... I probably can't review it until this weekend ☹ However, I do have some comments for you. The memleak might be because KKRT has msnp18 enabled. You can try that too. I especially want to know which revision started it. As for gui.tcl , you mean 600 out of 650 KB of your patch are just ... removed and readded whitespace??... Did you even know about the -w option in diff and -l option in patch? They are ignore whitespace options. So it would really be good to make an unpatched gui.tcl between current trunk and your patched gui.tcl, perform a diff -w -C3 (we do need three lines of context), and use that instead. (I know you did a lot of work already, but could you _please_ do that too? I don't think it would take more than 5 minutes :$) Once you're done with that, I'll review your patch. Note to everyone else: I don't want to merge without me reviewing it first, especially since I still remember more or less which commit was about what and I don't want to find out unwanted stuff in there (e.g. a bug accidentally brought back). TODO: the bug you reported: you may cancel a file you just sent but it will still be sent. (aka: if you misclick, you either quit your client or are mortified) Thanks again!!! Vivia PS: I think I overused something in this mail (... parentheses!) On Thu, Feb 10, 2011 at 23:48, Alexander Nestorov alexander...@gmail.com wrote: Hi, I was working on merging vivia's p2p branch, and here is the result. It has been a 7 days full-time work + 2 days of testing, and I haven't found nothing unusual, but I'd like to get some feedback as I wasn't able to reproduce the memleak, present until the very latest commits in p2p branch, which KaKaRoTo got almost after every start. gui.tcl has a PITA, there is some weird indentation change between trunk and p2p, so the patch is +600kb, and you'll probably see the same code being removed and then readed. I didn't know if I should left that or ignore it, so I decided to leave it. Regards! -- alexandernst -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
Re: [Amsn-devel] Merging P2P branch
Hmmm... Thanks for the reply, but why don't you just fwd it to the ML instead? :) Oh, PEBKAC! Reply button set you as For: instead of ML. I'll copy the reply here: - Hey viv :) Thanks for making the diff, and VGJ!! However, I'm _really_ *extremely* busy with other stuff at the lab these days (it's annoying when several top-priority urgent things pop up at the same time ☹) so... I am sorry... I probably can't review it until this weekend ☹ No rush, take your time ;) The memleak might be because KKRT has msnp18 enabled. You can try that too. I especially want to know which revision started it. Ok, I'll make more tests with p18 and check what rev they started and ended (if I can reproduce them). removed and readded whitespace??... Did you even know about the -w /me never did man diff :$ option in diff and -l option in patch? They are ignore whitespace :facepalm: between current trunk and your patched gui.tcl, perform a diff -w -C3 (we do need three lines of context), and use that instead. (I know you did a lot of work already, but could you _please_ do that too? I don't think it would take more than 5 minutes :$) Yes!! I needed something like that!! I am almost sure that I merged everything fine, but it will be OK to check it again, just to be sure. Regards! :) -- -- alexandernst -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb___ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
