Re: apicheck

2009-03-04 Thread Jey Michael
On Wed, Mar 4, 2009 at 5:59 AM, Jean-Baptiste Queru j...@android.com wrote: There are two steps in apicheck: -whether you changed a public API at all (that's the part that uses current.xml), so that there is a mechanism to have any API change reviewed and approved before they're submitted.

Re: apicheck

2009-03-04 Thread Jean-Baptiste Queru
Well, the good news is that this is the right list to discuss the consequences of changing a constant in the API. JBQ On Wed, Mar 4, 2009 at 1:38 PM, Jey Michael jey.mich...@gmail.com wrote: On Wed, Mar 4, 2009 at 5:59 AM, Jean-Baptiste Queru j...@android.com wrote: There are two steps in

Re: apicheck

2009-03-04 Thread Dianne Hackborn
On Wed, Mar 4, 2009 at 1:38 PM, Jey Michael jey.mich...@gmail.com wrote: Thanks JBQ. I am running into the second one. :-( This makes it important for me to try getting the changes to public api, I suppose. https://review.source.android.com/9070 [Dianne Hackborn]

Re: apicheck

2009-03-04 Thread Dianne Hackborn
That's a current.xml change, which is fine, it is just showing that new APIs are being added. There is no need to change 3.xml due to this. On Wed, Mar 4, 2009 at 3:11 PM, Jey Michael jey.mich...@gmail.com wrote: Sigh! I missed that. Its in: https://review.source.android.com/9075 -Jey

Re: apicheck

2009-03-04 Thread Jey Michael
Hm... I am learning to use Gerrit properly, and redid the submissions a few times... Finally my changes are all grouped under these 2 patchsets: https://review.source.android.com/9080 https://review.source.android.com/9081 Thanks, Jey On Wed, Mar 4, 2009 at 3:40 PM, Dianne Hackborn