Re: [AngularJS] Re: minification of angularjs itself

2014-10-07 Thread Sander Elias
Hi Johan,

That's right, but you didn't mention jQuery earlier, so I didn't take that 
in account ;)

Regards
Sander

-- 
You received this message because you are subscribed to the Google Groups 
AngularJS group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to angular+unsubscr...@googlegroups.com.
To post to this group, send email to angular@googlegroups.com.
Visit this group at http://groups.google.com/group/angular.
For more options, visit https://groups.google.com/d/optout.


Re: [AngularJS] Re: minification of angularjs itself

2014-10-06 Thread Johan Dindaine
I got the resource from bower, could that be the problem?

2014-10-06 5:26 GMT+01:00 Sander Elias sanderel...@gmail.com:

 Hi Johan,


 Concatenating the minified version should give you no problem. However,
 you should take care on
 the ordering of your resources. If you for example put angular-route
 before angular itself, you might
 get the error you are experiencing.

 the same issue goes on of you do the build and minify the libraries
 yourself. This is however not
 recommend, there are some issues that you should take in account if you
 want to minify angular yourself.

 Regards
 Sander Elias

 --
 You received this message because you are subscribed to the Google Groups
 AngularJS group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to angular+unsubscr...@googlegroups.com.
 To post to this group, send email to angular@googlegroups.com.
 Visit this group at http://groups.google.com/group/angular.
 For more options, visit https://groups.google.com/d/optout.


-- 
You received this message because you are subscribed to the Google Groups 
AngularJS group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to angular+unsubscr...@googlegroups.com.
To post to this group, send email to angular@googlegroups.com.
Visit this group at http://groups.google.com/group/angular.
For more options, visit https://groups.google.com/d/optout.


Re: [AngularJS] Re: minification of angularjs itself

2014-10-06 Thread Sander Elias
Hi Johan,

No, that's not the problem. The problem is the order in wich you 
concatenate your files. AngularJS should go first.

Regards
Sander

-- 
You received this message because you are subscribed to the Google Groups 
AngularJS group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to angular+unsubscr...@googlegroups.com.
To post to this group, send email to angular@googlegroups.com.
Visit this group at http://groups.google.com/group/angular.
For more options, visit https://groups.google.com/d/optout.


Re: [AngularJS] Re: minification of angularjs itself

2014-10-06 Thread Johan Dindaine
I thought that Jquery needed to come first so that angular avoid using its
jqlite then angularjs then angular-route and so on.

2014-10-06 12:38 GMT+01:00 Sander Elias sanderel...@gmail.com:

 Hi Johan,

 No, that's not the problem. The problem is the order in wich you
 concatenate your files. AngularJS should go first.

 Regards
 Sander

 --
 You received this message because you are subscribed to the Google Groups
 AngularJS group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to angular+unsubscr...@googlegroups.com.
 To post to this group, send email to angular@googlegroups.com.
 Visit this group at http://groups.google.com/group/angular.
 For more options, visit https://groups.google.com/d/optout.


-- 
You received this message because you are subscribed to the Google Groups 
AngularJS group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to angular+unsubscr...@googlegroups.com.
To post to this group, send email to angular@googlegroups.com.
Visit this group at http://groups.google.com/group/angular.
For more options, visit https://groups.google.com/d/optout.


Re: [AngularJS] Re: minification of angularjs itself

2014-10-06 Thread Tony pee
yes, this is true. Jquery, angular, angular modules, etc.

I use uglify over my dependencies like this and have no issues, in even
your most basic test things fail?

On 6 October 2014 09:41, Johan Dindaine jojolapin...@gmail.com wrote:

 I thought that Jquery needed to come first so that angular avoid using its
 jqlite then angularjs then angular-route and so on.

 2014-10-06 12:38 GMT+01:00 Sander Elias sanderel...@gmail.com:

 Hi Johan,

 No, that's not the problem. The problem is the order in wich you
 concatenate your files. AngularJS should go first.

 Regards
 Sander

 --
 You received this message because you are subscribed to the Google Groups
 AngularJS group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to angular+unsubscr...@googlegroups.com.
 To post to this group, send email to angular@googlegroups.com.
 Visit this group at http://groups.google.com/group/angular.
 For more options, visit https://groups.google.com/d/optout.


  --
 You received this message because you are subscribed to the Google Groups
 AngularJS group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to angular+unsubscr...@googlegroups.com.
 To post to this group, send email to angular@googlegroups.com.
 Visit this group at http://groups.google.com/group/angular.
 For more options, visit https://groups.google.com/d/optout.




-- 
Tony Polinelli

-- 
You received this message because you are subscribed to the Google Groups 
AngularJS group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to angular+unsubscr...@googlegroups.com.
To post to this group, send email to angular@googlegroups.com.
Visit this group at http://groups.google.com/group/angular.
For more options, visit https://groups.google.com/d/optout.