Re: problems with output containing CDATA sections when using XmlLogger

2003-01-15 Thread Stefan Bodewig
On Tue, 14 Jan 2003, Steve Prentice <[EMAIL PROTECTED]> wrote: > yes, simply replacing the ']' characters with ] would be > enough. OK, patched on CVS. Stefan -- To unsubscribe, e-mail: For additional commands, e-mail:

Re: problems with output containing CDATA sections when using XmlLogger

2003-01-14 Thread Steve Prentice
Sorry about replying to my reply, but to answer your question; yes, simply replacing the ']' characters with ] would be enough. I have tested this and it works fine. Also, I tested replacing the call to encodedata with encode and it produces valid XML as well. However, I am not sure if there ar

Re: problems with output containing CDATA sections when using XmlLogger

2003-01-14 Thread Steve Prentice
org.apache.tools.ant.util.DOMElementWriter has the proper encode method, but it doesn't use it for writing CDATA sections. It uses a method called encodedata, which drops illegal characters, but does not encode the data. I think that reusing the encode method to encode CDATA sections would work

Re: problems with output containing CDATA sections when using XmlLogger

2003-01-14 Thread Stefan Bodewig
On Mon, 13 Jan 2003, Steve Prentice <[EMAIL PROTECTED]> wrote: > This is occuring because my build output contains > sections that are not being escaped (encoded) before being added to > the log document. Should be fixed. What would be the proper escaping encoding here, would replacing the ] ch

problems with output containing CDATA sections when using XmlLogger

2003-01-14 Thread Steve Prentice
Hi all- I am having a problem with the XmlLogger creating invalid XML documents. This is occuring because my build output contains sections that are not being escaped (encoded) before being added to the log document. I noticed that in older versions of Ant (like 1.2) the text was being encoded