Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-12 Thread Tom Jackson
On Friday 11 February 2005 10:41, Dossy Shiobara wrote: On 2005.02.11, Tom Jackson [EMAIL PROTECTED] wrote: My Config file contains: # # Server url, Proxy Redirects ns_section ns/server/${server}/redirects ns_param 404 global/file-not-found.tcl ns_param 500

[AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Dossy Shiobara
Hi, AOLserver has internal redirects that allow overriding of some (currently not all, strangely) responses based on the HTTP status code. The configuration section looks like this (from the Annotated Config. Reference): # # Internal redirects # ns_section

Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Greg Wolff
BNA doesn't use Internal Redirects in our code base. We didn't like the log behavior. Your proposal to change the log behavior is an idea that I agree with. Are you intending the 404 to appear in the log and then execute the redirect page? I agree with your thoughts on overriding all response

Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Tom Jackson
On Friday 11 February 2005 06:02, Dossy Shiobara wrote: I have two proposed changes: 1) Allow overriding of all response codes. This may not actually be a good idea, but it just seems odd that only certain response codes have their own C API which uses the internal redirect mechanism.

Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Dossy Shiobara
On 2005.02.11, Tom Jackson [EMAIL PROTECTED] wrote: My Config file contains: # # Server url, Proxy Redirects ns_section ns/server/${server}/redirects ns_param 404 global/file-not-found.tcl ns_param 500 global/server-error.tcl And, presumably, you have enabletclpages = true. If you

Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Stephen Deasey
Hi, I fixed this bug 6 months ago. There's a patch on SourceForge: Invalid response status logged for custom redirects http://sourceforge.net/tracker/?func=detailaid=1013752group_id=3152atid=103152 You may also be interested in this related patch which alows a custom redirect handler to know

Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Dossy Shiobara
On 2005.02.11, Stephen Deasey [EMAIL PROTECTED] wrote: I fixed this bug 6 months ago. There's a patch on SourceForge: Invalid response status logged for custom redirects http://sourceforge.net/tracker/?func=detailaid=1013752group_id=3152atid=103152 Can you explain this: -

Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Stephen Deasey
On Fri, 11 Feb 2005 15:20:26 -0500, Dossy Shiobara [EMAIL PROTECTED] wrote: Can you explain this: - connPtr-responseStatus = status; +/* 200 is default. Don't stomp custom redirects. */ +if (status != 200) { +connPtr-responseStatus = status;

Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Dossy Shiobara
On 2005.02.11, Stephen Deasey [EMAIL PROTECTED] wrote: Why introduce Ns_ConnSetUrl()? Why not change Ns_SetRequestUrl() to do this? Ns_SetRequestUrl(Ns_Request * request, char *url); Ns_ConnSetUrl(Ns_Conn *conn, char *url); The 'original URL' is a property of the current connection, not

Re: [AOLSERVER] Proposed change to internal redirects behavior

2005-02-11 Thread Stephen Deasey
On Fri, 11 Feb 2005 16:21:49 -0500, Dossy Shiobara [EMAIL PROTECTED] wrote: On 2005.02.11, Stephen Deasey [EMAIL PROTECTED] wrote: Why introduce Ns_ConnSetUrl()? Why not change Ns_SetRequestUrl() to do this? Ns_SetRequestUrl(Ns_Request * request, char *url); Ns_ConnSetUrl(Ns_Conn