Re: Dn/Rdn/Ava refactoring : results

2016-05-09 Thread Radovan Semancik
On 05/09/2016 08:51 PM, Emmanuel Lécharny wrote: The changes are a bit disruptive (although not *that* much), it deserves a new version, and we already discuss that a few weeks ago. I'll probably cut a 1.0.0 release soon. Yes. I remember that. I was just wondering if "soon" has some

Error handling: cursor time out

2016-05-09 Thread Radovan Semancik
Hi, One of our engineers encountered a time-out on an LDAP connection that was not used for some time. The exception occured in org.apache.directory.ldap.client.api.SearchCursorImpl.next(SearchCursorImpl.java:149). This is not a very convenient place to throw an exception, but I can live

Re: Dn/Rdn/Ava refactoring : results

2016-05-09 Thread Radovan Semancik
Hi, Congrats. This looks like a great improvement. But ... it would be probably good to release API 1.0.0 before you merge in the branch. Any plans for that? -- Radovan Semancik Software Architect evolveum.com On 05/09/2016 12:38 PM, Emmanuel Lécharny wrote: Hi ! that's it, I'm done

Re: Dn/Rdn/Ava refactoring : results

2016-05-09 Thread Emmanuel Lécharny
FTR, here are the results for DN parsing when we don't have a SchemaManager : trunk branch Nb secs DN/s Nb secs DN/s Ratio 1 RDN : 5.959 1,678,1345.198 1,923,817 x1.15 2 RDNs : 10.015 998,5028.197 1,219,959 x1.22 3 RDNs : 12.458

Dn/Rdn/Ava refactoring : results

2016-05-09 Thread Emmanuel Lécharny
Hi ! that's it, I'm done with the refactoring. All tests are now passing green, even some that were ignored in trunk (typically things like DN with multiple Avas). I have ran a small test, parsing various DN with 1 to 4 RDNs on trunks and on my branch, here are the results on 10 000 000