[apparmor] [Merge] lp:~sdeziel/apparmor-profiles/ssh-scp-profiles into lp:apparmor-profiles

2014-09-11 Thread Simon Déziel
Simon Déziel has proposed merging lp:~sdeziel/apparmor-profiles/ssh-scp-profiles into lp:apparmor-profiles. Requested reviews: AppArmor Developers (apparmor-dev) For more details, see: https://code.launchpad.net/~sdeziel/apparmor-profiles/ssh-scp-profiles/+merge/234310 Second attempt at

Re: [apparmor] [Merge] lp:~intrigeri/apparmor-profiles/cleanup-pidgin-orcexec into lp:apparmor-profiles

2014-09-11 Thread Simon Déziel
On 09/10/2014 07:09 PM, intrigeri wrote: intrigeri has proposed merging lp:~intrigeri/apparmor-profiles/cleanup-pidgin-orcexec into lp:apparmor-profiles. Requested reviews: simon123 (simon-deziel) I didn't know a previous me created such a user but that's quite possible. My LP is sdeziel

Re: [apparmor] [Merge] lp:~intrigeri/apparmor-profiles/pidgin-vs-wildmidi into lp:apparmor-profiles

2014-09-11 Thread Seth Arnold
While this isn't wrong, I suspect it'd be better to add this (and move some lines from pidgin's profile) into abstractions/audio instead. Thanks -- https://code.launchpad.net/~intrigeri/apparmor-profiles/pidgin-vs-wildmidi/+merge/234211 Your team AppArmor Developers is requested to review the

[apparmor] [Merge] lp:~intrigeri/apparmor/add-wildmidi-cfg-to-audio-abstraction into lp:apparmor

2014-09-11 Thread noreply
The proposal to merge lp:~intrigeri/apparmor/add-wildmidi-cfg-to-audio-abstraction into lp:apparmor has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~intrigeri/apparmor/add-wildmidi-cfg-to-audio-abstraction/+merge/234225 --

Re: [apparmor] [patch] C tools: rename __unused macro

2014-09-11 Thread Christian Boltz
Hello, Am Donnerstag, 11. September 2014 schrieb Steve Beattie: Bug: https://bugzilla.novell.com/show_bug.cgi?id=895495 We define the __unused macro as a shortcut for __attribute__((unused)) to quiet compiler warnings for functions where an argument is unused, for whatever reason. However,

Re: [apparmor] [patch] parser: make flags defintion consistent

2014-09-11 Thread Steve Beattie
On Wed, Sep 03, 2014 at 12:30:18PM -0700, Steve Beattie wrote: In profile.h, flagvals is declared to be class, but then in the Profile class, the flags field declares it as a struct. This patch makes the field declaration type consistent. Signed-off-by: Steve Beattie st...@nxnw.org ---

[apparmor] [patch] parser: fix af_xxxx.o make dependencies

2014-09-11 Thread Steve Beattie
In trunk commit 2615, make targets for af_rule.o and af_unix.o were added. Unfortunately, the af_rule.o target's dependency on rule.h was missing the .h suffix. This patch fixes the issue and adds some other headers that the source file are dependent on. Signed-off-by: Steve Beattie

Re: [apparmor] [patch] parser: fix af_xxxx.o make dependencies

2014-09-11 Thread John Johansen
On 09/11/2014 04:42 PM, Steve Beattie wrote: In trunk commit 2615, make targets for af_rule.o and af_unix.o were added. Unfortunately, the af_rule.o target's dependency on rule.h was missing the .h suffix. This patch fixes the issue and adds some other headers that the source file are

Re: [apparmor] [patch] parser: make flags defintion consistent

2014-09-11 Thread John Johansen
On 09/11/2014 04:04 PM, Steve Beattie wrote: On Wed, Sep 03, 2014 at 12:30:18PM -0700, Steve Beattie wrote: In profile.h, flagvals is declared to be class, but then in the Profile class, the flags field declares it as a struct. This patch makes the field declaration type consistent.

Re: [apparmor] [patch] parser: fix af_xxxx.o make dependencies

2014-09-11 Thread Seth Arnold
On Thu, Sep 11, 2014 at 04:42:59PM -0700, Steve Beattie wrote: In trunk commit 2615, make targets for af_rule.o and af_unix.o were added. Unfortunately, the af_rule.o target's dependency on rule.h was missing the .h suffix. This patch fixes the issue and adds some other headers that the source