Re: [apparmor] Cache update broken

2012-08-08 Thread John Johansen
On 08/08/2012 04:50 AM, Christian Boltz wrote: > Hello, > > Am Dienstag, 7. August 2012 schrieb John Johansen: >> okay attached is v2 of the patch, its changes are: >> >> * makes cache clearing the default behavior if --write-cache is >> enabled > > :-) > >> * changes --no-clear-cache to --skip

Re: [apparmor] Cache update broken

2012-08-08 Thread Jamie Strandboge
On Tue, 2012-08-07 at 15:14 -0700, John Johansen wrote: > On 08/04/2012 06:53 AM, Christian Boltz wrote: > > Hello, > > > okay attached is v2 of the patch, its changes are: > > * makes cache clearing the default behavior if --write-cache is enabled > * changes --no-clear-cache to --skip-bad-cache

Re: [apparmor] Cache update broken

2012-08-08 Thread Christian Boltz
Hello, Am Dienstag, 7. August 2012 schrieb John Johansen: > okay attached is v2 of the patch, its changes are: > > * makes cache clearing the default behavior if --write-cache is > enabled :-) > * changes --no-clear-cache to --skip-bad-cache (really the > same thing but hopefully a better name

Re: [apparmor] Cache update broken

2012-08-07 Thread Christian Boltz
Hello, (I've seen the updated patch and already submitted it to a test package in the OBS in home:cboltz - but I'll comment on this mail nevertheless. Most of the comments below should have a "SCNR" marker - don't take them too serious ;-) Am Dienstag, 7. August 2012 schrieb John Johansen: > O

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/07/2012 03:26 PM, Seth Arnold wrote: > Excellent, it feels much improved despite breaking Christian's Rules. :) > heh, well hopefully this version fixes that > Could you add another monkey test for --purge-cache? > sure > The short option -W leaked into the manpage update. > fixed, thank

Re: [apparmor] Cache update broken

2012-08-07 Thread Seth Arnold
e, 07 Aug 2012 15:14:21 To: Christian Boltz Cc: Subject: Re: [apparmor] Cache update broken On 08/04/2012 06:53 AM, Christian Boltz wrote: > Hello, > okay attached is v2 of the patch, its changes are: * makes cache clearing the default behavior if --write-cache is enabled * changes --no-

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/04/2012 06:53 AM, Christian Boltz wrote: > Hello, > okay attached is v2 of the patch, its changes are: * makes cache clearing the default behavior if --write-cache is enabled * changes --no-clear-cache to --skip-bad-cache (really the same thing but hopefully a better name?) * adds a --pur

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/07/2012 01:34 PM, Christian Boltz wrote: > Hello, > > John, thanks for honoring the golden rules of bad programming in your > patch! I'm especially talking about rule 18 - "take great care in > setting bad defaults" ;-) > Hehe I did it on purpose to get a discussion of what it should be o

Re: [apparmor] Cache update broken

2012-08-07 Thread Christian Boltz
Hello, John, thanks for honoring the golden rules of bad programming in your patch! I'm especially talking about rule 18 - "take great care in setting bad defaults" ;-) Am Dienstag, 7. August 2012 schrieb Seth Arnold: > I expect --clear-cache-if-needed to be the default set in the config > file

Re: [apparmor] Cache update broken

2012-08-07 Thread Seth Arnold
rarely used (hopefully) at that. --Original Message-- From: John Johansen To: Seth Arnold Cc: Christian Boltz Cc: apparmor@lists.ubuntu.com Subject: Re: [apparmor] Cache update broken Sent: Aug 7, 2012 12:33 PM On 08/07/2012 09:58 AM, Seth Arnold wrote: > The patch reads well, though

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/07/2012 09:58 AM, Seth Arnold wrote: > The patch reads well, though the --help needs to indicate that the flag only > works if --write-cache is given _and_the features don't match. > > I would much rather --clear-cache be a debugging tool for sysadmin use that > immediately and directly cl

Re: [apparmor] Cache update broken

2012-08-07 Thread Seth Arnold
mp -s $basedir/cache/$profile || { echo "FAIL"; exit 1; } Thanks John -Original Message- From: John Johansen Sender: apparmor-boun...@lists.ubuntu.com Date: Tue, 07 Aug 2012 09:17:46 To: Christian Boltz Cc: Subject: Re: [apparmor] Cache update broken On 08/04/2012 06:5

Re: [apparmor] Cache update broken

2012-08-07 Thread John Johansen
On 08/04/2012 06:53 AM, Christian Boltz wrote: > Hello, > > I received a bugreport that loading AppArmor needs 25 seconds at boot: > https://bugzilla.novell.com/show_bug.cgi?id=774529 > I can reproduce the problem on my system (AppArmor 2.8.0) > > It looks like the cache is not updated, and (

Re: [apparmor] Cache update broken

2012-08-05 Thread John Johansen
On 08/05/2012 04:41 AM, Christian Boltz wrote: > Hello, > > Am Samstag, 4. August 2012 schrieb Seth Arnold: >> Sounds similar to the thread with Subject: [PATCH 10/11] Fix caching >> when used with a newer kernel with the feature directory > > Indeed - but this patch was commited as r1977 (in a m

Re: [apparmor] Cache update broken

2012-08-05 Thread Christian Boltz
Hello, Am Samstag, 4. August 2012 schrieb Seth Arnold: > Sounds similar to the thread with Subject: [PATCH 10/11] Fix caching > when used with a newer kernel with the feature directory Indeed - but this patch was commited as r1977 (in a modified variant after some discussion), and 2.8.0 (= r2047

Re: [apparmor] Cache update broken

2012-08-04 Thread Seth Arnold
Sounds similar to the thread with Subject: [PATCH 10/11] Fix caching when used with a newer kernel with the feature directory -Original Message- From: Christian Boltz Sender: apparmor-boun...@lists.ubuntu.com Date: Sat, 04 Aug 2012 15:53:50 To: Subject: [apparmor] Cache update broken

[apparmor] Cache update broken

2012-08-04 Thread Christian Boltz
Hello, I received a bugreport that loading AppArmor needs 25 seconds at boot: https://bugzilla.novell.com/show_bug.cgi?id=774529 I can reproduce the problem on my system (AppArmor 2.8.0) It looks like the cache is not updated, and (for obvious reasons) the outdated cache isn't used. # grep