Re: [apparmor] GSoC r13, r14, r15 review

2013-07-09 Thread Christian Boltz
Hello, Am Dienstag, 9. Juli 2013 schrieb Kshitij Gupta: I somehow doubt this is intentional - the test should catch this exception ;-) As it turns this issue has got something to do with the Python3's new feature called Exception Chaining. Its another of those Python2-3 problem. An

[apparmor] GSoC r13, r14, r15 review

2013-07-08 Thread Christian Boltz
Hello, I just reviewed the changes from r13, r14 and r15. See the attached file - I added several inline comments in the diff. Besides that, I got a nice traceback: # python3 severity_test.py E. == ERROR: testInvalid

Re: [apparmor] GSoC r13, r14, r15 review

2013-07-08 Thread Kshitij Gupta
Traceback (most recent call last): File ../apparmor/severity.py, line 76, in __init__ resource, severity = line.split() ValueError: need more than 1 value to unpack During handling of the above exception, another exception occurred: Traceback (most recent call last): File