Re: [apparmor] aa-enabled

On 2015-12-16 08:34:20, John Johansen wrote: > On 12/16/2015 08:13 AM, Tyler Hicks wrote: > > On 2015-12-16 14:07:53, Christian Boltz wrote: > >> Hello, > >> > >> Am Dienstag, 15. Dezember 2015 schrieb Seth Arnold: > >>> On Tue, Dec 15, 2015 at 06:41:48PM -0600, Tyler Hicks wrote: > > +

Re: [apparmor] aa-enabled

Hello, Am Dienstag, 15. Dezember 2015 schrieb Seth Arnold: > On Tue, Dec 15, 2015 at 06:41:48PM -0600, Tyler Hicks wrote: > > > + if (!quiet) { > > > + switch(err) { > > > + case ENOSYS: > > > + printf(_("No - not available on this system.\n")); > > > +

Re: [apparmor] aa-enabled

On 2015-12-16 14:07:53, Christian Boltz wrote: > Hello, > > Am Dienstag, 15. Dezember 2015 schrieb Seth Arnold: > > On Tue, Dec 15, 2015 at 06:41:48PM -0600, Tyler Hicks wrote: > > > > + if (!quiet) { > > > > + switch(err) { > > > > + case ENOSYS: > > > > +

Re: [apparmor] aa-enabled

On 12/16/2015 08:13 AM, Tyler Hicks wrote: > On 2015-12-16 14:07:53, Christian Boltz wrote: >> Hello, >> >> Am Dienstag, 15. Dezember 2015 schrieb Seth Arnold: >>> On Tue, Dec 15, 2015 at 06:41:48PM -0600, Tyler Hicks wrote: > + if (!quiet) { > + switch(err) { > + case

Re: [apparmor] aa-enabled

On Tue, Dec 15, 2015 at 06:41:48PM -0600, Tyler Hicks wrote: > > + if (!quiet) { > > + switch(err) { > > + case ENOSYS: > > + printf(_("No - not available on this system.\n")); > > + break; > > + case ECANCELED: > > +

Re: [apparmor] aa-enabled

John asked that I take a look at this patch in order to see if my proposed aa-exec rewrite in C should use the binutils/ dir proposed by this patch. On 2015-11-28 10:38:34, John Johansen wrote: > v3 > > change conflicting/unknown option warning message slightly > output error string on failure >

Re: [apparmor] aa-enabled

v3 change conflicting/unknown option warning message slightly output error string on failure add binutils dir add manpage add makefile add pot file --- === modified file 'Makefile' --- Makefile2015-01-24 00:01:14 + +++ Makefile2015-11-28 17:33:33 + @@ -11,6 +11,7 @@ DIRS=parser

Re: [apparmor] aa-enabled

Hello, Am Samstag, 28. November 2015 schrieb John Johansen: > v3 > > change conflicting/unknown option warning message slightly > output error string on failure > add binutils dir > add manpage > add makefile > add pot file > === added file 'binutils/Makefile' > --- binutils/Makefile 1970-01-01

Re: [apparmor] aa-enabled

On 11/28/2015 01:30 PM, Christian Boltz wrote: > Hello, > > Am Samstag, 28. November 2015 schrieb John Johansen: >> v3 >> >> change conflicting/unknown option warning message slightly >> output error string on failure >> add binutils dir >> add manpage >> add makefile >> add pot file > >> ===

Re: [apparmor] aa-enabled

On 11/25/2015 01:41 AM, Christian Boltz wrote: > Hello, > > Am Dienstag, 24. November 2015 schrieb John Johansen: >> v3 containing all suggested changes + copyright and ifdef around >> packaging defines for PACKAGE and LOCALEDIR, at least until make file >> packaging can be worked out > > Looks

Re: [apparmor] aa-enabled

Hello, Am Dienstag, 24. November 2015 schrieb John Johansen: > v3 containing all suggested changes + copyright and ifdef around > packaging defines for PACKAGE and LOCALEDIR, at least until make file > packaging can be worked out Looks good, I noticed just some minor details. Feel free to

Re: [apparmor] aa-enabled

Hello, Am Dienstag, 24. November 2015 schrieb John Johansen: > On 11/22/2015 07:20 AM, Christian Boltz wrote: > > To allow a smooth transition, I propose to add a little aa-enabled > > tool to 2.9 and 2.10 which just does > > > > #!/bin/sh > > exec aa-status --enabled > > hrmmm, this

Re: [apparmor] aa-enabled

>> Nice trick - you are using libapparmor to hide most of the code ;-) >> (that's not really bad because it avoids code duplication, but makes the >> comparison a bit unfair ;-) >> >> Oh, and the C code has a bug - like aa-status --enabled, aa-enabled >> should only set the exitcode, but not

Re: [apparmor] aa-enabled

On 11/24/2015 03:03 PM, Christian Boltz wrote: > Hello, > > Am Dienstag, 24. November 2015 schrieb John Johansen: >> On 11/22/2015 07:20 AM, Christian Boltz wrote: >>> To allow a smooth transition, I propose to add a little aa-enabled >>> tool to 2.9 and 2.10 which just does >>> >>> #!/bin/sh

Re: [apparmor] aa-enabled

On Tue, Nov 24, 2015 at 04:14:27PM -0800, John Johansen wrote: > and along those lines, here is a v2 Woo, this is great. main() is missing this bit of code (which I stole from apparmor_parser's parser_main.c): setlocale(LC_MESSAGES, ""); bindtextdomain(PACKAGE, LOCALEDIR);

Re: [apparmor] aa-enabled

On 11/24/2015 08:55 PM, Seth Arnold wrote: > On Tue, Nov 24, 2015 at 04:14:27PM -0800, John Johansen wrote: >> and along those lines, here is a v2 > > Woo, this is great. > > main() is missing this bit of code (which I stole from apparmor_parser's > parser_main.c): > >

Re: [apparmor] aa-enabled

v3 containing all suggested changes + copyright and ifdef around packaging defines for PACKAGE and LOCALEDIR, at least until make file packaging can be worked out --- /* * Copyright (C) 2015 Canonical Ltd. * * This program is free software; you can redistribute it and/or *modify it

Re: [apparmor] aa-enabled

On Tue, Nov 24, 2015 at 09:56:28PM -0800, John Johansen wrote: > v3 containing all suggested changes + copyright and ifdef around packaging > defines for PACKAGE and LOCALEDIR, at least until make file packaging can > be worked out I like it: Acked-by: Seth Arnold

[apparmor] aa-enabled

Hello, aa-status --enabled (and only --enabled AFAIK) is used in dh_apparmor, which means we have to keep the dependencies as small as possible, especially "import apparmor.$something". Needless to say that this makes improving aa-status quite difficult. We discussed splitting off an