On Fri, Apr 13, 2018 at 11:22:11AM -0700, Matthew Garrett wrote:
> +int aa_audit_rule_init(u32 field, u32 op, char *rulestr, void **vrule)
> +{
> + struct aa_audit_rule *rule;
> +
> + switch (field) {
> + case AUDIT_SUBJ_ROLE:
> + if (op != Audit_equal && op != Audit_not_equal)
> + return -EINVAL;
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + rule = kzalloc(sizeof(struct aa_audit_rule), GFP_KERNEL);
> +
> + if (!rule)
> + return -ENOMEM;
> +
> + rule->profile = kstrdup(rulestr, GFP_KERNEL);Hi Matthew, if this allocation fails, 'rule' is returned malformed; is this intentional? > + *vrule = rule; > + > + return 0; > +} Thanks
signature.asc
Description: PGP signature
-- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
