[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Friday, February 22, 2019 @ 13:47:18 Author: archange Revision: 435191 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 435190, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 435190, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +-- PKGBUILD | 74 ++-- 2 files changed, 73 insertions(+), 73 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2019-02-22 13:47:10 UTC (rev 435190) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2019-02-22 13:47:18 UTC (rev 435191) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= - -Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 435190, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2019-02-22 13:47:18 UTC (rev 435191) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); +-- +2.17.0 + Deleted: PKGBUILD
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Monday, February 4, 2019 @ 14:40:59 Author: archange Revision: 429580 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 429579, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 429579, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +- PKGBUILD | 80 +--- 2 files changed, 73 insertions(+), 79 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2019-02-04 14:40:49 UTC (rev 429579) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2019-02-04 14:40:59 UTC (rev 429580) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= - -Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 429579, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2019-02-04 14:40:59 UTC (rev 429580) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); +-- +2.17.0 + Deleted: PKGBUILD
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Friday, August 3, 2018 @ 09:56:41 Author: zorun Revision: 367515 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 367514, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 367514, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +- PKGBUILD | 86 ++-- 2 files changed, 79 insertions(+), 79 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-08-03 09:56:31 UTC (rev 367514) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-08-03 09:56:41 UTC (rev 367515) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= - -Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 367514, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-08-03 09:56:41 UTC (rev 367515) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); +-- +2.17.0 + Deleted: PKGBUILD
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Saturday, July 21, 2018 @ 11:41:15 Author: zorun Revision: 362699 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 362698, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 362698, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +- PKGBUILD | 86 ++-- 2 files changed, 79 insertions(+), 79 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-07-21 11:41:04 UTC (rev 362698) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-07-21 11:41:15 UTC (rev 362699) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= - -Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 362698, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-07-21 11:41:15 UTC (rev 362699) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); +-- +2.17.0 + Deleted: PKGBUILD
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Friday, June 29, 2018 @ 21:00:12 Author: zorun Revision: 347784 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 347783, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 347783, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +- PKGBUILD | 86 ++-- 2 files changed, 79 insertions(+), 79 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-06-29 21:00:02 UTC (rev 347783) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-06-29 21:00:12 UTC (rev 347784) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= - -Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 347783, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-06-29 21:00:12 UTC (rev 347784) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); +-- +2.17.0 + Deleted: PKGBUILD
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Friday, June 15, 2018 @ 06:32:34 Author: zorun Revision: 343281 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 343280, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 343280, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +- PKGBUILD | 86 ++-- 2 files changed, 79 insertions(+), 79 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-06-15 06:32:23 UTC (rev 343280) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-06-15 06:32:34 UTC (rev 343281) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= - -Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 343280, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-06-15 06:32:34 UTC (rev 343281) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); +-- +2.17.0 + Deleted: PKGBUILD
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Friday, May 25, 2018 @ 08:18:09 Author: zorun Revision: 329341 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 329340, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 329340, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +- PKGBUILD | 86 ++-- 2 files changed, 79 insertions(+), 79 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-05-25 08:16:34 UTC (rev 329340) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-05-25 08:18:09 UTC (rev 329341) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= --Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 329340, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-05-25 08:18:09 UTC (rev 329341) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings,
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Thursday, May 3, 2018 @ 23:05:29 Author: zorun Revision: 318916 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 318915, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 318915, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +- PKGBUILD | 86 ++-- 2 files changed, 79 insertions(+), 79 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-05-03 23:05:15 UTC (rev 318915) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-05-03 23:05:29 UTC (rev 318916) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= --Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 318915, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-05-03 23:05:29 UTC (rev 318916) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings,
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Saturday, April 28, 2018 @ 07:47:39 Author: zorun Revision: 318342 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 318341, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 318341, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 +- PKGBUILD | 86 ++-- 2 files changed, 79 insertions(+), 79 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-28 07:47:30 UTC (rev 318341) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-28 07:47:39 UTC (rev 318342) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= --Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 318341, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-28 07:47:39 UTC (rev 318342) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings,
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Thursday, April 26, 2018 @ 14:55:38 Author: bgyorgy Revision: 318161 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 318160, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 318160, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 - PKGBUILD | 87 +--- 2 files changed, 79 insertions(+), 80 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-26 14:55:33 UTC (rev 318160) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-26 14:55:38 UTC (rev 318161) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= --Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 318160, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-26 14:55:38 UTC (rev 318161) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings,
[arch-commits] Commit in ring-gnome/repos/community-x86_64 (4 files)
Date: Saturday, April 21, 2018 @ 20:33:51 Author: zorun Revision: 317266 archrelease: copy trunk to community-x86_64 Added: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 317265, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) ring-gnome/repos/community-x86_64/PKGBUILD (from rev 317265, ring-gnome/trunk/PKGBUILD) Deleted: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch ring-gnome/repos/community-x86_64/PKGBUILD ---+ 0001-settings-check-if-g_get_user_special_dir-fails.patch | 72 - PKGBUILD | 88 ++-- 2 files changed, 80 insertions(+), 80 deletions(-) Deleted: 0001-settings-check-if-g_get_user_special_dir-fails.patch === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-21 20:33:40 UTC (rev 317265) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-21 20:33:51 UTC (rev 317266) @@ -1,36 +0,0 @@ -From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?S=C3=A9bastien=20Blin?= --Date: Tue, 17 Apr 2018 09:47:47 -0400 -Subject: [PATCH] settings: check if g_get_user_special_dir fails - -g_get_user_special_dir can return a nullptr, so the string -construction will fails badly. Must be checked or fallback to -G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) - -Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 -Reviewed-by: Philippe Gorley - src/generalsettingsview.cpp | 6 +- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp -index 4c6a15a..4fa2d9c 100644 a/src/generalsettingsview.cpp -+++ b/src/generalsettingsview.cpp -@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) - auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); - char* download_directory_value; - g_variant_get(download_directory_variant, "", _directory_value); --std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); -+std::string default_download_dir = {}; -+if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) -+default_download_dir = directory; -+else -+default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); - auto current_value = std::string(download_directory_value); - if (current_value.empty()) { - g_settings_set_value(priv->settings, "download-folder", g_variant_new("s", default_download_dir.c_str())); --- -2.17.0 - Copied: ring-gnome/repos/community-x86_64/0001-settings-check-if-g_get_user_special_dir-fails.patch (from rev 317265, ring-gnome/trunk/0001-settings-check-if-g_get_user_special_dir-fails.patch) === --- 0001-settings-check-if-g_get_user_special_dir-fails.patch (rev 0) +++ 0001-settings-check-if-g_get_user_special_dir-fails.patch 2018-04-21 20:33:51 UTC (rev 317266) @@ -0,0 +1,36 @@ +From 1946b536d75fc47f16bf3accb9b18c98145280b1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?S=C3=A9bastien=20Blin?= + +Date: Tue, 17 Apr 2018 09:47:47 -0400 +Subject: [PATCH] settings: check if g_get_user_special_dir fails + +g_get_user_special_dir can return a nullptr, so the string +construction will fails badly. Must be checked or fallback to +G_USER_DIRECTORY_DESKTOP ($HOME/Desktop) + +Change-Id: I04b72221f14091db2cfd880a9b35b8ab92e46ae4 +Reviewed-by: Philippe Gorley +--- + src/generalsettingsview.cpp | 6 +- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +index 4c6a15a..4fa2d9c 100644 +--- a/src/generalsettingsview.cpp b/src/generalsettingsview.cpp +@@ -248,7 +248,11 @@ general_settings_view_init(GeneralSettingsView *self) + auto* download_directory_variant = g_settings_get_value(priv->settings, "download-folder"); + char* download_directory_value; + g_variant_get(download_directory_variant, "", _directory_value); +-std::string default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD); ++std::string default_download_dir = {}; ++if (auto* directory = g_get_user_special_dir (G_USER_DIRECTORY_DOWNLOAD)) ++default_download_dir = directory; ++else ++default_download_dir = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP); + auto current_value = std::string(download_directory_value); + if (current_value.empty()) { + g_settings_set_value(priv->settings,