Re: [arch-projects] [devtools] [PATCH 3/8] arch-nspawn: usage(): Style improvement: two spaces after a period.

On Sun, Apr 2, 2017 at 2:08 PM Dave Reisner wrote: > On Sun, Apr 02, 2017 at 04:09:57AM -0400, luke...@lukeshu.com wrote: > > From: Luke Shumaker > > > > --- > > If you want to change this, I have no strong feelings one way or the > other, but this is

Re: [arch-projects] [devtools] [PATCH 3/8] arch-nspawn: usage(): Style improvement: two spaces after a period.

On Sun, Apr 02, 2017 at 04:09:57AM -0400, luke...@lukeshu.com wrote: > From: Luke Shumaker > > --- If you want to change this, I have no strong feelings one way or the other, but this is only a small part of what would need to be done. See the usage messages makechrootpkg,

[arch-projects] [devtools] [PATCH 7/8] lib/common.sh: Adjust to work properly with `set -u`.

From: Luke Shumaker --- lib/common.sh | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/common.sh b/lib/common.sh index 19aa7de..4536668 100644 --- a/lib/common.sh +++ b/lib/common.sh @@ -1,4 +1,5 @@ #!/hint/bash +# This may be included with or

[arch-projects] [devtools] [PATCH 4/8] makechrootpkg: /chrootbuild: accept makepkg_args as arguments rather than embedding.

From: Luke Shumaker --- makechrootpkg.in | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/makechrootpkg.in b/makechrootpkg.in index 31d57d3..9566b2e 100644 --- a/makechrootpkg.in +++ b/makechrootpkg.in @@ -190,9 +190,7 @@ EOF {

[arch-projects] [devtools] [PATCH 8/8] lib/common.sh: Make it safe to include multiple times.

From: Luke Shumaker This is similar to common C #ifdef guards. I was tempted to wrap the entire thing in the if/fi, rather than use 'return' to bail early. However, that means it won't execute anything until after it reaches 'fi'. And if `shopt -s extglob` isn't executed

[arch-projects] [devtools] [PATCH 5/8] makechrootpkg: Quote directory passed to `rm -rf`.

From: Luke Shumaker --- makechrootpkg.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/makechrootpkg.in b/makechrootpkg.in index 9566b2e..774ebcf 100644 --- a/makechrootpkg.in +++ b/makechrootpkg.in @@ -231,7 +231,7 @@ download_sources() { ((

[arch-projects] [devtools] Minor fix, and cleanups from Parabola

Hi, Here's another batch of changes backported from Parabola's version of devtools. These changes should be pretty uncontroversial. This patchset applies cleanly if applied over the patchsets I've already submitted. It shouldn't be any real trouble to apply them without applying the previous

[arch-projects] [devtools] [PATCH 6/8] makechrootpkg: install_pkg was an unused variable

From: Luke Shumaker --- makechrootpkg.in | 1 - 1 file changed, 1 deletion(-) diff --git a/makechrootpkg.in b/makechrootpkg.in index 774ebcf..0650f2d 100644 --- a/makechrootpkg.in +++ b/makechrootpkg.in @@ -20,7 +20,6 @@ makepkg_args=("${default_makepkg_args[@]}")

[arch-projects] [devtools] [PATCH 2/8] makechrootpkg: usage(): Display the actual default makepkg flags.

From: Luke Shumaker It was displaing the value of the `makepkg_args` variable, which may have already been changed by the argument parsing by the time it gets to `-h`. Now there is a separate `default_makepkg_args` variable. --- makechrootpkg.in | 5 +++-- 1 file changed,