Re: [arch-projects] [namcap] [PATCH 4/5] README: Document how to submit patches

2020-01-21 Thread Vladimir Panteleev
Artur Juraszek writes: > Vladimir Panteleev writes: > >> +git config format.subjectprefix namcap] [PATCH' > > Looks like a typo, I believe it is? Oops, yes, I missed a '. If that's the only problem, please add it before committing, I'll fix it in v2 otherwise.

Re: [arch-projects] [namcap] [PATCH 5/5] Fix shebangdepends rule for programs found in noncanonical locations

2020-01-21 Thread Vladimir Panteleev
Eli Schwartz writes: > FWIW a lot of software will break if you do this, not just namcap. > There's an exceedingly good reason why /usr/sbin and other symlink > directories are *not* added to the $PATH on archlinux, unless the user > has unwisely added it by hand. FWIW, in my case I added it to

[arch-projects] [namcap] [PATCH 4/5] README: Document how to submit patches

2020-01-17 Thread Vladimir Panteleev
--- README | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/README b/README index 83b406b..b018466 100644 --- a/README +++ b/README @@ -21,8 +21,14 @@ Minimal examples (very simple packages forged to exhibit unexpected behaviour from namcap) are also welcome to exte

[arch-projects] [namcap] [PATCH 5/5] Fix shebangdepends rule for programs found in noncanonical locations

2020-01-17 Thread Vladimir Panteleev
If the user has a non-canonical (i.e. symlinked on Arch) location in front of their $PATH, such as /usr/sbin, shutil.which will return locations with that path. This later causes the rule to fail to find the binary in any packages, causing spurious library-no-package-associated and dependency-not-n

[arch-projects] [namcap] [PATCH 3/5] README: Document how to run the test suite

2020-01-17 Thread Vladimir Panteleev
--- README | 10 ++ 1 file changed, 10 insertions(+) diff --git a/README b/README index c90315e..83b406b 100644 --- a/README +++ b/README @@ -141,6 +141,16 @@ warnings we are expecting from the rules. The test suite is in Namcap/tests. The makepkg and pkgbuild_test submodules provide ea

[arch-projects] [namcap] [PATCH 2/5] namcap-devel: Allow running from any directory

2020-01-17 Thread Vladimir Panteleev
--- namcap-devel | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/namcap-devel b/namcap-devel index bdb94df..5b88fe3 100755 --- a/namcap-devel +++ b/namcap-devel @@ -1,9 +1,8 @@ #!/bin/sh -PATH="$(pwd):$PATH" -PARSE_PKGBUILD_PATH="$(pwd)" -export PARSE_PKGBUILD_PATH

[arch-projects] [namcap] [PATCH 1/5] namcap-devel: Quote arguments

2020-01-17 Thread Vladimir Panteleev
--- namcap-devel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/namcap-devel b/namcap-devel index 8619a67..bdb94df 100755 --- a/namcap-devel +++ b/namcap-devel @@ -6,4 +6,4 @@ export PARSE_PKGBUILD_PATH PYTHONPATH="$(pwd)" export PYTHONPATH -./namcap -t namcap-tags $@ +./n