Re: [arch-projects] [devtools] [PATCH 1/2] makechrootpkg: Fix unconditionally running namcap

2017-09-16 Thread Luke Shumaker
On Sun, 03 Sep 2017 03:12:19 -0400, Eli Schwartz wrote: > > But also, I don't think that it's a bad idea to slowly get rid of > > global variables in programs (of course in Bash it's not quite a good > > distinction because it's dynamically scoped instead of lexically > > scoped, and even if it's

Re: [arch-projects] [devtools] [PATCH 1/2] makechrootpkg: Fix unconditionally running namcap

2017-09-03 Thread Eli Schwartz
On 09/01/2017 11:34 PM, Luke Shumaker wrote: > Are you sure it was there? Looking at the code (but without actually > testing it) (and being the one responsible for the bug), I think it > was actually in 2fd5931a8c67289a8a4acd327b3ce99a5d64c8c7. > > Maybe `git blame` told you the erroneous line

Re: [arch-projects] [devtools] [PATCH 1/2] makechrootpkg: Fix unconditionally running namcap

2017-09-01 Thread Luke Shumaker
On Fri, 01 Sep 2017 18:53:12 -0400, Eli Schwartz wrote: > Fixes regression in 49088b0860276c664933c2b3e36a2fef714b7a07 Are you sure it was there? Looking at the code (but without actually testing it) (and being the one responsible for the bug), I think it was actually in

[arch-projects] [devtools] [PATCH 1/2] makechrootpkg: Fix unconditionally running namcap

2017-09-01 Thread Eli Schwartz
Fixes regression in 49088b0860276c664933c2b3e36a2fef714b7a07 $run_namcap will always be set to "" `if $not_a_var; then ...; fi` is always truthful when $not_a_var is unset or equal to "" and the `then` clause will always be run. I'm not entirely sure why everything had to be moved into functions