On Thu, 14 Sep 2017 17:34:11 -0400,
Jan Steffens wrote:
> makechrootpkg: Reopen console to assign the CTTY
>
> nspawn does not give us a controlling terminal, hence we ignore
> interrupts. Apparently this was lost in systemd at some point.
>
> Hack around this by
On Sat, Sep 16, 2017 at 11:23 PM Luke Shumaker wrote:
> On Thu, 14 Sep 2017 17:34:11 -0400,
> Jan Steffens wrote:
> > makechrootpkg: Reopen console to assign the CTTY
> >
> > nspawn does not give us a controlling terminal, hence we ignore
> > interrupts.
A couple of the comments noting which globals are used by functions are
outdated/wrong.
- download_sources() : Remove USER from the list. It was always wrong.
Originally, it should have been SUDO_USER (not USER), but I should have
removed it entirely in 4f23609.
- move_products() : Add
The reason it wasn't moved before was just to keep the diffs
(with --ignore-all-space) smaller, to make merging and rebasing work
easier. Moving code around in a file tends to make that difficult.
But, readability wise, it belongs in main().
---
makechrootpkg.in | 44
Eli seems miffed that init_variables() is a separate function from
main(), so fix that.
Luke Shumaker (1):
makechrootpkg: move init_variables() to be part of main()
makechrootpkg.in | 44
1 file changed, 20 insertions(+), 24 deletions(-)
--
On Sun, 03 Sep 2017 03:12:19 -0400,
Eli Schwartz wrote:
> > But also, I don't think that it's a bad idea to slowly get rid of
> > global variables in programs (of course in Bash it's not quite a good
> > distinction because it's dynamically scoped instead of lexically
> > scoped, and even if it's