Re: [arch-projects] [dbscripts] [PATCH v2 2/3] test: Fixup glob matching

2018-02-25 Thread Eli Schwartz via arch-projects
On 02/22/2018 09:15 PM, Luke Shumaker wrote: > - common.bash: Globbing happens on the RHS of a [[ = ]] test. >This means that we must quote variables on the RHS that are to be taken >verbatim. This is surprising, because we don't need to quote the LHS. Unless we intend to do a general

[arch-projects] [dbscripts] [PATCH v2 2/3] test: Fixup glob matching

2018-02-22 Thread Luke Shumaker
From: Luke Shumaker - ftpdir-cleanup.bats: Glob expansion does not occur in [[ -f ]] tests. The [[ ! -f .../${pkgname}-*${PKGEXT} ]] checks were checking that there were no files containing a literal '*' for that part of their name. Obviously, this isn't what was