Re: [arch-projects] [netctl] [PATCH] wifi-menu: Support UTF-8 encoded SSIDs (FS#45384)
On 26 June 2018 at 11:34, Jouke Witteveen wrote: > On Tue, Jun 26, 2018 at 12:17 PM Emil Velikov > wrote: >> On 23 June 2018 at 12:25, Jouke Witteveen via arch-projects >> wrote: >> > Strictly speaking, we should check with the SSIDEncoding value sent out >> > by the station, as specified in the 2012 version of 802.11 (page 566), >> > but wpa_supplicant does not (yet) expose this information and stations >> > may not set the field to UTF-8 and still encode their SSID accordingly. >> > >> I wonder if iwd (meant to be wpa_supplicant replacement) could help here. >> Be that by exposing SSIDEncoding or setting it, as it detects UTF-8 in the >> SSID. > > As far as I can tell, only developers of iwd think of iwd as a > wpa_supplicant replacement. Currently, it is lacking a CLI and > documentation. Moreover, wpa_supplicant is tried and tested. While I > try to not tie netctl in too strongly with any specific client, > wpa_supplicant will likely be the client of choice for netctl for the > foreseeable future. > I've noticed the iwctl and iwmon utils provided, although did not play around with them. You're on point though, sticking with wpa_supplicant for the foreseeable future is fine. > I submitted a patch to wpa_supplicant for exposing the UTF-8 SSID bit: > http://lists.infradead.org/pipermail/hostap/2018-June/038658.html > However, experimentation showed that it is not really used (yet?). > Vendors may start using it... one day Thanks again for the comprehensive answers! Emil
Re: [arch-projects] [netctl] [PATCH] wifi-menu: Support UTF-8 encoded SSIDs (FS#45384)
Hi Jouke,
Thanks for fixing this!
Sharing a couple of ideas that come to mind.
On 23 June 2018 at 12:25, Jouke Witteveen via arch-projects
wrote:
> Strictly speaking, we should check with the SSIDEncoding value sent out
> by the station, as specified in the 2012 version of 802.11 (page 566),
> but wpa_supplicant does not (yet) expose this information and stations
> may not set the field to UTF-8 and still encode their SSID accordingly.
>
I wonder if iwd (meant to be wpa_supplicant replacement) could help here.
Be that by exposing SSIDEncoding or setting it, as it detects UTF-8 in the SSID.
> @@ -38,6 +43,9 @@ init_profiles() {
> unset Interface ESSID
> source "$PROFILE_DIR/$profile" > /dev/null
> if [[ "$Interface" = "$1" && -n "$ESSID" ]]; then
> +if [[ "$ESSID" = \"\"*\" ]]; then
> +ESSID=${ESSID:2:-1}
> +fi
FYI, I will send out a small patch which simplifying init_profiles.
It will cause a trivial conflict so I can rebase it on top of this
patch, if you prefer.
> @@ -221,6 +237,8 @@ ensure_root "$(basename "$0")"
> if ! type dialog &> /dev/null; then
> exit_error "Please install 'dialog' to use wifi-menu"
> fi
> +CHARMAP=$(locale charmap)
> +cd / # We do not want to spawn anything that can block unmounting
>
Was the "cd /" line moved by mistake?
Other than the cd nitpick, the patch looks great. FWIW
Reviewed-by: Emil Velikov
HTH
Emil
