Re: [Architecture] SAML Artifact Binding - Server Side Implementations

2018-07-11 Thread Vihanga Liyanage
Hi all, I have completed basic flow with SAML2 artifact binding and sent a PR [1] . Now we have the following points to decide on. 1. Issued SAML2 artifacts should have a shortest practical time limit which an artifact

Re: [Architecture] [APIM] REST API Support for Dynamic SSL Certificate Installation Feature.

2018-07-11 Thread Menaka Jayawardena
Hi, I had an offline discussion with Sanjeewa and Malintha regarding the rest API convention of using uuid instead of certificate alias. But, for this feature, if we adopt the UUID approach, there will be a DB level modification and method signature changes. In the current approach, the

Re: [Architecture] Implementing Identifier first in authentication flow

2018-07-11 Thread Malithi Edirisinghe
Hi Maduranga, The 'onSkip' in 'promptIdentifierForStep' looks confusing. The very fist impression that I got while looking at that call back was that it denotes what needs to be executed when prompting for the identifier is skipped. But, as I understood over the discussions, the intention of

Re: [Architecture] Implementing Identifier first in authentication flow

2018-07-11 Thread Maduranga Siriwardena
After having some discussions about the current behavior, we decided below changes. - For executeStep function, we have renamed the the new callback onChangeUser to onUserAbort which will be invoked when “Not ? Login as a different user” link is clicked. - We have added new