Re: [Architecture] [APIM] Sending Custom headers to Websocket back ends.

2018-07-05 Thread Kevin Ratnasekera
Menaka and myself had offline review on PR[1] and now it s merged. [1] https://github.com/wso2/carbon-mediation/pull/1068 Regards Kevin On Fri, Jun 29, 2018 at 11:05 PM, Menaka Jayawardena wrote: > Hi Harsha, > > We discussed this in the code review as well. But, the issue is, the only > way

Re: [Architecture] [APIM] Sending Custom headers to Websocket back ends.

2018-06-29 Thread Menaka Jayawardena
Hi Harsha, We discussed this in the code review as well. But, the issue is, the only way to pass any additional information in websocket handshake is as headers. When the request is forwarded to the websocket transport layer, all these headers are added to the axis2 message context as properties.

Re: [Architecture] [APIM] Sending Custom headers to Websocket back ends.

2018-06-29 Thread Harsha Kumara
On Fri, Jun 29, 2018 at 8:10 PM Menaka Jayawardena wrote: > Hi Harsha, Chamin, > > Please find my answers inline. > > So this means we are having two ways of handling JWT (normal method and >> WS specific method) scenarios? If so, we will need additional methods to >> cover this flow. Will there

Re: [Architecture] [APIM] Sending Custom headers to Websocket back ends.

2018-06-29 Thread Menaka Jayawardena
Hi Harsha, Chamin, Please find my answers inline. So this means we are having two ways of handling JWT (normal method and WS > specific method) scenarios? If so, we will need additional methods to cover > this flow. Will there be a code/logic duplication due to this? > No. In this

Re: [Architecture] [APIM] Sending Custom headers to Websocket back ends.

2018-06-29 Thread Harsha Kumara
On Fri, Jun 29, 2018 at 11:25 AM Menaka Jayawardena wrote: > Hi, > > > *With reference to [RRT][APIM] Code Review - Sending Enduser information > to WS Backends and based on the offline discussion with Kevin.* > > *Initial Requirement:* When the JWT token generation is enabled in API > Manager,

Re: [Architecture] [APIM] Sending Custom headers to Websocket back ends.

2018-06-29 Thread Chamin Dias
Hi, On Fri, Jun 29, 2018 at 11:25 AM, Menaka Jayawardena wrote: > Hi, > > > *With reference to [RRT][APIM] Code Review - Sending Enduser information > to WS Backends and based on the offline discussion with Kevin.* > > *Initial Requirement:* When the JWT token generation is enabled in API >

[Architecture] [APIM] Sending Custom headers to Websocket back ends.

2018-06-28 Thread Menaka Jayawardena
Hi, *With reference to [RRT][APIM] Code Review - Sending Enduser information to WS Backends and based on the offline discussion with Kevin.* *Initial Requirement:* When the JWT token generation is enabled in API Manager, the jwt token should be sent to the Web socket backend. *Current