Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-15 Thread Dushan Silva
Hi Frank, You can find the full swagger file along with the above changes here [1] [1] - https://github.com/dushansilva/carbon-apimgt/blob/dushan-master/components/apimgt/org.wso2.carbon.apimgt.rest.api.store.v1/src/main/resources/store-api.yaml#L3180 Thanks On Thu, Aug 15, 2019 at 3:00 PM

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-15 Thread Frank Leymann
Hi Dushan, I can't find the complete Swagger file. Would you please provide a link? Thanks! Best regards, Frank Am Mo., 12. Aug. 2019 um 16:22 Uhr schrieb Dushan Silva : > Hi all, > As per above suggestions i have updated the swagger. I have added state as > a query param. @Malintha

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-15 Thread Dushan Silva
Noted On Tue, 13 Aug 2019, 4:12 am Ishara Cooray, wrote: > Hi Dushan, > > *'/tenants':* > > *#* > > * # Retrieve all active tenants* > > * #* > > *get:* > > *security:* > >

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-12 Thread Dushan Silva
Hi all, As per above suggestions i have updated the swagger. I have added state as a query param. @Malintha Amarasinghe I have set the state param required as false, so by default if no parameter is passed we can return the active tenants and if someone requires to do it he can pass the

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-12 Thread Malintha Amarasinghe
As Sanjeewa pointed out, I also think we should support pagination related parameters; eg: "count", "limit", "offset", "next", "previous", "total"; where the total is the number of total "active" tenants in the system. On Mon, Aug 12, 2019 at 6:54 PM Malintha Amarasinghe wrote: > > > On Mon,

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-12 Thread Malintha Amarasinghe
On Mon, Aug 12, 2019 at 6:38 PM Malintha Amarasinghe wrote: > > > On Mon, Aug 12, 2019 at 6:17 PM Nuwan Dias wrote: > >> Ideally we would need to support getting all tenants. But for now I think >> its ok to support the active state only. Using the query param to pass in >> the state gives us

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-12 Thread Malintha Amarasinghe
On Mon, Aug 12, 2019 at 6:17 PM Nuwan Dias wrote: > Ideally we would need to support getting all tenants. But for now I think > its ok to support the active state only. Using the query param to pass in > the state gives us the flexibility to support other (inactive) states in > the future. > > I

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-12 Thread Nuwan Dias
Ideally we would need to support getting all tenants. But for now I think its ok to support the active state only. Using the query param to pass in the state gives us the flexibility to support other (inactive) states in the future. Regarding the other tenant specific APIs, I don't see a need to

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-12 Thread Dushan Silva
Hi all, *Few clarifications* We decide to write this rest endpoint to retrieve active-tenants, In addition to this is there a requirement where we would need to get inactive tenants ? what @Thilini Shanika said makes senses its better if we can retrieve some important information such as

Re: [Architecture] [APIM-3.0] Store REST API to get all active tenants

2019-08-12 Thread Dushan Silva
adding architecture On Mon, Aug 12, 2019 at 5:34 PM Sanjeewa Malalgoda wrote: > Yes, Nuwan is correct here. State is filter criteria and using query > parameters is recommended. Also when we fetching this sort of resources its > always good to have a way to limit and paginate number of results