Re: [Architecture] Review of the "primary schema" wiki page...

2017-04-14 Thread Antranig Basman
Thanks for these very helpful suggestions. It is great to have our use of JSON schema reviewed for compliance with the developments in it since we originally based our work on it in 2011. I should note that the use of propert names containing periods such as "fluid.prefs.textSize" or

Re: [Architecture] node_modules

2017-07-05 Thread Antranig Basman
Yes, that is what I meant - sorry for the confusion. On 05/07/2017 17:23, Tony Atkins wrote: > Hi, Antranig. > > I assume you meant that /fluid.require("%universal")/ would solve the > problem? > > Cheers, > > > Tony > > On Wed, Jul 5, 2017

Re: [Architecture] node_modules

2017-07-05 Thread Antranig Basman
Cheers for the question, Gio. As of the merge of https://github.com/GPII/universal/pull/487 fixing GPII-2151, it *should* have been the case that all test cases will run properly regardless of the position of the checkout. They did at the time of the merge - but with the universal truth that

Re: [Architecture] Standardizing environment variable names

2017-05-23 Thread Antranig Basman
+1 - I further propose we prefix them with GPII_ to make responsible use of this OS-wide shared space of names. GPII_PREFERENCES_SERVER_PORT? This corresponds more closely with our use of global names within JavaScript processes. On 23/05/2017 17:23, Gill, Avtar wrote: +1 for prefixing

[Architecture] Feedback on PCP API section 5

2017-06-05 Thread Antranig Basman
As requested by Javi, here is some feedback on section 5 of our current draft PCP API, currently held in the wiki at https://wiki.gpii.net/w/Personal_Control_Panel_API#The_PCP_API_.28or_messaging_protocol.29 i) We need to explain what protocol this API actually operates over. I get the

Re: [Architecture] GPII Windows code linting

2017-10-16 Thread Antranig Basman
Thanks, Alfredo, that's brilliant, and really helpful! Cheers, Antranig On 16/10/2017 10:24, Alfredo Matas wrote: Hi all, I've added a job to the CI task list that runs the "grunt lint" command over the source code as we talked at our last Windows meeting. A sample of the output is

[Architecture] Updated, simplified PCP API

2017-10-02 Thread Antranig Basman
I've updated my pull request at https://github.com/GPII/universal/pull/549 to incorporate a further simplified version of the PCP API, which is more closely focused on the needs of the UI. This now encodes the model state corresponding to the settings widgets directly rather than this

[Architecture] GPII electron app merged into master

2017-10-08 Thread Antranig Basman
Michelle's long-running work in developing the GPII electron app (I'm aware that the term "GPII app" has been deprecated for use in the wider community, but I am using the term in a specific technical sense which is meaningful to developers) at https://github.com/GPII/gpii-app/pull/17 has been

[Architecture] OAuth2 Resource Owner Credentials work merged into core

2017-10-12 Thread Antranig Basman
Continue with our run of integrating major work, I'm pleased to report that Cindy's significant pull request https://github.com/GPII/universal/pull/519 for https://issues.gpii.net/browse/GPII-2434 (GPII-2435) has been merged into master today. This implements the central engine and OAuth

[Architecture] Glorious Merge

2017-11-28 Thread Antranig Basman
I'm very happy to report that Kaspar's branch pull https://github.com/GPII/universal/pull/561 for GPII-2655 is now gloriously merged, marking the near-endpoint of a long process of normalising our architecture. Most crucially this provides core architectural support for Astea's excellent PSP

[Architecture] Congratulations to Cindy

2018-05-16 Thread Antranig Basman
Congratulations to Cindy on the merge this evening of her long-term work on the new GPII Data Model described by GPII-2630, and the annotated schema written up in the wiki at https://wiki.gpii.net/w/Keys,_KeyTokens,_and_Preferences . This represents over 6 months of careful, patient and skilled

[Architecture] Nominating Steve Grundell for commit access

2018-06-08 Thread Antranig Basman
I would like to nominate Steve Grundell of RtF-I for commit access to the GPII repositories (https://github.com/GPII). The procedures and responsibilities for this are listed on this page: http://wiki.gpii.net/w/GPII_Technical_Governance#Process_for_Granting_Commit_Access Steve's work over

[Architecture] Congrats and Thanks to Javi

2018-08-07 Thread Antranig Basman
As his victorious email sent amongst the team last night shows, Javi has been up essentially through the whole night labouring to get the first version of the installer ready for testing ahead of our demo later in the month. This has been a herculean effort weaving together more than a dozen

[Architecture] Fwd: Re: Discovered another bug

2018-07-16 Thread Antranig Basman
Forwarded Message Subject:Re: [Architecture] Discovered another bug Date: Mon, 16 Jul 2018 00:36:12 -0400 From: Gregg Vanderheiden GPII To: Antranig Basman CC: Kavya Komuru , Sandra Ellett-Salmoran I was using the Microsoft  build I think let me

Re: [Architecture] Discovered another bug

2018-07-15 Thread Antranig Basman
Cheers Gregg - I've written up this report as https://issues.gpii.net/browse/GPII-3208 . There has been a new behaviour implemented in the system recently (combination of Kaspar's last work and a new close handler from Steve Grundell) which is intended to handle this situation robustly. The

[Architecture] Vindication of our policy for exact dependency versions

2018-07-13 Thread Antranig Basman
Our project policy has for some time been to only permit exact versions to appear in project dependencies listed in package.json - this is at odds with most industry recommendations, and also the action of several automated tools, to allow open semver ranges of the form "~3.7.1". As it turns

[Architecture] Another Glorious Merge

2018-03-12 Thread Antranig Basman
Dear All - This is to report another important milestone in improving our quality infrastructure. This evening another significant branch has been merged, itself representing more than 6 months work by Tony Atkins but building on yet more work implementing similar capabilities for Infusion

Re: [Architecture] Proposal for using JSON schemas in combination with i18n message keys...

2018-03-26 Thread Antranig Basman
Thanks for putting this together, I will spend some time reading it. Unfortunately I won't be able to make our slot tomorrow but we could add it as an agenda item at Arch or have a smaller scope meeting later in the week - Cheers, Antranig On 26/03/2018 15:59, Tony Atkins wrote: Hi, All:

[Architecture] Hats off to Hadtkins

2019-02-20 Thread Antranig Basman
Hi all - I'm happy to announce the merge earlier today of a huge amount of work by Tony Atkins in rewriting all of our core test cases away from PouchDB, a popular in-process replica of CouchDB, in favour of executing against an actual CouchDB instance, running in either a docker or vagrant

[Architecture] Run One Thousand

2020-03-16 Thread Antranig Basman
I'm pleased to report that after a long run of failures, runs #999 and #1000 on gpii-app have been successful, after we were able to combine fixes from Javi, Cindy and Grudell to unblock on the several correlated failures that were causing APIs to mismatch and builds to fail.

[Architecture] Nominating Tony Atkins and Joseph Scheuhammer for commit access

2020-04-24 Thread Antranig Basman
Indeed, perfection is achieved on the point of collapse. I would like to nominate Tony Atkins and Joseph Scheuhammer for commit access to the GPII repositories (https://github.com/GPII). The procedures and responsibilities for this are listed on this page: