Re: [Architecture] Force Delete Identity Providers

2017-05-19 Thread Farasath Ahamed
Another aspect to think when we delete an IDP would be the associated user accounts to that IDP[1]. I think we can also show the number of affected user accounts (user accounts that are associated with the IDP we are deleting) in the warning screen as proposed by Malithi. I too think it would be

Re: [Architecture] [MB] Best Approach to write unit tests for DAO Layer ?

2017-05-19 Thread Fazlan Nazeem
Hi Darshana, For unit testing, the correct approach is to mock the db layer as you have pointed out. But that alone is not sufficient for DAO testing. We need integration tests that would validate that our code integrates fine with the database. For this, Docker approach would be beneficial

Re: [Architecture] {APIM 3.0.0} Allowing admin user to customize Product REST APIs.

2017-05-19 Thread Ishara Cooray
By considering above discussion and the off line chat we had, it was concluded that, we allow the default resource to scope mapping remain in the Swagger doc and move whatever resource to scope mappings a user needs to deployment.yaml which is the global configuration file for the product. This

Re: [Architecture] [APIM][C5] Removing "Blocked" state from API lifecycle

2017-05-19 Thread Lakmal Warusawithana
IMO normally in SDLC there is a state call MAINTENANCE and all functionality described in this thread falling into that. Seems like we have used wrong word call BLOCKED in previous versions. But from uses point of view they should able to put an API into maintenance mode without having much

Re: [Architecture] [APIM][C5] Removing "Blocked" state from API lifecycle

2017-05-19 Thread Sanjeewa Malalgoda
One other issue i see with ballerina editing or setting throttling tiers is, business API owners need to handle that complexity. Usually developers will develop API upto some point and let business owners to handle it. Then they should be able to change API life cycle, temporary blocking etc in

Re: [Architecture] [PET] Microsoft Dynamics CRM Connector

2017-05-19 Thread Malaka Silva
Hi Kanapriya, This approach looks good. It'll not be practical to support all the entity types and there also can be custom fields. On Fri, May 19, 2017 at 11:33 AM, Kanapriya Kuleswararajan < kanapr...@wso2.com> wrote: > Hi All, > > In MicrosoftDynamicCRM, there is a method to create [1],

Re: [Architecture] [MB] Best Approach to write unit tests for DAO Layer ?

2017-05-19 Thread Fazlan Nazeem
To add to Uvindra and Darshana's comments. Trying to run integration test with a specific db will only validate that our code functions well with that specific db. With the docker image approach, we can validate our code functions properly with all those databases. On Fri, May 19, 2017 at 11:35

Re: [Architecture] [APIM][C5] Subesource access permissions in store

2017-05-19 Thread Fazlan Nazeem
Hi Sanjeewa, In facebook, if someone posts a comment on our post, then we have the permission to delete that comment even though that comment was not created by us. In a similar manner, shouldn't we at least support delete comment permission to a moderator role(api owner or a configurable

Re: [Architecture] [APIM][C5] Subesource access permissions in store

2017-05-19 Thread Sanjeewa Malalgoda
My idea was different, "Can anyone point me any site/forum which allow you to edit others comment(*not* approve/reject or *delete entire comment*)". Delete entire comment support need to be their definitely. No doubt about that. Thanks, sanjeewa. On Fri, May 19, 2017 at 12:01 PM, Fazlan Nazeem

Re: [Architecture] [PET] Microsoft Dynamics CRM Connector

2017-05-19 Thread Kanapriya Kuleswararajan
Hi All, In MicrosoftDynamicCRM, there is a method to create [1], update, delete entities and etc. But each entity has different or dynamic set of parameters [2]. Due to that , Now I'm planning to implement the connector by getting the entity type and required payload for that specific entity

Re: [Architecture] [MB] Best Approach to write unit tests for DAO Layer ?

2017-05-19 Thread Uvindra Dias Jayasinha
FYI let me give some details regarding how we are testing the APIM DAO layer for C5. 1. The DAO layer is an interface that the rest of our code interacts with in order to store and retrieve data. We mock the DOA layer and can control its behaviour to unit test how the rest of our code behaves

Re: [Architecture] [APIM][C5] Subesource access permissions in store

2017-05-19 Thread Bhathiya Jayasekara
Here are some common examples: https://help.github.com/articles/editing-a-comment/ https://en.support.wordpress.com/manage-comments/ Thanks, Bhathiya On Fri, May 19, 2017 at 12:33 PM, Sanjeewa Malalgoda wrote: > My idea was different, "Can anyone point me any site/forum

Re: [Architecture] [MB] Best Approach to write unit tests for DAO Layer ?

2017-05-19 Thread Dharshana Warusavitharana
Hi Fazlan, By using docker you are writing an Integration test, not a unit test. If you are using integration approach with docker its waste to test with in-memory databases. Just use read database like mysql. But still, if you need to validate DAO in unit layer (at component build time) you