Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-28 Thread Chiran Wijesekara
Hi all, After the review of *Swagger* *Design* of Claim Management Endpoint of WSO2 Identity Server, the source code for DTOs, Factories, and Service classes were generated using [1] as an *MSFJ service*.Then the MSF4J service was modified as an *OSGi service.* Then the msf4j-tomcat bridging

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-13 Thread Chiran Wijesekara
Hi Sanjeewa, I will updated the relevant places accordingly. Thanks for pointing out. Thank You. On Tue, Feb 13, 2018 at 12:58 PM, Sanjeewa Malalgoda wrote: > In that case please consider http status code 207[1] as simple resource > update actually handle multiple resource

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-12 Thread Sanjeewa Malalgoda
In that case please consider http status code 207[1] as simple resource update actually handle multiple resource updates (which usually refer as multi state update) [1]https://httpstatuses.com/207 Thanks, sanjeewa. On Tue, Feb 13, 2018 at 12:00 PM, Chiran Wijesekara wrote: >

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-12 Thread Chiran Wijesekara
Hi Sanjeewa, Local claims are termed as attributes. That is *Attributes = Local claim Dialect* and further, the term attributes were used to lessen the confusion between those two. Thus, the dialect refers to the custom claim dialects other the Local Claim Dialect.When adding a dialect, providing

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-12 Thread Chiran Wijesekara
Hi Prasanna, Appreciate your suggestion. However, It was done in such a way with the RESTful design guidelines and usability in mind. Thanks On Tue, Feb 13, 2018 at 11:28 AM, Sanjeewa Malalgoda wrote: > It looks like claims are attributes of dialect. In that case when user >

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-12 Thread Sanjeewa Malalgoda
It looks like claims are attributes of dialect. In that case when user create/update dialect he should be able to create it with all claims he need. I hope that claims go to externalClaims tag in json. Can you explain how it works? Is user allowed to create dialect with all claims at once? If few

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-12 Thread Prasanna Dangalla
Hi Chiran, To mitigate the inconsistencies between SOAP end REST APIs parameters, is there a possibility to use same parameter names in SOAP and REST API's?. As an example in 'DeleteLocalClaim' in SOAP claim ID is 'claimDialectURI' and in the given REST API solution its 'local-claim-id'. Thanks

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-11 Thread Chiran Wijesekara
Hi Dakshika, Claim management via a REST API is not supported yet. Currently, it is supported with SOAP. Thank you for pointing out 409 and updated the .yml at appropriate places. Thank You. On Mon, Feb 12, 2018 at 8:49 AM, Dakshika Jayathilaka wrote: > Hi Chiran, > >

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-11 Thread Dakshika Jayathilaka
Hi Chiran, Aren't we support for adding local claim via REST API? Also, don't we need to add "409 conflicts" for the scenarios that resource already exists? Regards, *Dakshika Jayathilaka* PMC Member & Committer of Apache Stratos Associate Technical Lead WSO2, Inc. lean.enterprise.middleware

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-09 Thread Chiran Wijesekara
Hi Isura, Thank you very much for your feedback. I had gone through your comments and did the changes accordingly. Please find the updated Swagger .yaml [1] attached below. [1] https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0 Thank You. On Sat, Feb 10,

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-09 Thread Isura Karunaratne
Hi Chiran, Please find the inline comments. 1) POST/dialects/{id} Add New Claim Dialect. The context for the posting a dialect should be like bellow. POST/dialects

Re: [Architecture] [IS] REST endpoint for Claim Management in IS

2018-02-09 Thread Chiran Wijesekara
Hi all, Please find the attached the link[1] to the swagger file of the REST API design. Would be glad to have your thoughts and feedback. [1] https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0 Thanks. On Thu, Feb 8, 2018 at 10:37 AM, Chiran Wijesekara