OK, the bug fix is in, with a small test case. Pushed as 3.1.3.3.
Best,
r
___
Asdf-devel mailing list
Asdf-devel@common-lisp.net
http://common-lisp.net/cgi-bin/mailman/listinfo/asdf-devel
Now that I think of it, I see a problem with your solution:
there can be situations where you register your system as immutable
and preloaded,
but since it's not registered as defined yet, find-system will still
look for it on disk.
I believe you need to either have you register-immutable-system
Thanks to both of you for your work on this patch.
I'm going to hold off on applying any patches, though, until there's a
test case.
Dave, I understand that it might be hard to wrap your head around the
test script code, so let's start by brainstorming what the test should
do, rather than
Ok here is an updated patch which does a register-system as well as
register-preloaded-system as part of register-immutable-system. It tries to
preserve version information according to what Faré recommended.
It also patches clear-system and clear-defined-system so as to prevent
clearing any
Getting there!
More nits:
* Up until now, clear-defined-system had no declared return value; I
propose you instead
return T if successful, NIL if unsuccessful, and just use an unless
rather than if.
* It's unclear to me what clear-system does or should do that differs
from clear-defined-system.
On Mon, Aug 11, 2014 at 10:36 AM, Faré fah...@gmail.com wrote:
On Mon, Aug 11, 2014 at 10:19 AM, Robert P. Goldman rpgold...@sift.info
wrote:
Thanks to both of you for your work on this patch.
I'm going to hold off on applying any patches, though, until there's a
test case.
Dave, I
* It's unclear to me what clear-system does or should do that differs
from clear-defined-system.
I see that clear-system is documented in asdf.texinfo, but
clear-defined-system isn't;
furthermore, clear-defined-system doesn't appear anywhere in
quicklisp, as I can tell
grepping
On Mon, Aug 11, 2014 at 1:12 PM, Dave Cooper david.coo...@genworks.com wrote:
What about clear-defined-systems (plural)?
This is exported functionality and it calls clear-defined-system.
Should it be changed to clear-systems and made to call clear-system, or kept
the same and made to call
On Mon, Aug 11, 2014 at 1:02 PM, Faré fah...@gmail.com wrote:
Getting there!
More nits:
Please see attached patch, still against 3.1.3.2 of master.
A year ago, I would have fixed it all myself — today I'm just telling
you how to do it, and hoping that it helps create new ASDF
Almost there.
You did rename the function in a call to register-hook-function. Oops.
Can you run tests on at least one implementation before you submit?
Also, for historical reasons, the registered-system thing is a cons
cell, not a list.
cdr is more appropriate than rest, here.
—♯ƒ •
10 matches
Mail list logo
