Re: package-inferred-systems and primary-system-name

2018-03-08 Thread Robert Goldman
On 1 Mar 2018, at 10:47, Eric Timmons wrote: > MR sent. I took the approach of setting the source-file. The etypecase > approach would have either introduced a circular dependency between > system.lisp and package-inferred-system.lisp or would have required > the package-inferred-system symbol to

Re: package-inferred-systems and primary-system-name

2018-03-01 Thread Eric Timmons
MR sent. I took the approach of setting the source-file. The etypecase approach would have either introduced a circular dependency between system.lisp and package-inferred-system.lisp or would have required the package-inferred-system symbol to be exported from system.lisp which felt wrong. -Eric

Re: package-inferred-systems and primary-system-name

2018-02-28 Thread Faré
Dear Eric, Robert, >:Eric > If a have a package-inferred-systems "a" and "a/b/c", the following > code used to return "a": > > (primary-system-name (find-system "a/b/c")) > > But after commit 069cd2a6 it returns nil. > Thanks for finding that bug. Sorry we didn't have regression tests for that. >

Re: package-inferred-systems and primary-system-name

2018-02-28 Thread Robert Goldman
On 28 Feb 2018, at 15:46, Eric Timmons wrote: If a have a package-inferred-systems "a" and "a/b/c", the following code used to return "a": (primary-system-name (find-system "a/b/c")) But after commit 069cd2a6 it returns nil. Happy to patch it, but I wanted to check how to do it before startin

package-inferred-systems and primary-system-name

2018-02-28 Thread Eric Timmons
If a have a package-inferred-systems "a" and "a/b/c", the following code used to return "a": (primary-system-name (find-system "a/b/c")) But after commit 069cd2a6 it returns nil. Happy to patch it, but I wanted to check how to do it before starting. The root cause right now is that system-source