Re: [aspectj-users] Are there conflicts using LTW and CTW in the same application?

2018-06-14 Thread Eric B
Is my syntax for exclusion incorrect though? It doesn't seem to be working. I added: But I still see the aspect being rewritten (and reverted) in the _ajdump folder. However, if i explicitly set the exclude to the full package name: it works fine. Is my exclusion syntax

Re: [aspectj-users] Are there conflicts using LTW and CTW in the same application?

2018-06-14 Thread Andy Clement
I added a bug yesterday https://bugs.eclipse.org/bugs/show_bug.cgi?id=535877 with my minimal test code in. Basically annotation style just hasn't got equal test coverage with code style so we are going to hit things like this occasionally. Excluding via @Aspect annotation is quite a clever

Re: [aspectj-users] Are there conflicts using LTW and CTW in the same application?

2018-06-13 Thread Eric B
I have worked around the issue by adding it to an in the tag, but I was a bit surprised I had to do that. Reading your explanation now, makes it a little more clear. I tend to prefer annotation style aspects, simply because, in general, most other people who need to maintain the codebase are

Re: [aspectj-users] Are there conflicts using LTW and CTW in the same application?

2018-06-13 Thread Andy Clement
I did just recreate this, I suspect one reason is hasn’t shown up before is because we don’t typically use annotation style aspects in test cases. If your aspect is annotation style and not code style you will see the aspectOf() issue. I originally wrote mine as code style (the CTW aspect) -

Re: [aspectj-users] Are there conflicts using LTW and CTW in the same application?

2018-06-13 Thread Andy Clement
Let me try to interpret this from what I remember: > 2018-06-12 10:21:52,079 ERROR [stderr] [ModuleClassLoader@2d758982] debug > weaving 'org.webapp.sso.keycloak.aspect.ClientErrorExceptionHandler' > 2018-06-12 10:21:52,093 ERROR [stderr] [ModuleClassLoader@2d758982] info > processing

Re: [aspectj-users] Are there conflicts using LTW and CTW in the same application?

2018-06-12 Thread Eric B
Thanks for the link Andy. I read through the overweaving description, and I agree that it doesn't sound like it applies. The aspect missing the aspectOf() is part of the CTW. All Aspects are annotation based (@Aspect). The LTW was built using ajc. Without the CTW aspects, everything runs

Re: [aspectj-users] Are there conflicts using LTW and CTW in the same application?

2018-06-11 Thread Andy Clement
By default if you weave aspects on top of aspects then we use a model where we revert to the original class file before the first set of aspects was applied and apply all of them (the original aspects plus the new ones) at the same time to ensure consistency. This behavior is configurable using