Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread Joshua Colp
On Dec. 17, 2013, 11:44 p.m., rmudgett wrote: /branches/12/res/res_calendar.c, line 780 https://reviewboard.asterisk.org/r/3067/diff/2-3/?file=49704#file49704line780 Existing bug: chan needs to be locked when adding a datastore. I've fixed this in 1.8 and up since it was applicable

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread Joshua Colp
On Dec. 16, 2013, 8:26 p.m., rmudgett wrote: /branches/12/main/channel.c, lines 10399-10400 https://reviewboard.asterisk.org/r/3069/diff/1/?file=49555#file49555line10399 One thing that ast_channel_masquerade() did that is not being done anymore is queuing null frames to wake up

Re: [asterisk-dev] [Code Review] 3070: bridges: Add two new properties to bridges and bridge snapshots - the name of a creator and the name the creator uses to refer to that bridge

2013-12-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3070/ --- (Updated Dec. 18, 2013, 12:36 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057/#review10449 --- Ship it! - Joshua Colp On Dec. 12, 2013, 6:03 p.m., Matt

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10450 --- /branches/12/main/core_unreal.c

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10451 --- Ship it! Ship It! - rmudgett On Dec. 18, 2013, 5:31 p.m.,

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-18 Thread rmudgett
On Dec. 18, 2013, 2:28 a.m., Matt Jordan wrote: /branches/12/channels/chan_sip.c, line 30853 https://reviewboard.asterisk.org/r/3072/diff/1/?file=49615#file49615line30853 The length of this should be AST_MAX_EXTENSION + the length of the context + 2. (Alternatively, use

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072/ --- (Updated Dec. 18, 2013, 6:51 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/ --- (Updated Dec. 18, 2013, 7:27 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3078: astdb: crash in sqlite3 during shutdown

2013-12-18 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3078/ --- Review request for Asterisk Developers. Bugs: AST-1265 and ASTERISK-22350

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- (Updated Dec. 18, 2013, 8:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3078: astdb: crash in sqlite3 during shutdown

2013-12-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3078/#review10454 --- /branches/11/main/db.c

Re: [asterisk-dev] [Code Review] 3078: astdb: crash in sqlite3 during shutdown

2013-12-18 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3078/ --- (Updated Dec. 18, 2013, 3:26 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3078: astdb: crash in sqlite3 during shutdown

2013-12-18 Thread Scott Griepentrog
On Dec. 18, 2013, 2:53 p.m., Mark Michelson wrote: /branches/11/main/db.c, lines 150-156 https://reviewboard.asterisk.org/r/3078/diff/1/?file=49824#file49824line150 I got a bit curious about how sqlite3_finalize() works, so I took a look at the source code. If I'm

Re: [asterisk-dev] [Code Review] 3078: astdb: crash in sqlite3 during shutdown

2013-12-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3078/#review10456 --- Ship it! Ship It! - Mark Michelson On Dec. 18, 2013, 9:26

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/#review10453 --- /branches/12/main/channel.c

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072/#review10458 --- Ship it! /branches/12/CHANGES

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072/#review10457 --- /branches/12/apps/app_voicemail.c

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- (Updated Dec. 18, 2013, 11:10 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072/ --- (Updated Dec. 18, 2013, 11:40 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072/#review10459 --- Ship it! Ship It! - Mark Michelson On Dec. 18, 2013, 11:40

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/#review10460 --- Ship it! Ship It! - rmudgett On Dec. 18, 2013, 11:10 p.m.,

[asterisk-dev] [Code Review] 3079: udptl: Dead code elimination. ast_udptl_bridge not used.

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3079/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3079: udptl: Dead code elimination. ast_udptl_bridge not used.

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3079/ --- (Updated Dec. 19, 2013, 12:21 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057/ --- (Updated Dec. 18, 2013, 6:50 p.m.) Status -- This change has been