Re: [asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

> On Jan. 13, 2014, 4:24 p.m., Matt Jordan wrote: > > /branches/12/main/http.c, lines 804-805 > > > > > > You don't need the while(1) here, as you aren't breaking out of the > > block scope that it provides. > > r

Re: [asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3125/ --- (Updated Jan. 13, 2014, 5:26 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

> On Jan. 13, 2014, 4:24 p.m., Matt Jordan wrote: > > /branches/12/main/http.c, lines 804-805 > > > > > > You don't need the while(1) here, as you aren't breaking out of the > > block scope that it provides. The c

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/#review10587 --- /branches/11/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3114: verbosity: Fix performance of console verbose messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3114/#review10586 --- Ship it! Ship It! - Matt Jordan On Jan. 10, 2014, 1:26 p.m.

Re: [asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3125/#review10583 --- /branches/12/include/asterisk/http.h

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/#review10585 --- Ship it! Ship It! - Mark Michelson On Jan. 10, 2014, 11:03

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/#review10584 --- Ship it! Ship It! - Mark Michelson On Jan. 13, 2014, 9:41 p

[asterisk-dev] [Code Review] 3126: testsuite: check chunked Transfer-Encoding operation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3126/ --- Review request for Asterisk Developers and Matt Jordan. Bugs: ASTERISK-230

[asterisk-dev] [Code Review] 3125: http: support chunked Transfer-Encoding

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3125/ --- Review request for Asterisk Developers and Matt Jordan. Bugs: ASTERISK-230

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/ --- (Updated Jan. 13, 2014, 3:41 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

> On Jan. 13, 2014, 3:07 p.m., rmudgett wrote: > > /branches/11/channels/chan_sip.c, lines 24188-24192 > > > > > > You might want to delay setting transferer_pvt to after the call to > > ast_park_call_exten(). T

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/#review10580 --- /branches/11/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/#review10579 --- Ship it! Ship It! - Joshua Colp On Jan. 13, 2014, 8:48 p.m.

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/#review10578 --- One last thing before this goes in: (1) Add an update to the a

Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/ --- (Updated Jan. 13, 2014, 2:48 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/#review10577 --- Ship it! Besides my wish to kill excessive RAII_VAR usage this

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/#review10576 --- Ship it! Ship It! - Joshua Colp On Jan. 9, 2014, 5:34 p.m.,

[asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23062 https://i

[asterisk-dev] [Code Review] 3123: chan_pjsip: initial device state on endpoints is INVALID

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3123/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23065 https://i

Re: [asterisk-dev] [Code Review] 3089: Presenting AO2_ITERATOR_SAFE_LOOP_START() for ao2_iterator looping safety.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3089/ --- (Updated Jan. 13, 2014, 12:03 p.m.) Status -- This change has been di

[asterisk-dev] [Code Review] 3122: ARI: Add support for specifying channel variables during originate

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3122/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23051 https://i

[asterisk-dev] [Code Review] 3121: testsuite: Add two ConfBridge tests for Marked/WaitMarked user interaction

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3121/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

Re: [asterisk-dev] [Code Review] 3114: verbosity: Fix performance of console verbose messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3114/#review10573 --- Ship it! Performance speedup is as expected; no other regressi

Re: [asterisk-dev] [Code Review] 3115: res_pjsip: Fix CLI tab completion issues

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3115/ --- (Updated Jan. 13, 2014, 7:39 a.m.) Status -- This change has been mar