Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3734/#review12554 ---

[asterisk-dev] [Code Review] 3744: Change the description of codec ADPCM to Dialogic ADCPM.

2014-07-11 Thread Dennis Guse
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3744/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] Is there a possibility get async notificaiton when a channel state changed

2014-07-11 Thread vassilux .
Hi Is there a possibility to install a callback in a channel to be notified when the channel state has been changed, for example the call was hung up. Thank -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] Is there a possibility get async notificaiton when a channel state changed

2014-07-11 Thread Matthew Jordan
On Fri, Jul 11, 2014 at 3:19 AM, vassilux . v.gontcha...@gmail.com wrote: Hi Is there a possibility to install a callback in a channel to be notified when the channel state has been changed, for example the call was hung up. Your question is a little vague. Do you mean: - Through an

Re: [asterisk-dev] [Code Review] 3742: media formats: Ensure that chan_pjsip sets its native formats properly

2014-07-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3742/ --- (Updated July 11, 2014, 7:47 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3744: Change the description of codec ADPCM to Dialogic ADCPM.

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3744/#review12555 --- Ship it! Ship It! - Matt Jordan On July 11, 2014, 2:45

Re: [asterisk-dev] [Code Review] 3708: config: inform config hook of configuration change when writing file

2014-07-11 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3708/ --- (Updated July 11, 2014, 9:23 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3745: func_uri: URIENCODE - Remove warning messages when empty string is passed for the argument

2014-07-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3745/ --- Review request for Asterisk Developers and Matt Jordan. Bugs:

Re: [asterisk-dev] [Code Review] 3745: func_uri: URIENCODE/URIDECODE - Remove warning messages when empty string is passed for the argument

2014-07-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3745/ --- (Updated July 11, 2014, 11:09 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3745: func_uri: URIENCODE - Remove warning messages when empty string is passed for the argument

2014-07-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3745/ --- (Updated July 11, 2014, 11:09 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3745: func_uri: URIENCODE/URIDECODE - Remove warning messages when empty string is passed for the argument

2014-07-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3745/#review12557 --- /branches/1.8/funcs/func_uri.c

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

2014-07-11 Thread Matt Jordan
On July 11, 2014, 1:43 a.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/tests/test_core_format.c, lines 61-66 https://reviewboard.asterisk.org/r/3734/diff/4/?file=62711#file62711line61 Do we really want doxygen tags on unit tests? Yes! (1) It's generally

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3734/ --- (Updated July 11, 2014, 11:55 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

2014-07-11 Thread Corey Farrell
On July 11, 2014, 2:43 a.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/tests/test_core_format.c, lines 61-66 https://reviewboard.asterisk.org/r/3734/diff/4/?file=62711#file62711line61 Do we really want doxygen tags on unit tests? Matt Jordan wrote:

Re: [asterisk-dev] [Code Review] 3740: media formats: unregister interfaces on shutdown; clean up chan_dahdi capabilities if channel driver doesn't load

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3740/ --- (Updated July 11, 2014, 2:27 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3746: media formats: Fix double unref on full cache

2014-07-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3746/ --- Review request for Asterisk Developers, Corey Farrell and Matt Jordan.

[asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/ --- Review request for Asterisk Developers, Corey Farrell, Joshua Colp, Matt

[asterisk-dev] [Code Review] 3748: translate.c: Fix ref leaks in ast_translator_best_choice().

2014-07-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3748/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3749: chan_dahdi.c: Restore some sanity checks on frames that dahdi_write() cannot handle.

2014-07-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3749/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/#review12559 --- /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/#review12560 ---

[asterisk-dev] [Code Review] 3743: astobj2: tweak ao2_replace to do nothing when it would be a NoOp

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3743/ --- Review request for Asterisk Developers and Matt Jordan. Repository:

Re: [asterisk-dev] [Code Review] 3743: astobj2: tweak ao2_replace to do nothing when it would be a NoOp

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3743/#review12561 --- Ship it! Ship It! - Matt Jordan On July 11, 2014, 3:50

Re: [asterisk-dev] [Code Review] 3743: astobj2: tweak ao2_replace to do nothing when it would be a NoOp

2014-07-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3743/#review12562 --- Ship it! Ship It! - opticron On July 11, 2014, 3:50 p.m.,

Re: [asterisk-dev] [Code Review] 3748: translate.c: Fix ref leaks in ast_translator_best_choice().

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3748/#review12563 --- Ship it! Ship It! - Corey Farrell On July 11, 2014, 4:15

Re: [asterisk-dev] [Code Review] 3746: media formats: Fix double unref on full cache

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3746/#review12564 --- Ship it! Ship It! - Corey Farrell On July 11, 2014, 3:30

Re: [asterisk-dev] [Code Review] 3746: media formats: Fix double unref on full cache

2014-07-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3746/ --- (Updated July 11, 2014, 4:01 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3750/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3743: astobj2: tweak ao2_replace to do nothing when it would be a NoOp

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3743/ --- (Updated July 11, 2014, 4:09 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/#review12566 ---

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/#review12567 --- /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.9.2-rc2 Now Available

2014-07-11 Thread Asterisk Development Team
The Asterisk Development Team has announced the releases of: DAHDI-Linux-v2.9.2-rc2 DAHDI-Tools-v2.9.2-rc2 dahdi-linux-complete-2.9.2-rc2+2.9.2-rc2 This release is available for immediate download at: http://downloads.asterisk.org/pub/telephony/dahdi-linux

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Jonathan Rose
On July 11, 2014, 4:18 p.m., opticron wrote: /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c, line 6023 https://reviewboard.asterisk.org/r/3747/diff/2/?file=62811#file62811line6023 I had a similar situation in the RTP engine and the solution was to figure out why

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

2014-07-11 Thread Matt Jordan
On July 11, 2014, 1:43 a.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/tests/test_format_cap.c, line 478 https://reviewboard.asterisk.org/r/3734/diff/4/?file=62713#file62713line478 Should we also test that the counts from original dst_caps + src_caps == count?

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3734/ --- (Updated July 11, 2014, 4:26 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3734/#review12570 --- Ship it! Ship It! - Corey Farrell On July 11, 2014, 5:26

Re: [asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3750/ --- (Updated July 11, 2014, 4:32 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3750/#review12571 ---

[asterisk-dev] [Code Review] 3751: media_formats: resolve double unref of fmt in sip_new, clear fr-mallocd when we're not freeing fr.

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3751/ --- Review request for Asterisk Developers and Matt Jordan. Repository:

Re: [asterisk-dev] [Code Review] 3751: media_formats: resolve double unref of fmt in sip_new, clear fr-mallocd when we're not freeing fr.

2014-07-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3751/#review12572 --- Ship it! Ship It! - opticron On July 11, 2014, 5 p.m.,

Re: [asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

2014-07-11 Thread Matt Jordan
On July 11, 2014, 4:38 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/include/asterisk/astobj2.h, lines 541-550 https://reviewboard.asterisk.org/r/3750/diff/2/?file=62831#file62831line541 Why get rid of the tab indenting? I'm not sure why my editor decided

Re: [asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3750/#review12574 --- Ship it! Ship It! - Corey Farrell On July 11, 2014, 5:32

Re: [asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

2014-07-11 Thread rmudgett
On July 11, 2014, 5:22 p.m., Corey Farrell wrote: Ship It! Should be just committed to trunk and let automerge take care of the media_formats merge. - rmudgett --- This is an automatically generated e-mail. To reply, visit:

Re: [asterisk-dev] [Code Review] 3751: media_formats: resolve double unref of fmt in sip_new, clear fr-mallocd when we're not freeing fr.

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3751/ --- (Updated July 11, 2014, 5:26 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Jonathan Rose
On July 11, 2014, 4:18 p.m., opticron wrote: /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c, line 6023 https://reviewboard.asterisk.org/r/3747/diff/2/?file=62811#file62811line6023 I had a similar situation in the RTP engine and the solution was to figure out why

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Jonathan Rose
On July 11, 2014, 4:18 p.m., opticron wrote: /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c, line 6023 https://reviewboard.asterisk.org/r/3747/diff/2/?file=62811#file62811line6023 I had a similar situation in the RTP engine and the solution was to figure out why

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Corey Farrell
On July 11, 2014, 5:18 p.m., opticron wrote: /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c, line 6023 https://reviewboard.asterisk.org/r/3747/diff/2/?file=62811#file62811line6023 I had a similar situation in the RTP engine and the solution was to figure out why

Re: [asterisk-dev] [Code Review] 3748: translate.c: Fix ref leaks in ast_translator_best_choice().

2014-07-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3748/ --- (Updated July 11, 2014, 5:46 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/ --- (Updated July 11, 2014, 5:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3750: media_formats: Add tag variants of ao2_bump/ao2_replace/ao2_cleanup

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3750/ --- (Updated July 11, 2014, 6 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3734: media formats: Add a 'none' format to prevent NULL format derefences; update unit tests

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3734/ --- (Updated July 11, 2014, 9:02 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3752/ --- Review request for Asterisk Developers and Corey Farrell. Repository:

[asterisk-dev] [Code Review] 3753: media_formats: Prevent crash during masquerade

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3753/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3752/#review12579 --- I think the way this has to be fixes is to simply get rid of

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-11 Thread Matt Jordan
On July 11, 2014, 10:01 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/astobj2.c, lines 503-507 https://reviewboard.asterisk.org/r/3752/diff/1/?file=62839#file62839line503 This reorder will prevent ref_log from recording a double-free. Example:

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-11 Thread Corey Farrell
On July 11, 2014, 11:01 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/main/astobj2.c, lines 503-507 https://reviewboard.asterisk.org/r/3752/diff/1/?file=62839#file62839line503 This reorder will prevent ref_log from recording a double-free. Example:

[asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

2014-07-11 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3754/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23959

Re: [asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3754/#review12582 --- It looks like the missing unref is a bug in 1.8+, so it should

Re: [asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

2014-07-11 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3754/ --- (Updated July 11, 2014, 11:35 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3755: Remove files left behind by h323, jabber, jingle

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3755/ --- Review request for Asterisk Developers and Matt Jordan. Repository:

Re: [asterisk-dev] [Code Review] 3755: Remove files left behind by h323, jabber, jingle

2014-07-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3755/#review12584 --- Ship it! Ship It! - rmudgett On July 11, 2014, 11:36 p.m.,

Re: [asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3754/#review12585 --- Ship it! Sorry I should have checked better, it appears this

Re: [asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

2014-07-11 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3754/ --- (Updated July 12, 2014, 12:58 a.m.) Review request for Asterisk