Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-16 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3982/ --- (Updated Sept. 16, 2014, 6:08 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3916: Testsuite: Add test for AllVariables Status parameter

2014-09-16 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3916/ --- (Updated Sept. 16, 2014, 8:09 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

2014-09-16 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/ --- (Updated Sept. 16, 2014, 9:42 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

2014-09-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/#review13310 --- Ship it! There are now several places in the code where the

Re: [asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

2014-09-16 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/ --- (Updated Sept. 16, 2014, 11:32 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3966: Testsuite: RLS batched notification tests

2014-09-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3966/#review13311 --- Ship it!

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13312 --- /branches/12/include/asterisk/dial.h

Re: [asterisk-dev] [Code Review] 3994: Bridges User Documentation Update

2014-09-16 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3994/#review13314 --- The relationship between the native, local, and remote types

Re: [asterisk-dev] [Code Review] 3971: astobj2.c/refcounter.py: Fix to deal with invalid object refs.

2014-09-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3971/ --- (Updated Sept. 16, 2014, 1:15 p.m.) Review request for Asterisk

[asterisk-dev] Realtime ODBC voicemail and fromstring variable

2014-09-16 Thread Leandro Dardini
I think to have found an issue, but before reporting on issue.asterisk.org, I'd like to get an advice here... I am using realtime ODBC voicemail and all works great except I cannot set the fromuser settings. It is ignored and the default one is used. The problem seems laying in the definition of

Re: [asterisk-dev] [Code Review] 3994: Bridges User Documentation Update

2014-09-16 Thread opticron
On Sept. 16, 2014, 12:32 p.m., Matt Jordan wrote: The place that needs the most improvement is Multi-party - Mixing: - MeetMe is _not_ more performant (ever). The description also doesn't tell a user what MeetMe actually is: a conference bridge for multiple channels. -

Re: [asterisk-dev] [Code Review] 3994: Bridges User Documentation Update

2014-09-16 Thread opticron
On Sept. 16, 2014, 12:37 p.m., Scott Griepentrog wrote: The relationship between the native, local, and remote types is not clear. This could cause confusion in the reader trying to understand the types. Although there is a hierarchy in the underlying document format, this is not

[asterisk-dev] Git Migration

2014-09-16 Thread Matthew Jordan
And there was much rejoicing But seriously, we all know that a lot of people have wanted to move to Git for some time. For the record, everyone at Digium has wanted to move the project to Git for some time. I swore to myself that we wouldn't do another Standard release on Subversion - after we

[asterisk-dev] [Code Review] 3999: chan_iax2: Jitterbuffer causes crash in Asterisk 13 on account of format changes

2014-09-16 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3999/ --- Review request for Asterisk Developers, Matt Jordan and rmudgett. Bugs:

Re: [asterisk-dev] Git Migration

2014-09-16 Thread George Joseph
On Tue, Sep 16, 2014 at 1:48 PM, Matthew Jordan mjor...@digium.com wrote: And there was much rejoicing To summarize: * A comparison of management platforms has been done. Barring a giant catastrophe or some insane limitation, we're going to go simple here and stick with gitolite. Reasoning

Re: [asterisk-dev] Git Migration

2014-09-16 Thread Russell Bryant
On Tue, Sep 16, 2014 at 3:48 PM, Matthew Jordan mjor...@digium.com wrote: And there was much rejoicing \o/ But seriously, we all know that a lot of people have wanted to move to Git for some time. For the record, everyone at Digium has wanted to move the project to Git for some time. I

Re: [asterisk-dev] Git Migration

2014-09-16 Thread Russell Bryant
On Tue, Sep 16, 2014 at 6:01 PM, Russell Bryant russ...@russellbryant.net wrote: From a high level, all patches go to a code review system. *Every* patch must be peer reviewed (usually by 2 people, but that's a policy decision). *Every* patch must also pass tests. Once a patch passes both

Re: [asterisk-dev] Git Migration

2014-09-16 Thread Russell Bryant
On Tue, Sep 16, 2014 at 6:12 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 6:01 PM, Russell Bryant russ...@russellbryant.net wrote: From a high level, all patches go to a code review system. *Every* patch must be peer reviewed (usually by 2 people, but that's

Re: [asterisk-dev] Git Migration

2014-09-16 Thread Matthew Jordan
On Tue, Sep 16, 2014 at 4:31 PM, George Joseph george.jos...@fairview5.com wrote: On Tue, Sep 16, 2014 at 1:48 PM, Matthew Jordan mjor...@digium.com wrote: And there was much rejoicing To summarize: * A comparison of management platforms has been done. Barring a giant catastrophe or some

Re: [asterisk-dev] Git Migration

2014-09-16 Thread Matthew Jordan
On Tue, Sep 16, 2014 at 6:00 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 6:12 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 6:01 PM, Russell Bryant russ...@russellbryant.net wrote: From a high level, all patches go to a code